Chris Wilson
209df10bb4
drm/i915: Defer semaphore priority bumping to a workqueue ...
Since the semaphore fence may be signaled from inside an interrupt
handler from inside a request holding its request->lock, we cannot then
enter into the engine->active.lock for processing the semaphore priority
bump as we may traverse our call tree and end up on another held
request.
CPU 0:
[ 2243.218864] _raw_spin_lock_irqsave+0x9a/0xb0
[ 2243.218867] i915_schedule_bump_priority+0x49/0x80 [i915]
[ 2243.218869] semaphore_notify+0x6d/0x98 [i915]
[ 2243.218871] __i915_sw_fence_complete+0x61/0x420 [i915]
[ 2243.218874] ? kmem_cache_free+0x211/0x290
[ 2243.218876] i915_sw_fence_complete+0x58/0x80 [i915]
[ 2243.218879] dma_i915_sw_fence_wake+0x3e/0x80 [i915]
[ 2243.218881] signal_irq_work+0x571/0x690 [i915]
[ 2243.218883] irq_work_run_list+0xd7/0x120
[ 2243.218885] irq_work_run+0x1d/0x50
[ 2243.218887] smp_irq_work_interrupt+0x21/0x30
[ 2243.218889] irq_work_interrupt+0xf/0x20
CPU 1:
[ 2242.173107] _raw_spin_lock+0x8f/0xa0
[ 2242.173110] __i915_request_submit+0x64/0x4a0 [i915]
[ 2242.173112] __execlists_submission_tasklet+0x8ee/0x2120 [i915]
[ 2242.173114] ? i915_sched_lookup_priolist+0x1e3/0x2b0 [i915]
[ 2242.173117] execlists_submit_request+0x2e8/0x2f0 [i915]
[ 2242.173119] submit_notify+0x8f/0xc0 [i915]
[ 2242.173121] __i915_sw_fence_complete+0x61/0x420 [i915]
[ 2242.173124] ? _raw_spin_unlock_irqrestore+0x39/0x40
[ 2242.173137] i915_sw_fence_complete+0x58/0x80 [i915]
[ 2242.173140] i915_sw_fence_commit+0x16/0x20 [i915]
Closes: https://gitlab.freedesktop.org/drm/intel/issues/1318
Fixes: b7404c7ecb38 ("drm/i915: Bump ready tasks ahead of busywaits")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: <stable@vger.kernel.org> # v5.2+
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200310101720.9944-1-chris@chris-wilson.co.uk
2020-03-10 23:12:38 +00:00
2020-02-11 23:26:15 +01:00
2020-01-29 18:53:37 -08:00
2020-02-06 06:11:50 +00:00
2020-01-28 16:02:33 -08:00
2020-02-08 14:04:19 -08:00
2020-01-28 16:02:33 -08:00
2020-02-08 13:26:41 -08:00
2020-01-24 19:57:53 +01:00
2020-02-15 10:33:19 -08:00
2020-02-16 13:05:46 -08:00
2020-02-08 14:17:27 -08:00
2020-02-08 14:17:27 -08:00
2020-02-14 10:40:48 +01:00
2020-02-08 14:04:19 -08:00
2020-01-28 16:02:33 -08:00
2020-01-16 09:52:27 -08:00
2020-01-16 19:14:49 +09:00
2020-02-08 13:58:44 -08:00
2020-02-13 13:29:41 +01:00
2020-02-08 14:04:19 -08:00
2020-01-10 12:51:56 -08:00
2020-02-10 13:54:17 +01:00
2020-03-10 23:12:38 +00:00
2020-01-30 08:04:01 -08:00
2020-02-03 14:42:03 +00:00
2020-02-12 12:43:01 -08:00
2020-01-21 16:16:36 -08:00
2020-01-14 15:38:28 +01:00
2020-02-07 12:54:13 -08:00
2020-01-13 10:00:05 +01:00
2020-02-04 03:05:26 +00:00
2020-02-03 11:57:18 +01:00
2020-02-04 07:17:41 +00:00
2020-02-14 15:21:52 -04:00
2020-02-15 16:49:25 -08:00
2020-02-05 17:49:54 +00:00
2020-02-09 15:47:37 -08:00
2020-02-04 03:05:26 +00:00
2020-01-22 21:08:24 +01:00
2020-02-04 13:06:46 +00:00
2020-01-08 10:41:52 +01:00
2020-02-16 12:35:52 -08:00
2020-02-04 07:17:41 +00:00
2020-01-16 10:45:44 -08:00
2020-01-19 22:10:04 +01:00
2020-02-04 07:17:41 +00:00
2020-02-07 12:54:13 -08:00
2020-01-27 13:03:00 -08:00
2020-02-04 03:05:27 +00:00
2020-02-14 07:05:17 -08:00
2020-01-19 22:10:04 +01:00
2020-01-31 10:30:37 -08:00
2020-02-16 12:35:52 -08:00
2020-02-07 12:54:13 -08:00
2020-02-08 14:04:19 -08:00
2020-01-27 13:03:00 -08:00
2020-01-13 13:19:38 -05:00
2020-02-04 03:05:26 +00:00
2020-02-06 14:17:38 +00:00
2020-02-10 18:14:46 +00:00
2020-02-04 03:05:27 +00:00
2020-02-04 03:05:24 +00:00
2020-02-04 07:24:48 +00:00
2020-02-04 03:05:26 +00:00
2020-02-08 13:55:25 -08:00
2020-01-13 10:32:19 +01:00
2020-01-19 22:10:04 +01:00
2020-01-20 15:40:49 +01:00
2020-02-03 14:51:57 +00:00
2020-01-24 09:34:07 -08:00
2020-01-10 22:20:37 -08:00
2020-01-20 10:29:56 -08:00
2020-02-04 07:17:41 +00:00
2020-02-11 20:14:28 +01:00
2020-02-08 17:24:41 -08:00
2020-01-14 21:46:53 +01:00
2020-01-14 21:46:48 +01:00
2020-02-11 15:00:15 -08:00
2020-01-16 17:34:38 +05:30
2020-02-04 03:05:27 +00:00
2020-02-10 13:16:04 +01:00
2020-02-04 03:05:26 +00:00
2020-01-29 18:16:16 -08:00
2020-01-31 11:28:31 -08:00
2020-02-08 14:04:19 -08:00
2020-01-31 14:39:21 -08:00
2020-01-14 15:37:41 +01:00
2020-02-09 16:05:50 -08:00
2020-01-14 15:27:51 +01:00
2020-02-08 13:26:41 -08:00
2020-02-03 22:22:05 +00:00
2020-02-21 05:44:40 +10:00
2020-02-06 03:40:27 -05:00
2020-01-14 15:30:35 +01:00
2020-01-29 10:35:54 -08:00
2020-01-29 10:35:54 -08:00
2020-02-07 12:30:16 -08:00
2020-02-05 17:44:14 +00:00
2020-02-09 16:05:50 -08:00
209df10bb4