Ye Bin
14b6ad56df
ext4: fix kernel BUG in 'ext4_write_inline_data_end()' ...
commit 5c099c4fdc438014d5893629e70a8ba934433ee8 upstream.
Syzbot report follow issue:
------------[ cut here ]------------
kernel BUG at fs/ext4/inline.c:227!
invalid opcode: 0000 [#1 ] PREEMPT SMP KASAN
CPU: 1 PID: 3629 Comm: syz-executor212 Not tainted 6.1.0-rc5-syzkaller-00018-g59d0d52c30d4 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
RIP: 0010:ext4_write_inline_data+0x344/0x3e0 fs/ext4/inline.c:227
RSP: 0018:ffffc90003b3f368 EFLAGS: 00010293
RAX: 0000000000000000 RBX: ffff8880704e16c0 RCX: 0000000000000000
RDX: ffff888021763a80 RSI: ffffffff821e31a4 RDI: 0000000000000006
RBP: 000000000006818e R08: 0000000000000006 R09: 0000000000068199
R10: 0000000000000079 R11: 0000000000000000 R12: 000000000000000b
R13: 0000000000068199 R14: ffffc90003b3f408 R15: ffff8880704e1c82
FS: 000055555723e3c0(0000) GS:ffff8880b9b00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fffe8ac9080 CR3: 0000000079f81000 CR4: 0000000000350ee0
Call Trace:
<TASK>
ext4_write_inline_data_end+0x2a3/0x12f0 fs/ext4/inline.c:768
ext4_write_end+0x242/0xdd0 fs/ext4/inode.c:1313
ext4_da_write_end+0x3ed/0xa30 fs/ext4/inode.c:3063
generic_perform_write+0x316/0x570 mm/filemap.c:3764
ext4_buffered_write_iter+0x15b/0x460 fs/ext4/file.c:285
ext4_file_write_iter+0x8bc/0x16e0 fs/ext4/file.c:700
call_write_iter include/linux/fs.h:2191 [inline]
do_iter_readv_writev+0x20b/0x3b0 fs/read_write.c:735
do_iter_write+0x182/0x700 fs/read_write.c:861
vfs_iter_write+0x74/0xa0 fs/read_write.c:902
iter_file_splice_write+0x745/0xc90 fs/splice.c:686
do_splice_from fs/splice.c:764 [inline]
direct_splice_actor+0x114/0x180 fs/splice.c:931
splice_direct_to_actor+0x335/0x8a0 fs/splice.c:886
do_splice_direct+0x1ab/0x280 fs/splice.c:974
do_sendfile+0xb19/0x1270 fs/read_write.c:1255
__do_sys_sendfile64 fs/read_write.c:1323 [inline]
__se_sys_sendfile64 fs/read_write.c:1309 [inline]
__x64_sys_sendfile64+0x1d0/0x210 fs/read_write.c:1309
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
---[ end trace 0000000000000000 ]---
Above issue may happens as follows:
ext4_da_write_begin
ext4_da_write_inline_data_begin
ext4_da_convert_inline_data_to_extent
ext4_clear_inode_state(inode, EXT4_STATE_MAY_INLINE_DATA);
ext4_da_write_end
ext4_run_li_request
ext4_mb_prefetch
ext4_read_block_bitmap_nowait
ext4_validate_block_bitmap
ext4_mark_group_bitmap_corrupted(sb, block_group, EXT4_GROUP_INFO_BBITMAP_CORRUPT)
percpu_counter_sub(&sbi->s_freeclusters_counter,grp->bb_free);
-> sbi->s_freeclusters_counter become zero
ext4_da_write_begin
if (ext4_nonda_switch(inode->i_sb)) -> As freeclusters_counter is zero will return true
*fsdata = (void *)FALL_BACK_TO_NONDELALLOC;
ext4_write_begin
ext4_da_write_end
if (write_mode == FALL_BACK_TO_NONDELALLOC)
ext4_write_end
if (inline_data)
ext4_write_inline_data_end
ext4_write_inline_data
BUG_ON(pos + len > EXT4_I(inode)->i_inline_size);
-> As inode is already convert to extent, so 'pos + len' > inline_size
-> then trigger BUG.
To solve this issue, instead of checking ext4_has_inline_data() which
is only cleared after data has been written back, check the
EXT4_STATE_MAY_INLINE_DATA flag in ext4_write_end().
Fixes: f19d5870cbf7 ("ext4: add normal write support for inline data")
Reported-by: syzbot+4faa160fa96bfba639f8@syzkaller.appspotmail.com
Reported-by: Jun Nie <jun.nie@linaro.org>
Signed-off-by: Ye Bin <yebin10@huawei.com>
Link: https://lore.kernel.org/r/20221206144134.1919987-1-yebin@huaweicloud.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
[ta: Fix conflict in if expression and use the local variable inline_data
as it is initialized with ext4_has_inline_data(inode) anyway.]
Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-04-05 11:16:46 +02:00
2022-06-22 14:11:02 +02:00
2023-02-06 07:52:36 +01:00
2022-12-08 11:23:03 +01:00
2019-10-25 00:03:11 -04:00
2021-01-06 14:48:39 +01:00
2023-04-05 11:16:46 +02:00
2020-11-05 11:43:36 +01:00
2023-02-22 12:50:33 +01:00
2023-04-05 11:16:45 +02:00
2023-03-11 16:43:56 +01:00
2023-01-18 11:41:09 +01:00
2019-11-23 21:44:49 -05:00
2021-09-12 08:56:38 +02:00
2023-01-18 11:40:56 +01:00
2022-02-01 17:24:34 +01:00
2022-10-26 13:22:14 +02:00
2021-05-26 12:05:19 +02:00
2020-12-02 08:49:53 +01:00
2022-08-25 11:17:36 +02:00
2019-11-10 11:56:05 -05:00
2022-08-25 11:17:28 +02:00
2023-04-05 11:16:46 +02:00
2023-03-11 16:44:08 +01:00
2022-06-14 18:11:30 +02:00
2021-09-22 12:26:25 +02:00
2022-12-08 11:23:01 +01:00
2023-03-11 16:43:49 +01:00
2023-03-11 16:43:59 +01:00
2023-03-11 16:43:59 +01:00
2021-04-14 08:24:14 +02:00
2023-01-18 11:41:38 +01:00
2022-06-14 18:11:36 +02:00
2021-11-12 14:43:03 +01:00
2022-10-26 13:22:17 +02:00
2023-03-22 13:28:07 +01:00
2023-03-11 16:44:07 +01:00
2022-11-03 23:56:54 +09:00
2021-09-22 12:26:34 +02:00
2022-04-15 14:18:35 +02:00
2023-04-05 11:16:45 +02:00
2020-12-30 11:51:22 +01:00
2023-03-11 16:43:58 +01:00
2023-04-05 11:16:41 +02:00
2022-06-14 18:11:34 +02:00
2022-11-25 17:42:22 +01:00
2023-04-05 11:16:42 +02:00
2023-01-18 11:41:39 +01:00
2023-01-18 11:41:43 +01:00
2023-02-22 12:50:28 +01:00
2023-01-18 11:41:40 +01:00
2021-09-30 10:09:26 +02:00
2023-01-18 11:42:02 +01:00
2020-10-29 09:57:53 +01:00
2023-02-06 07:52:43 +01:00
2020-08-26 10:40:51 +02:00
2023-02-22 12:50:39 +01:00
2021-03-07 12:20:48 +01:00
2023-01-18 11:40:58 +01:00
2022-09-20 12:28:00 +02:00
2023-03-11 16:44:10 +01:00
2023-03-11 16:44:01 +01:00
2020-08-21 13:05:37 +02:00
2023-04-05 11:16:42 +02:00
2023-02-22 12:50:38 +01:00
2023-02-22 12:50:35 +01:00
2022-08-25 11:17:21 +02:00
2023-01-18 11:41:46 +01:00
2023-01-18 11:41:46 +01:00
2021-10-06 15:42:35 +02:00
2023-01-18 11:41:46 +01:00
2023-01-18 11:41:33 +01:00
2021-05-22 11:38:29 +02:00
2022-11-25 17:42:22 +01:00
2023-01-18 11:41:25 +01:00
2022-06-22 14:11:03 +02:00
2020-12-11 13:23:30 +01:00
2020-10-29 09:57:45 +01:00
2022-06-14 18:11:41 +02:00
2020-10-01 13:17:19 +02:00
2021-04-14 08:24:11 +02:00
2020-01-12 12:21:37 +01:00
2020-02-11 04:35:37 -08:00
2022-12-08 11:23:05 +01:00
2022-06-06 08:33:50 +02:00
2021-09-15 09:47:28 +02:00
2022-05-25 09:14:34 +02:00
2023-03-17 08:32:47 +01:00
2020-04-17 10:50:21 +02:00
2022-02-08 18:24:29 +01:00
2022-06-14 18:11:44 +02:00
2022-10-15 07:54:36 +02:00
2021-07-31 08:19:37 +02:00
2022-10-26 13:22:59 +02:00
2019-12-17 19:55:30 +01:00
2019-09-18 16:59:14 -07:00
2023-01-18 11:40:55 +01:00
2020-03-25 08:25:41 +01:00
2019-09-18 16:59:14 -07:00
2023-01-18 11:41:59 +01:00
2020-01-17 19:48:21 +01:00
2022-11-25 17:42:22 +01:00
2021-08-26 08:36:22 -04:00
2020-03-18 07:17:51 +01:00
2021-08-12 13:21:02 +02:00
2023-01-18 11:41:44 +01:00
2021-03-17 17:03:33 +01:00
2020-02-11 04:35:23 -08:00
2021-04-21 12:56:16 +02:00
2022-01-29 10:25:11 +01:00
2021-07-20 16:10:54 +02:00
2022-09-05 10:27:47 +02:00
2022-10-17 17:24:32 +02:00
2022-04-27 13:50:48 +02:00
2019-10-03 14:21:35 -07:00
2022-02-23 11:59:55 +01:00
2022-10-26 13:22:21 +02:00
2020-02-11 04:35:12 -08:00
2023-01-18 11:40:53 +01:00
14b6ad56df