Dai Ngo 51e88e8922 nfsd: nfsd4_setclientid_confirm mistakenly expires confirmed client.
commit ab451ea952fe9d7afefae55ddb28943a148247fe upstream.

From RFC 7530 Section 16.34.5:

o  The server has not recorded an unconfirmed { v, x, c, *, * } and
   has recorded a confirmed { v, x, c, *, s }.  If the principals of
   the record and of SETCLIENTID_CONFIRM do not match, the server
   returns NFS4ERR_CLID_INUSE without removing any relevant leased
   client state, and without changing recorded callback and
   callback_ident values for client { x }.

The current code intends to do what the spec describes above but
it forgot to set 'old' to NULL resulting to the confirmed client
to be expired.

Fixes: 2b63482185e6 ("nfsd: fix clid_inuse on mount with security change")
Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Reviewed-by: Bruce Fields <bfields@fieldses.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-02-08 18:30:39 +01:00
..
2020-10-16 11:11:22 -07:00
2021-09-18 13:40:15 +02:00
2021-11-18 14:04:15 +01:00
2021-07-14 16:56:12 +02:00
2020-09-10 14:03:31 -07:00
2021-12-22 09:30:57 +01:00
2020-08-04 21:02:38 -04:00
2021-11-26 10:39:22 +01:00
2020-07-31 08:16:01 +02:00
2020-10-23 11:33:41 -07:00
2020-10-23 11:33:41 -07:00
2021-12-14 11:32:40 +01:00
2020-10-24 12:40:18 -07:00
2020-08-27 16:06:47 -04:00
2020-07-31 08:16:01 +02:00