Eric Dumazet
2416ca634e
net-caif: avoid user-triggerable WARN_ON(1) ...
commit 550ac9c1aaaaf51fd42e20d461f0b1cdbd55b3d2 upstream.
syszbot triggers this warning, which looks something
we can easily prevent.
If we initialize priv->list_field in chnl_net_init(),
then always use list_del_init(), we can remove robust_list_del()
completely.
WARNING: CPU: 0 PID: 3233 at net/caif/chnl_net.c:67 robust_list_del net/caif/chnl_net.c:67 [inline]
WARNING: CPU: 0 PID: 3233 at net/caif/chnl_net.c:67 chnl_net_uninit+0xc9/0x2e0 net/caif/chnl_net.c:375
Modules linked in:
CPU: 0 PID: 3233 Comm: syz-executor.3 Not tainted 5.14.0-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:robust_list_del net/caif/chnl_net.c:67 [inline]
RIP: 0010:chnl_net_uninit+0xc9/0x2e0 net/caif/chnl_net.c:375
Code: 89 eb e8 3a a3 ba f8 48 89 d8 48 c1 e8 03 42 80 3c 28 00 0f 85 bf 01 00 00 48 81 fb 00 14 4e 8d 48 8b 2b 75 d0 e8 17 a3 ba f8 <0f> 0b 5b 5d 41 5c 41 5d e9 0a a3 ba f8 4c 89 e3 e8 02 a3 ba f8 4c
RSP: 0018:ffffc90009067248 EFLAGS: 00010202
RAX: 0000000000008780 RBX: ffffffff8d4e1400 RCX: ffffc9000fd34000
RDX: 0000000000040000 RSI: ffffffff88bb6e49 RDI: 0000000000000003
RBP: ffff88802cd9ee08 R08: 0000000000000000 R09: ffffffff8d0e6647
R10: ffffffff88bb6dc2 R11: 0000000000000000 R12: ffff88803791ae08
R13: dffffc0000000000 R14: 00000000e600ffce R15: ffff888073ed3480
FS: 00007fed10fa0700(0000) GS:ffff8880b9d00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000001b2c322000 CR3: 00000000164a6000 CR4: 00000000001506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
register_netdevice+0xadf/0x1500 net/core/dev.c:10347
ipcaif_newlink+0x4c/0x260 net/caif/chnl_net.c:468
__rtnl_newlink+0x106d/0x1750 net/core/rtnetlink.c:3458
rtnl_newlink+0x64/0xa0 net/core/rtnetlink.c:3506
rtnetlink_rcv_msg+0x413/0xb80 net/core/rtnetlink.c:5572
netlink_rcv_skb+0x153/0x420 net/netlink/af_netlink.c:2504
netlink_unicast_kernel net/netlink/af_netlink.c:1314 [inline]
netlink_unicast+0x533/0x7d0 net/netlink/af_netlink.c:1340
netlink_sendmsg+0x86d/0xdb0 net/netlink/af_netlink.c:1929
sock_sendmsg_nosec net/socket.c:704 [inline]
sock_sendmsg+0xcf/0x120 net/socket.c:724
__sys_sendto+0x21c/0x320 net/socket.c:2036
__do_sys_sendto net/socket.c:2048 [inline]
__se_sys_sendto net/socket.c:2044 [inline]
__x64_sys_sendto+0xdd/0x1b0 net/socket.c:2044
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x44/0xae
Fixes: cc36a070b590 ("net-caif: add CAIF netdevice")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-09-22 11:43:09 +02:00
2020-01-29 10:24:22 +01:00
2020-11-10 10:23:54 +01:00
2021-08-04 11:58:02 +02:00
2020-01-12 11:24:27 +01:00
2021-04-07 12:05:39 +02:00
2020-10-01 20:40:12 +02:00
2020-07-31 16:44:06 +02:00
2021-06-30 08:49:13 -04:00
2021-09-22 11:43:07 +02:00
2021-08-26 08:37:22 -04:00
2021-09-22 11:43:09 +02:00
2021-08-08 08:38:54 +02:00
2020-11-10 10:23:59 +01:00
2021-09-22 11:43:06 +02:00
2021-01-23 15:38:18 +01:00
2021-08-26 08:37:27 -04:00
2021-07-28 09:14:27 +02:00
2018-07-22 14:27:39 +02:00
2020-04-13 10:32:53 +02:00
2020-01-12 11:24:19 +01:00
2021-05-22 10:40:20 +02:00
2021-08-26 08:37:22 -04:00
2021-09-22 11:43:06 +02:00
2021-07-28 09:14:26 +02:00
2017-05-25 15:44:41 +02:00
2018-09-15 09:43:01 +02:00
2020-12-11 13:37:56 +01:00
2019-04-17 08:36:44 +02:00
2021-02-23 13:59:14 +01:00
2021-01-09 13:35:49 +01:00
2021-02-10 09:09:25 +01:00
2021-08-04 11:58:03 +02:00
2021-08-26 08:37:25 -04:00
2021-04-16 11:59:10 +02:00
2021-03-17 16:10:13 +01:00
2021-01-12 19:49:01 +01:00
2021-08-04 11:58:03 +02:00
2021-09-22 11:43:08 +02:00
2021-09-22 11:43:04 +02:00
2021-07-28 09:14:27 +02:00
2021-06-16 11:36:32 +02:00
2021-05-22 10:40:19 +02:00
2021-06-30 08:49:20 -04:00
2019-03-23 13:19:44 +01:00
2021-03-30 14:41:42 +02:00
2021-09-03 09:44:40 +02:00
2020-01-12 11:24:23 +01:00
2020-12-11 13:37:56 +01:00
2021-01-23 15:38:19 +01:00
2021-09-22 11:42:56 +02:00
2021-08-04 11:58:02 +02:00
2018-04-29 11:32:02 +02:00
2021-09-22 11:43:07 +02:00
2016-10-19 10:58:04 -04:00
2021-08-04 11:58:03 +02:00
2021-08-04 11:58:01 +02:00
2021-05-22 10:40:28 +02:00
2021-08-04 11:58:03 +02:00
2021-06-30 08:49:12 -04:00
2021-07-20 16:21:07 +02:00
2021-06-30 08:49:12 -04:00
2021-08-04 11:58:01 +02:00
2020-08-21 11:02:04 +02:00
2416ca634e