201ed315f9
So that it's easier to follow and make sense of the branching and various conditions. Stats retrieval has been split into two separate functions ethtool_get_phy_stats_phydev & ethtool_get_phy_stats_ethtool. The former attempts to retrieve the stats using phydev & phy_ops, while the latter uses ethtool_ops. Actual n_stats validation & array allocation has been moved into a new ethtool_vzalloc_stats_array helper. This also fixes a potential NULL dereference of ops->get_ethtool_phy_stats where it was getting called in an else branch unconditionally without making sure it was actually present. Found by Linux Verification Center (linuxtesting.org) with the SVACE static analysis tool. Signed-off-by: Daniil Tatianin <d-tatianin@yandex-team.ru> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: David S. Miller <davem@davemloft.net> |
||
---|---|---|
.. | ||
bitset.c | ||
bitset.h | ||
cabletest.c | ||
channels.c | ||
coalesce.c | ||
common.c | ||
common.h | ||
debug.c | ||
eee.c | ||
eeprom.c | ||
features.c | ||
fec.c | ||
ioctl.c | ||
linkinfo.c | ||
linkmodes.c | ||
linkstate.c | ||
Makefile | ||
module.c | ||
netlink.c | ||
netlink.h | ||
pause.c | ||
phc_vclocks.c | ||
privflags.c | ||
pse-pd.c | ||
rings.c | ||
rss.c | ||
stats.c | ||
strset.c | ||
tsinfo.c | ||
tunnels.c | ||
wol.c |