iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/drivers/acpi
History
Vegard Nossum 25928deeb1 ACPICA: Always create namespace nodes using acpi_ns_create_node() 
ACPICA commit 29da9a2a3f5b2c60420893e5c6309a0586d7a329

ACPI is allocating an object using kmalloc(), but then frees it
using kmem_cache_free(<"Acpi-Namespace" kmem_cache>).

This is wrong and can lead to boot failures manifesting like this:

    hpet0: 3 comparators, 64-bit 100.000000 MHz counter
    clocksource: Switched to clocksource tsc-early
    BUG: unable to handle page fault for address: 000000003ffe0018
    #PF: supervisor read access in kernel mode
    #PF: error_code(0x0000) - not-present page
    PGD 0 P4D 0
    Oops: 0000 [#1] SMP PTI
    CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.6.0+ #211
    Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS
Ubuntu-1.8.2-1ubuntu1 04/01/2014
    RIP: 0010:kmem_cache_alloc+0x70/0x1d0
    Code: 00 00 4c 8b 45 00 65 49 8b 50 08 65 4c 03 05 6f cc e7 7e 4d 8b
20 4d 85 e4 0f 84 3d 01 00 00 8b 45 20 48 8b 7d 00 48 8d 4a 01 <49> 8b
   1c 04 4c 89 e0 65 48 0f c7 0f 0f 94 c0 84 c0 74 c5 8b 45 20
    RSP: 0000:ffffc90000013df8 EFLAGS: 00010206
    RAX: 0000000000000018 RBX: ffffffff81c49200 RCX: 0000000000000002
    RDX: 0000000000000001 RSI: 0000000000000dc0 RDI: 000000000002b300
    RBP: ffff88803e403d00 R08: ffff88803ec2b300 R09: 0000000000000001
    R10: 0000000000000dc0 R11: 0000000000000006 R12: 000000003ffe0000
    R13: ffffffff8110a583 R14: 0000000000000dc0 R15: ffffffff81c49a80
    FS:  0000000000000000(0000) GS:ffff88803ec00000(0000)
knlGS:0000000000000000
    CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
    CR2: 000000003ffe0018 CR3: 0000000001c0a001 CR4: 00000000003606f0
    DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
    DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
    Call Trace:
     __trace_define_field+0x33/0xa0
     event_trace_init+0xeb/0x2b4
     tracer_init_tracefs+0x60/0x195
     ? register_tracer+0x1e7/0x1e7
     do_one_initcall+0x74/0x160
     kernel_init_freeable+0x190/0x1f0
     ? rest_init+0x9a/0x9a
     kernel_init+0x5/0xf6
     ret_from_fork+0x35/0x40
    CR2: 000000003ffe0018
    ---[ end trace 707efa023f2ee960 ]---
    RIP: 0010:kmem_cache_alloc+0x70/0x1d0

Bisection leads to unrelated changes in slab; Vlastimil Babka
suggests an unrelated layout or slab merge change merely exposed
the underlying bug.

Link: https://lore.kernel.org/lkml/4dc93ff8-f86e-f4c9-ebeb-6d3153a78d03@oracle.com/
Link: https://lore.kernel.org/r/a1461e21-c744-767d-6dfc-6641fd3e3ce2@siemens.com
Link: https://github.com/acpica/acpica/commit/29da9a2a
Fixes: f79c8e4136ea ("ACPICA: Namespace: simplify creation of the initial/default namespace")
Reported-by: Jan Kiszka <jan.kiszka@siemens.com>
Diagnosed-by: Vlastimil Babka <vbabka@suse.cz>
Diagnosed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Erik Kaneda <erik.kaneda@intel.com>
Cc: 5.10+ <stable@vger.kernel.org> # 5.10+
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
2021-03-24 14:50:54 +01:00
..
acpica
ACPICA: Always create namespace nodes using acpi_ns_create_node()
2021-03-24 14:50:54 +01:00
apei
ACPI: APEI: ERST: remove unneeded semicolon
2021-02-05 13:50:51 +01:00
arm64
ACPI/IORT: Do not blindly trust DMA masks from firmware
2021-01-27 12:26:24 +00:00
dptf
ACPI: DPTF: Support Alder Lake
2020-11-10 18:52:51 +01:00
nfit
ACPI: NFIT: Fix flexible_array.cocci warnings
2021-01-11 12:56:49 -08:00
numa
ACPI updates for 5.10-rc1
2020-10-14 11:42:04 -07:00
pmic
ACPI / PMIC: Move TPS68470 OpRegion driver to drivers/acpi/pmic/
2020-09-15 19:40:59 +02:00
x86
ACPI: PM: s2idle: Drop unused local variables and related code
2021-01-07 17:41:28 +01:00
ac.c
ACPI: AC: Clean up printing messages
2021-02-04 19:45:45 +01:00
acpi_adxl.c
ACPI/ADXL: Add address translation interface using an ACPI DSM
2018-10-16 10:03:00 +02:00
acpi_amba.c
Merge 5.2-rc6 into char-misc-next
2019-06-23 09:23:33 +02:00
acpi_apd.c
ACPI: APD: Clean up header file include statements
2020-09-25 12:48:11 +02:00
acpi_cmos_rtc.c
ACPI: cmos_rtc: Remove leftover ACPI_MODULE_NAME()
2020-09-25 18:25:51 +02:00
acpi_configfs.c
ACPI: configfs: add missing check after configfs_register_default_group()
2021-01-22 16:35:34 +01:00
acpi_dbg.c
ACPI: debug: Remove the not used function
2020-11-17 18:12:34 +01:00
acpi_extlog.c
ACPI / extlog: Check for RDMSR failure
2020-10-02 19:01:55 +02:00
acpi_fpdt.c
ACPI: tables: introduce support for FPDT table
2021-01-29 19:24:13 +01:00
acpi_ipmi.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157
2019-05-30 11:26:37 -07:00
acpi_lpat.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174
2019-05-30 11:26:41 -07:00
acpi_lpit.c
ACPI: LPIT: Put the low power idle table after using it
2020-05-09 11:29:16 +02:00
acpi_lpss.c
drm next for 5.10-rc1
2020-10-15 10:46:16 -07:00
acpi_memhotplug.c
mm/memory_hotplug: prepare passing flags to add_memory() and friends
2020-10-16 11:11:18 -07:00
acpi_pad.c
ACPI: Use DEVICE_ATTR_<RW|RO|WO> macros
2021-01-22 16:17:19 +01:00
acpi_platform.c
ACPI: platform: Remove ACPI_MODULE_NAME()
2020-09-25 18:25:51 +02:00
acpi_pnp.c
ACPI: PNP: compare the string length in the matching_id()
2020-12-15 19:30:49 +01:00
acpi_processor.c
ACPI: processor: remove comment regarding string _UID support
2020-10-16 18:11:27 +02:00
acpi_tad.c
ACPI: Use DEVICE_ATTR_<RW|RO|WO> macros
2021-01-22 16:17:19 +01:00
acpi_video.c
ACPI: video: Clean up printing messages
2021-02-04 19:45:46 +01:00
acpi_watchdog.c
ACPI: watchdog: Replace open coded variant of resource_union()
2020-11-17 18:06:29 +01:00
battery.c
ACPI: battery: Clean up printing messages
2021-02-04 19:45:45 +01:00
bgrt.c
ACPI: Use DEVICE_ATTR_<RW|RO|WO> macros
2021-01-22 16:17:19 +01:00
blacklist.c
ACPI: blacklist: fix clang warning for unused DMI table
2019-07-11 22:45:00 +02:00
bus.c
ACPI updates for 5.12-rc1
2021-02-20 21:50:59 -08:00
button.c
ACPI: button: Clean up printing messages
2021-02-04 19:45:46 +01:00
container.c
ACPI: container: Remove leftover ACPICA debug functionality
2020-09-25 18:25:51 +02:00
cppc_acpi.c
ACPI: CPPC: initialise vaddr pointers to NULL
2021-01-22 16:28:19 +01:00
custom_method.c
ACPI: custom_method: Remove dead ACPICA debug code
2020-09-25 18:25:51 +02:00
debugfs.c
ACPI: debugfs: Remove dead ACPICA debug code
2020-09-25 18:25:51 +02:00
device_pm.c
ACPI: PM: Clean up printing messages
2021-02-04 19:11:43 +01:00
device_sysfs.c
Merge branches 'acpi-misc', 'acpi-cppc', 'acpi-docs', 'acpi-config' and 'acpi-apei'
2021-02-15 17:04:40 +01:00
dock.c
ACPI: Use DEVICE_ATTR_<RW|RO|WO> macros
2021-01-22 16:17:19 +01:00
ec_sys.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 482
2019-06-19 17:09:52 +02:00
ec.c
ACPI: EC: Clean up status flags checks in advance_transaction()
2020-11-23 20:01:01 +01:00
event.c
ACPI: Fix whitespace inconsistencies
2020-11-09 19:08:06 +01:00
evged.c
ACPI: GED: fix -Wformat
2020-11-09 19:25:20 +01:00
fan.c
ACPI: fan: Initialize performance state sysfs attribute
2020-11-16 15:18:38 +01:00
glue.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 428
2019-06-05 17:37:16 +02:00
hed.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174
2019-05-30 11:26:41 -07:00
internal.h
ACPI: scan: Harden acpi_device_add() against device ID overflows
2021-01-11 20:45:31 +01:00
ioapic.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
irq.c
Merge branch 'irq-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2019-07-08 11:01:13 -07:00
Kconfig
Merge branch 'acpi-tables'
2021-02-25 18:57:40 +01:00
Makefile
Merge branch 'acpi-tables'
2021-02-25 18:57:40 +01:00
nvs.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 428
2019-06-05 17:37:16 +02:00
osi.c
ACPI: OSI: Shoot duplicate word
2019-11-13 11:12:08 +01:00
osl.c
ACPI: OSL: Clean up printing messages
2021-02-10 19:09:43 +01:00
pci_irq.c
ACPI: Fix whitespace inconsistencies
2020-11-09 19:08:06 +01:00
pci_link.c
ACPI: Fix whitespace inconsistencies
2020-11-09 19:08:06 +01:00
pci_mcfg.c
ACPI: Fix whitespace inconsistencies
2020-11-09 19:08:06 +01:00
pci_root.c
PCI/ACPI: Clarify message about _OSC failure
2021-01-27 09:38:36 -06:00
pci_slot.c
ACPI: PCI: Remove unused ACPICA debug code
2020-09-25 18:25:51 +02:00
platform_profile.c
ACPI: platform: Add balanced-performance platform profile
2021-02-24 14:52:41 +01:00
power.c
Merge branch 'acpi-messages'
2021-02-15 17:04:53 +01:00
pptt.c
ACPI: PPTT: Consistently use unsigned int as parameter type
2020-01-07 11:46:36 +01:00
proc.c
ACPI: proc: Remove dead ACPICA debug code
2020-09-25 18:25:51 +02:00
processor_core.c
ACPI: processor: Remove dead ACPICA debug code
2020-09-25 18:25:51 +02:00
processor_driver.c
cpufreq: Use per-policy frequency QoS
2019-10-21 02:05:21 +02:00
processor_idle.c
ACPI: processor: Remove the duplicated ACPI_PROCESSOR_CLASS macro
2020-11-17 18:12:34 +01:00
processor_pdc.c
…
processor_perflib.c
More power management updates for 5.11-rc1
2020-12-22 14:12:10 -08:00
processor_thermal.c
ACPI: processor: Remove the duplicated ACPI_PROCESSOR_CLASS macro
2020-11-17 18:12:34 +01:00
processor_throttling.c
ACPI: processor: Remove the duplicated ACPI_PROCESSOR_CLASS macro
2020-11-17 18:12:34 +01:00
property.c
ACPI: property: Satisfy kernel doc validator (part 2)
2021-02-12 15:34:14 +01:00
reboot.c
ACPI: reboot: Avoid racing after writing to ACPI RESET_REG
2020-10-16 18:04:52 +02:00
resource.c
ACPI updates for 5.11-rc1
2020-12-15 16:39:06 -08:00
sbs.c
ACPI: SBS: Simplify the code using module_acpi_driver()
2020-11-17 18:12:34 +01:00
sbshc.c
ACPI: Fix whitespace inconsistencies
2020-11-09 19:08:06 +01:00
sbshc.h
ACPI: Fix whitespace inconsistencies
2020-11-09 19:08:06 +01:00
scan.c
Merge branch 'acpi-messages'
2021-02-15 17:04:53 +01:00
sleep.c
ACPI: PM: s2idle: Move x86-specific code to the x86 directory
2020-12-17 20:30:02 +01:00
sleep.h
ACPI: PM: s2idle: Move x86-specific code to the x86 directory
2020-12-17 20:30:02 +01:00
spcr.c
ACPI: Use fallthrough pseudo-keyword
2020-07-09 14:09:28 +02:00
sysfs.c
ACPI: thermal: Clean up printing messages
2021-02-04 19:45:46 +01:00
tables.c
ACPI: tables: Remove the duplicated checks for acpi_parse_entries_array()
2020-07-27 15:19:12 +02:00
thermal.c
- Use the newly introduced 'hot' and 'critical' ops for the acpi
2021-02-22 09:39:11 -08:00
tiny-power-button.c
ACPI: tiny-power-button: Simplify the code using module_acpi_driver()
2020-11-17 18:12:34 +01:00
utils.c
media updates for v5.12-rc1
2021-02-21 14:10:36 -08:00
video_detect.c
ACPI: video: Add DMI quirk for GIGABYTE GB-BXBT-2807
2020-12-07 14:01:22 +01:00
wakeup.c
ACPI: Fix whitespace inconsistencies
2020-11-09 19:08:06 +01:00