afea229fe1
- Make drm_buddy_alloc a single function to handle
range allocation and non-range allocation demands
- Implemented a new function alloc_range() which allocates
the requested power-of-two block comply with range limitations
- Moved order computation and memory alignment logic from
i915 driver to drm buddy
v2:
merged below changes to keep the build unbroken
- drm_buddy_alloc_range() becomes obsolete and may be removed
- enable ttm range allocation (fpfn / lpfn) support in i915 driver
- apply enhanced drm_buddy_alloc() function to i915 driver
v3(Matthew Auld):
- Fix alignment issues and remove unnecessary list_empty check
- add more validation checks for input arguments
- make alloc_range() block allocations as bottom-up
- optimize order computation logic
- replace uint64_t with u64, which is preferred in the kernel
v4(Matthew Auld):
- keep drm_buddy_alloc_range() function implementation for generic
actual range allocations
- keep alloc_range() implementation for end bias allocations
v5(Matthew Auld):
- modify drm_buddy_alloc() passing argument place->lpfn to lpfn
as place->lpfn will currently always be zero for i915
v6(Matthew Auld):
- fixup potential uaf - If we are unlucky and can't allocate
enough memory when splitting blocks, where we temporarily
end up with the given block and its buddy on the respective
free list, then we need to ensure we delete both blocks,
and no just the buddy, before potentially freeing them
- fix warnings reported by kernel test robot <lkp@intel.com>
v7(Matthew Auld):
- revert fixup potential uaf
- keep __alloc_range() add node to the list logic same as
drm_buddy_alloc_blocks() by having a temporary list variable
- at drm_buddy_alloc_blocks() keep i915 range_overflows macro
and add a new check for end variable
v8:
- fix warnings reported by kernel test robot <lkp@intel.com>
v9(Matthew Auld):
- remove DRM_BUDDY_RANGE_ALLOCATION flag
- remove unnecessary function description
v10:
- keep DRM_BUDDY_RANGE_ALLOCATION flag as removing the flag
and replacing with (end < size) logic fails amdgpu driver load
Signed-off-by: Arunpravin <Arunpravin.PaneerSelvam@amd.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Signed-off-by: Christian König <christian.koenig@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220221164552.2434-1-Arunpravin.PaneerSelvam@amd.com
59 lines
1.4 KiB
C
59 lines
1.4 KiB
C
/* SPDX-License-Identifier: MIT */
|
|
/*
|
|
* Copyright © 2021 Intel Corporation
|
|
*/
|
|
|
|
#ifndef __I915_TTM_BUDDY_MANAGER_H__
|
|
#define __I915_TTM_BUDDY_MANAGER_H__
|
|
|
|
#include <linux/list.h>
|
|
#include <linux/types.h>
|
|
|
|
#include <drm/ttm/ttm_resource.h>
|
|
|
|
struct ttm_device;
|
|
struct ttm_resource_manager;
|
|
struct drm_buddy;
|
|
|
|
/**
|
|
* struct i915_ttm_buddy_resource
|
|
*
|
|
* @base: struct ttm_resource base class we extend
|
|
* @blocks: the list of struct i915_buddy_block for this resource/allocation
|
|
* @flags: DRM_BUDDY_*_ALLOCATION flags
|
|
* @mm: the struct i915_buddy_mm for this resource
|
|
*
|
|
* Extends the struct ttm_resource to manage an address space allocation with
|
|
* one or more struct i915_buddy_block.
|
|
*/
|
|
struct i915_ttm_buddy_resource {
|
|
struct ttm_resource base;
|
|
struct list_head blocks;
|
|
unsigned long flags;
|
|
struct drm_buddy *mm;
|
|
};
|
|
|
|
/**
|
|
* to_ttm_buddy_resource
|
|
*
|
|
* @res: the resource to upcast
|
|
*
|
|
* Upcast the struct ttm_resource object into a struct i915_ttm_buddy_resource.
|
|
*/
|
|
static inline struct i915_ttm_buddy_resource *
|
|
to_ttm_buddy_resource(struct ttm_resource *res)
|
|
{
|
|
return container_of(res, struct i915_ttm_buddy_resource, base);
|
|
}
|
|
|
|
int i915_ttm_buddy_man_init(struct ttm_device *bdev,
|
|
unsigned type, bool use_tt,
|
|
u64 size, u64 default_page_size, u64 chunk_size);
|
|
int i915_ttm_buddy_man_fini(struct ttm_device *bdev,
|
|
unsigned int type);
|
|
|
|
int i915_ttm_buddy_man_reserve(struct ttm_resource_manager *man,
|
|
u64 start, u64 size);
|
|
|
|
#endif
|