2691d0ae66
The braces of the unlikely() macro inside the if condition only cover
the subtraction part, not the whole statement. This causes the result of
the subtraction to be converted to zero or one. While that still works
in this context, it causes static analysis tools to complain (and is
just plain wrong).
Fix the bracket placement and, while at it, simplify the if-condition.
Also add a comment to the if-condition explaining what we expect the
result to be and what happens on the failure path, as it seems to have
caused a bit of confusion.
This commit should not cause any difference in behavior or generated
code.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes:
|
||
|---|---|---|
| .. | ||
| chrome | ||
| goldfish | ||
| mellanox | ||
| mips | ||
| olpc | ||
| surface | ||
| x86 | ||
| Kconfig | ||
| Makefile | ||