Miaohe Lin
2799e77529
swap: fix do_swap_page() race with swapoff ...
When I was investigating the swap code, I found the below possible race
window:
CPU 1 CPU 2
----- -----
do_swap_page
if (data_race(si->flags & SWP_SYNCHRONOUS_IO)
swap_readpage
if (data_race(sis->flags & SWP_FS_OPS)) {
swapoff
..
p->swap_file = NULL;
..
struct file *swap_file = sis->swap_file;
struct address_space *mapping = swap_file->f_mapping;[oops!]
Note that for the pages that are swapped in through swap cache, this isn't
an issue. Because the page is locked, and the swap entry will be marked
with SWAP_HAS_CACHE, so swapoff() can not proceed until the page has been
unlocked.
Fix this race by using get/put_swap_device() to guard against concurrent
swapoff.
Link: https://lkml.kernel.org/r/20210426123316.806267-3-linmiaohe@huawei.com
Fixes: 0bcac06f27d7 ("mm,swap: skip swapcache for swapin of synchronous device")
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: "Huang, Ying" <ying.huang@intel.com>
Cc: Alex Shi <alexs@kernel.org>
Cc: David Hildenbrand <david@redhat.com>
Cc: Dennis Zhou <dennis@kernel.org>
Cc: Hugh Dickins <hughd@google.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Minchan Kim <minchan@kernel.org>
Cc: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Wei Yang <richard.weiyang@gmail.com>
Cc: Yang Shi <shy828301@gmail.com>
Cc: Yu Zhao <yuzhao@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2021-06-29 10:53:49 -07:00
2021-04-26 16:32:11 -07:00
2021-06-04 07:37:49 -07:00
2021-03-30 11:14:45 +02:00
2021-06-24 21:03:17 +02:00
2021-03-24 14:01:58 +01:00
2021-02-09 12:26:40 +01:00
2021-02-01 11:29:11 +05:30
2021-04-27 14:10:15 -07:00
2021-04-30 13:04:30 -07:00
2021-04-06 15:33:32 -05:00
2021-05-05 12:39:29 -07:00
2021-02-02 00:16:57 +01:00
2021-04-07 08:36:38 +01:00
2021-04-26 12:30:36 -07:00
2021-06-08 09:41:16 -07:00
2021-06-03 14:19:53 -03:00
2021-06-16 15:36:47 -07:00
2021-04-23 09:29:49 +02:00
2021-04-16 20:30:54 +02:00
2021-04-26 18:16:56 +02:00
2021-05-03 23:04:01 +02:00
2021-04-26 03:20:07 +02:00
2021-04-26 18:16:56 +02:00
2021-04-26 18:16:56 +02:00
2021-03-15 12:53:12 -07:00
2021-03-17 12:13:19 +05:30
2021-04-22 02:03:01 +02:00
2021-05-18 10:11:06 +03:00
2021-03-21 21:29:26 +01:00
2021-04-08 13:26:22 -07:00
2021-04-23 13:18:35 +01:00
2021-01-23 14:57:21 +01:00
2021-06-29 10:53:48 -07:00
2021-03-29 22:49:54 -05:00
2021-04-06 10:22:02 +05:30
2021-05-18 17:24:52 +01:00
2021-02-08 13:23:42 +02:00
2021-05-26 06:36:13 -04:00
2021-05-19 15:24:52 +02:00
2021-06-04 13:24:16 +02:00
2021-04-26 17:04:27 +02:00
2021-05-06 19:24:11 -07:00
2021-04-07 11:14:55 +02:00
2021-06-14 15:55:02 +02:00
2021-04-07 16:33:20 +01:00
2021-04-09 14:54:23 -07:00
2021-04-14 16:30:30 +03:00
2021-05-07 00:26:33 -07:00
2021-03-08 15:16:30 -08:00
2021-06-29 10:53:48 -07:00
2021-03-08 10:21:11 -05:00
2021-05-08 21:49:48 -06:00
2021-05-07 00:34:51 -07:00
2021-05-06 19:24:12 -07:00
2021-05-22 15:09:07 -10:00
2021-02-08 08:33:16 -07:00
2021-04-21 22:59:17 -04:00
2021-05-15 08:52:30 -07:00
2021-02-23 09:54:51 -07:00
2021-03-17 16:34:11 +01:00
2021-02-26 11:51:48 -08:00
2021-02-26 11:51:47 -08:00
2021-02-26 12:28:03 -08:00
2021-05-03 11:56:23 +02:00
2021-04-03 01:43:49 +02:00
2021-04-29 11:57:23 -07:00
2021-02-16 15:23:23 -08:00
2021-03-26 20:41:51 -07:00
2021-05-05 11:27:24 -07:00
2021-04-15 17:04:24 +01:00
2021-01-14 19:29:58 -08:00
2021-01-24 14:27:17 +01:00
2021-02-26 09:41:03 -08:00
2021-04-08 16:04:20 -07:00
2021-04-04 13:34:46 -04:00
2021-05-24 12:45:26 -04:00
2021-05-24 12:45:26 -04:00
2021-04-07 11:05:44 -07:00
2021-02-22 09:45:23 -08:00
2021-04-07 16:33:20 +01:00
2021-05-01 10:14:08 -07:00
2021-05-05 11:27:24 -07:00
2021-05-05 11:27:24 -07:00
2021-05-21 06:12:52 -10:00
2021-05-12 20:18:46 +02:00
2021-04-08 16:04:20 -07:00
2021-04-08 16:04:20 -07:00
2021-04-30 11:20:35 -07:00
2021-04-25 05:26:10 +09:00
2021-01-22 11:08:56 +01:00
2021-05-07 00:26:34 -07:00
2021-01-21 14:06:00 -07:00
2021-05-13 11:00:18 -07:00
2021-05-22 15:09:07 -10:00
2021-05-05 22:54:12 +02:00
2021-03-08 10:21:11 -05:00
2021-02-11 18:31:48 +01:00
2021-04-06 16:05:38 -06:00
2021-03-10 09:16:09 +01:00
2021-02-04 19:25:47 +01:00
2021-05-04 11:24:46 -07:00
2021-04-07 19:26:44 +02:00
2021-04-29 11:41:43 -07:00
2021-05-06 19:24:12 -07:00
2021-05-06 19:24:11 -07:00
2021-01-22 14:58:01 +11:00
2021-04-15 22:36:45 -04:00
2021-06-22 13:56:43 +02:00
2021-04-16 17:06:34 +02:00
2021-05-07 00:26:32 -07:00
2021-03-09 15:40:16 +09:00
2021-04-19 13:13:26 -04:00
2021-05-21 22:12:09 +02:00
2021-04-22 08:20:15 +02:00
2021-01-18 14:26:51 +01:00
2021-04-08 12:21:13 +02:00
2021-02-25 18:28:24 +05:30
2021-04-07 10:30:47 +02:00
2021-03-15 10:02:31 +01:00
2021-04-02 16:41:08 +02:00
2021-02-04 14:42:00 +01:00
2021-05-13 20:50:23 +02:00
2021-01-20 18:52:12 +01:00
2021-03-19 07:44:28 +01:00
2021-05-11 08:12:14 -06:00
2021-04-25 05:25:42 +09:00
2021-03-22 03:57:39 +01:00
2021-05-31 10:14:49 +02:00
2021-03-14 14:48:02 -07:00
2021-04-16 16:59:20 -07:00
2021-02-16 09:59:41 +01:00
2021-02-08 12:28:07 +01:00
2021-01-30 11:47:12 -05:00
2021-03-15 11:09:38 +09:00
2021-03-12 13:16:42 -08:00
2021-05-25 12:21:14 +02:00
2021-06-01 17:38:40 +02:00
2021-04-16 00:13:04 -04:00
2021-04-12 15:04:23 +02:00
2021-03-30 22:37:06 +02:00
2021-01-16 18:14:53 +00:00
2021-02-26 09:41:04 -08:00
2021-04-08 19:12:20 +02:00
2021-06-29 10:53:48 -07:00
2021-04-23 10:14:32 +01:00
2021-04-23 10:14:32 +01:00
2021-03-16 16:49:31 +01:00
2021-02-07 14:51:11 -08:00
2021-03-23 14:08:18 -04:00
2021-05-10 16:22:27 +02:00
2021-05-20 07:59:35 -06:00
2021-05-07 00:26:34 -07:00
2021-05-07 00:26:34 -07:00
2021-05-07 00:26:33 -07:00
2021-03-17 16:34:08 +01:00
2021-02-23 19:26:43 +01:00
2021-03-11 20:47:09 +00:00
2021-03-11 20:47:09 +00:00
2021-05-05 15:52:34 +02:00
2021-02-24 13:38:32 -08:00
2021-05-05 11:27:27 -07:00
2021-05-17 12:31:05 +02:00
2021-06-16 09:24:42 -07:00
2021-03-25 09:22:55 -07:00
2021-06-24 19:40:54 -07:00
2021-04-28 17:22:10 -07:00
2021-04-10 21:59:21 +02:00
2021-02-23 11:29:52 -08:00
2021-04-19 12:50:15 +02:00
2021-03-23 14:49:05 -07:00
2021-02-11 13:24:44 -08:00
2021-03-10 15:20:24 -08:00
2021-03-15 20:41:58 -07:00
2021-02-23 13:39:45 -08:00
2021-02-16 13:14:06 -08:00
2021-05-06 19:24:11 -07:00
2021-05-24 15:24:33 -07:00
2021-05-07 00:26:33 -07:00
2021-04-08 19:09:02 +02:00
2021-04-07 11:55:47 +02:00
2021-04-07 10:15:19 +02:00
2021-03-17 16:34:07 +01:00
2021-04-11 19:30:41 -06:00
2021-04-30 11:20:39 -07:00
2021-04-07 10:56:53 +02:00
2021-04-30 11:20:40 -07:00
2021-06-29 10:53:48 -07:00
2021-04-16 17:20:45 +02:00
2021-04-26 15:03:23 -07:00
2021-04-07 10:30:47 +02:00
2021-02-23 11:29:52 -08:00
2021-04-26 10:25:03 -07:00
2021-03-22 04:23:14 +01:00
2021-05-05 12:39:29 -07:00
2021-01-22 11:08:56 +01:00
2021-01-26 07:42:27 +01:00
2021-04-05 22:39:38 -04:00
2021-04-08 14:05:19 +02:00
2021-02-08 12:24:04 +01:00
2021-02-24 13:38:31 -08:00
2021-04-30 11:20:41 -07:00
2021-05-09 00:29:45 +09:00
2021-03-06 12:40:21 +01:00
2021-03-08 14:27:43 -08:00
2021-03-08 14:27:43 -08:00
2021-06-29 10:53:47 -07:00
2021-03-08 12:06:29 -07:00
2021-01-21 16:16:10 +00:00
2021-02-22 10:22:54 -08:00
2021-02-26 09:41:02 -08:00
2021-02-26 09:41:05 -08:00
2021-02-26 09:40:59 -08:00
2021-03-08 11:43:35 +01:00
2021-01-29 15:39:48 -05:00
2021-02-26 09:41:03 -08:00
2021-06-29 10:53:45 -07:00
2021-06-09 01:49:13 -04:00
2021-02-19 11:54:08 +01:00
2021-02-19 11:54:08 +01:00
2021-02-19 11:35:28 +01:00
2021-05-12 12:37:14 -07:00
2021-04-13 09:16:12 -06:00
2021-04-08 16:04:22 -07:00
2021-04-28 12:37:53 -07:00
2021-05-01 18:50:44 -07:00
2021-05-01 18:50:44 -07:00
2021-04-20 16:27:54 -07:00
2021-04-12 10:36:00 -06:00
2021-04-27 14:13:24 -07:00
2021-01-19 11:47:31 -08:00
2021-02-09 09:30:16 +01:00
2021-03-25 09:22:55 -07:00
2021-05-05 11:27:23 -07:00
2021-05-05 11:27:26 -07:00
2021-05-05 11:27:26 -07:00
2021-05-05 11:27:26 -07:00
2021-04-09 18:48:22 +05:30
2021-05-05 11:27:26 -07:00
2021-05-22 15:09:07 -10:00
2021-04-04 18:29:37 -04:00
2021-02-24 13:38:33 -08:00
2021-06-29 10:53:48 -07:00
2021-06-29 10:53:48 -07:00
2021-03-25 09:22:55 -07:00
2021-05-07 00:26:33 -07:00
2021-02-24 10:25:37 -08:00
2021-04-08 16:04:20 -07:00
2021-02-27 08:07:12 -08:00
2021-04-09 14:54:23 -07:00
2021-04-20 14:11:22 +01:00
2021-03-29 15:56:48 +02:00
2021-04-08 22:18:36 -07:00
2021-02-23 20:32:11 -07:00
2021-02-11 13:24:44 -08:00
2021-04-07 14:43:28 -07:00
2021-01-25 22:06:11 +01:00
2021-04-23 10:14:32 +01:00
2021-04-19 15:41:28 -07:00
2021-04-13 10:04:05 -04:00
2021-05-07 11:23:41 -07:00
2021-04-13 09:41:16 -04:00
2021-04-13 10:04:05 -04:00
2021-03-22 10:19:00 -04:00
2021-04-06 08:34:39 +02:00
2021-04-02 16:26:33 +02:00
2021-01-26 11:12:00 -06:00
2021-02-12 19:23:57 -06:00
2021-02-11 08:33:41 +01:00
2021-02-17 13:17:49 -08:00
2021-04-13 14:35:02 -07:00
2021-04-21 10:24:41 -05:00
2021-04-26 08:51:23 -07:00
2021-04-01 14:07:41 -07:00
2021-02-24 13:38:29 -08:00
2021-06-29 10:53:47 -07:00
2021-04-30 11:20:42 -07:00
2021-02-26 09:41:01 -08:00
2021-06-29 10:53:48 -07:00
2021-02-26 09:40:59 -08:00
2021-04-30 11:20:41 -07:00
2021-03-10 12:46:04 +00:00
2021-02-03 19:05:50 +01:00
2021-03-12 16:08:59 -06:00
2021-04-16 11:34:17 -05:00
2021-02-23 14:11:13 -06:00
2021-02-23 14:12:01 -06:00
2021-05-25 18:37:37 -05:00
2021-05-01 10:14:08 -07:00
2021-06-05 08:58:11 -07:00
2021-05-26 13:15:55 -07:00
2021-03-15 12:53:12 -07:00
2021-04-02 17:02:31 +02:00
2021-02-24 14:52:41 +01:00
2021-01-22 17:08:28 +01:00
2021-03-16 10:14:11 +05:30
2021-04-08 19:14:46 +02:00
2021-05-10 19:14:01 +02:00
2021-01-27 17:44:18 -08:00
2021-01-24 14:27:17 +01:00
2021-01-24 14:27:20 +01:00
2021-04-28 15:43:58 -07:00
2021-03-24 12:48:38 -07:00
2021-03-17 16:34:08 +01:00
2021-05-06 19:24:11 -07:00
2021-05-06 19:24:11 -07:00
2021-04-05 13:18:22 +02:00
2021-03-06 12:40:22 +01:00
2021-03-06 12:40:22 +01:00
2021-04-21 12:20:04 -04:00
2021-06-15 10:59:46 -07:00
2021-04-07 16:33:07 +01:00
2021-03-12 17:09:34 -08:00
2021-02-26 09:41:03 -08:00
2021-04-09 14:17:03 +02:00
2021-04-12 14:49:31 +02:00
2021-05-11 09:56:11 +02:00
2021-02-17 14:07:44 +01:00
2021-03-15 13:54:54 -07:00
2021-03-08 14:17:35 -08:00
2021-04-28 12:00:13 -07:00
2021-03-24 17:16:15 -07:00
2021-03-22 08:23:48 -07:00
2021-03-31 13:53:38 +01:00
2021-03-18 08:00:51 -05:00
2021-05-05 13:24:11 -07:00
2021-03-16 22:13:11 +01:00
2021-04-01 14:18:32 -04:00
2021-06-16 09:24:42 -07:00
2021-03-17 14:16:15 -05:00
2021-01-16 23:19:26 +01:00
2021-03-29 15:57:03 +02:00
2021-06-09 19:10:22 +02:00
2021-02-04 05:27:42 -05:00
2021-03-22 02:45:52 +01:00
2021-03-18 22:39:30 -04:00
2021-06-27 13:32:54 -07:00
2021-03-30 16:35:16 +01:00
2021-05-01 18:50:44 -07:00
2021-03-18 12:58:27 -04:00
2021-04-27 15:50:15 -07:00
2021-03-10 09:51:45 +01:00
2021-04-22 12:04:26 +02:00
2021-03-10 09:34:10 +01:00
2021-04-11 16:34:56 -07:00
2021-05-05 11:27:23 -07:00
2021-06-27 13:32:54 -07:00
2021-04-01 10:56:13 -07:00
2021-04-25 18:02:32 -07:00
2021-02-26 09:41:02 -08:00
2021-06-29 10:53:46 -07:00
2021-02-26 09:41:02 -08:00
2021-05-09 13:07:03 -07:00
2021-06-12 13:13:08 -07:00
2021-01-18 21:39:28 +01:00
2021-02-26 09:41:04 -08:00
2021-03-10 15:52:31 +01:00
2021-04-19 16:03:15 +02:00
2021-03-11 16:04:39 +01:00
2021-04-28 12:37:53 -07:00
2021-04-22 15:02:40 -07:00
2021-03-13 11:27:30 -08:00
2021-02-26 09:41:04 -08:00
2021-01-15 13:23:36 +00:00
2021-06-29 10:53:49 -07:00
2021-06-16 09:24:42 -07:00
2021-03-19 04:58:25 +00:00
2021-05-01 18:50:44 -07:00
2021-03-25 17:39:33 -07:00
2021-04-11 19:30:25 -06:00
2021-01-22 18:20:52 -08:00
2021-02-02 14:50:15 +01:00
2021-03-01 15:25:24 -08:00
2021-04-22 13:14:09 +02:00
2021-03-16 22:13:10 +01:00
2021-03-18 18:25:31 +03:00
2021-05-31 10:14:49 +02:00
2021-04-16 21:03:50 +02:00
2021-04-07 16:33:20 +01:00
2021-03-22 23:06:48 +01:00
2021-01-27 17:26:42 +01:00
2021-04-14 16:30:30 +03:00
2021-04-01 14:18:32 -04:00
2021-02-02 17:02:05 -05:00
2021-03-23 14:08:18 -04:00
2021-04-10 10:36:34 +02:00
2021-03-10 09:34:06 +01:00
2021-04-15 10:32:17 +02:00
2021-02-13 17:17:53 +01:00
2021-03-10 09:51:45 +01:00
2021-04-03 21:22:18 +11:00
2021-03-30 17:06:49 -07:00
2021-04-26 22:55:12 +01:00
2021-02-15 18:50:01 +01:00
2021-03-17 21:30:15 +01:00
2021-04-09 16:00:00 +02:00
2021-04-29 11:06:13 -07:00
2021-05-05 11:27:22 -07:00
2021-03-19 22:23:19 +01:00
2021-05-03 04:55:53 -04:00
2021-01-21 16:16:10 +00:00
2021-04-06 11:55:11 -06:00
2021-03-22 15:02:14 +01:00
2021-04-06 16:17:57 -07:00
2021-05-04 04:19:59 -04:00
2021-03-14 04:37:35 -04:00
2021-05-05 11:27:25 -07:00
2021-06-24 19:40:53 -07:00
2021-02-09 12:15:07 +01:00
2021-04-30 11:20:37 -07:00
2021-01-26 19:18:50 +01:00
2021-05-03 04:55:53 -04:00
2021-05-05 22:54:11 +02:00
2021-01-21 14:06:00 -07:00
2021-03-08 11:33:39 +01:00
2021-01-19 10:20:07 -05:00
2021-06-29 10:53:48 -07:00
2021-03-19 12:13:10 +01:00
2021-04-16 15:31:02 -07:00
2021-03-30 13:42:33 -04:00
2021-01-24 14:27:17 +01:00
2021-02-26 09:41:01 -08:00
2021-02-26 09:41:01 -08:00
2021-02-08 22:58:55 +01:00
2799e77529