Jeff Layton 27c934dd88 nfsd: don't replace page in rq_pages if it's a continuation of last page
The splice read calls nfsd_splice_actor to put the pages containing file
data into the svc_rqst->rq_pages array. It's possible however to get a
splice result that only has a partial page at the end, if (e.g.) the
filesystem hands back a short read that doesn't cover the whole page.

nfsd_splice_actor will plop the partial page into its rq_pages array and
return. Then later, when nfsd_splice_actor is called again, the
remainder of the page may end up being filled out. At this point,
nfsd_splice_actor will put the page into the array _again_ corrupting
the reply. If this is done enough times, rq_next_page will overrun the
array and corrupt the trailing fields -- the rq_respages and
rq_next_page pointers themselves.

If we've already added the page to the array in the last pass, don't add
it to the array a second time when dealing with a splice continuation.
This was originally handled properly in nfsd_splice_actor, but commit
91e23b1c3982 ("NFSD: Clean up nfsd_splice_actor()") removed the check
for it.

Fixes: 91e23b1c3982 ("NFSD: Clean up nfsd_splice_actor()")
Cc: Al Viro <viro@zeniv.linux.org.uk>
Reported-by: Dario Lesca <d.lesca@solinos.it>
Tested-by: David Critch <dcritch@redhat.com>
Link: https://bugzilla.redhat.com/show_bug.cgi?id=2150630
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2023-03-17 18:18:15 -04:00
..
2022-12-23 11:39:18 -08:00
2023-02-12 11:26:36 -08:00
2022-12-13 10:43:59 -08:00
2022-12-15 18:14:21 -08:00
\n
2022-12-12 20:32:50 -08:00
2022-12-13 19:29:45 -08:00
2023-01-31 16:44:08 -08:00
2022-12-13 19:29:45 -08:00
2022-12-11 18:12:18 -08:00
2022-12-14 10:11:51 -08:00
2022-10-20 10:13:27 +02:00
2022-12-13 19:29:45 -08:00
2022-09-24 07:00:00 +02:00
2023-03-10 09:38:47 -05:00
2022-12-11 18:12:18 -08:00
2022-12-23 11:55:54 -08:00
2022-10-10 19:45:17 -07:00
2022-12-13 09:47:48 -08:00
2022-05-09 16:21:46 -04:00
2023-01-06 15:44:32 +01:00
2022-09-11 20:26:07 -07:00
2023-01-05 07:34:21 -08:00
2023-02-03 17:52:24 -08:00
2022-10-20 10:13:27 +02:00
2022-08-20 11:34:33 -04:00
2022-10-10 19:45:17 -07:00
2022-12-12 19:20:05 -08:00
2022-12-15 18:09:48 -08:00
2022-12-12 19:20:05 -08:00
2022-12-12 19:03:10 -08:00
2022-04-01 19:35:56 -07:00
2022-10-10 14:21:11 -07:00
2022-08-03 10:35:43 -07:00
2022-12-12 19:30:18 -08:00
2022-12-13 09:14:50 -08:00
2022-12-21 14:45:25 +01:00
2022-12-12 19:30:18 -08:00
2022-06-28 13:58:05 -04:00
2022-12-13 10:26:38 -08:00
2022-10-26 10:02:34 +02:00
2022-12-12 18:38:47 -08:00