e711b0fd45
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Takashi Iwai <tiwai@suse.de> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> Link: https://lore.kernel.org/r/20230315150745.67084-41-u.kleine-koenig@pengutronix.de Signed-off-by: Mark Brown <broonie@kernel.org>
118 lines
2.8 KiB
C
118 lines
2.8 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/*
|
|
* SoC audio for EDB93xx
|
|
*
|
|
* Copyright (c) 2010 Alexander Sverdlin <subaparts@yandex.ru>
|
|
*
|
|
* This driver support CS4271 codec being master or slave, working
|
|
* in control port mode, connected either via SPI or I2C.
|
|
* The data format accepted is I2S or left-justified.
|
|
* DAPM support not implemented.
|
|
*/
|
|
|
|
#include <linux/platform_device.h>
|
|
#include <linux/gpio.h>
|
|
#include <linux/module.h>
|
|
#include <linux/soc/cirrus/ep93xx.h>
|
|
#include <sound/core.h>
|
|
#include <sound/pcm.h>
|
|
#include <sound/soc.h>
|
|
#include <asm/mach-types.h>
|
|
|
|
static int edb93xx_hw_params(struct snd_pcm_substream *substream,
|
|
struct snd_pcm_hw_params *params)
|
|
{
|
|
struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream);
|
|
struct snd_soc_dai *codec_dai = asoc_rtd_to_codec(rtd, 0);
|
|
struct snd_soc_dai *cpu_dai = asoc_rtd_to_cpu(rtd, 0);
|
|
int err;
|
|
unsigned int mclk_rate;
|
|
unsigned int rate = params_rate(params);
|
|
|
|
/*
|
|
* According to CS4271 datasheet we use MCLK/LRCK=256 for
|
|
* rates below 50kHz and 128 for higher sample rates
|
|
*/
|
|
if (rate < 50000)
|
|
mclk_rate = rate * 64 * 4;
|
|
else
|
|
mclk_rate = rate * 64 * 2;
|
|
|
|
err = snd_soc_dai_set_sysclk(codec_dai, 0, mclk_rate,
|
|
SND_SOC_CLOCK_IN);
|
|
if (err)
|
|
return err;
|
|
|
|
return snd_soc_dai_set_sysclk(cpu_dai, 0, mclk_rate,
|
|
SND_SOC_CLOCK_OUT);
|
|
}
|
|
|
|
static const struct snd_soc_ops edb93xx_ops = {
|
|
.hw_params = edb93xx_hw_params,
|
|
};
|
|
|
|
SND_SOC_DAILINK_DEFS(hifi,
|
|
DAILINK_COMP_ARRAY(COMP_CPU("ep93xx-i2s")),
|
|
DAILINK_COMP_ARRAY(COMP_CODEC("spi0.0", "cs4271-hifi")),
|
|
DAILINK_COMP_ARRAY(COMP_PLATFORM("ep93xx-i2s")));
|
|
|
|
static struct snd_soc_dai_link edb93xx_dai = {
|
|
.name = "CS4271",
|
|
.stream_name = "CS4271 HiFi",
|
|
.dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF |
|
|
SND_SOC_DAIFMT_CBC_CFC,
|
|
.ops = &edb93xx_ops,
|
|
SND_SOC_DAILINK_REG(hifi),
|
|
};
|
|
|
|
static struct snd_soc_card snd_soc_edb93xx = {
|
|
.name = "EDB93XX",
|
|
.owner = THIS_MODULE,
|
|
.dai_link = &edb93xx_dai,
|
|
.num_links = 1,
|
|
};
|
|
|
|
static int edb93xx_probe(struct platform_device *pdev)
|
|
{
|
|
struct snd_soc_card *card = &snd_soc_edb93xx;
|
|
int ret;
|
|
|
|
ret = ep93xx_i2s_acquire();
|
|
if (ret)
|
|
return ret;
|
|
|
|
card->dev = &pdev->dev;
|
|
|
|
ret = snd_soc_register_card(card);
|
|
if (ret) {
|
|
dev_err(&pdev->dev, "snd_soc_register_card() failed: %d\n",
|
|
ret);
|
|
ep93xx_i2s_release();
|
|
}
|
|
|
|
return ret;
|
|
}
|
|
|
|
static void edb93xx_remove(struct platform_device *pdev)
|
|
{
|
|
struct snd_soc_card *card = platform_get_drvdata(pdev);
|
|
|
|
snd_soc_unregister_card(card);
|
|
ep93xx_i2s_release();
|
|
}
|
|
|
|
static struct platform_driver edb93xx_driver = {
|
|
.driver = {
|
|
.name = "edb93xx-audio",
|
|
},
|
|
.probe = edb93xx_probe,
|
|
.remove_new = edb93xx_remove,
|
|
};
|
|
|
|
module_platform_driver(edb93xx_driver);
|
|
|
|
MODULE_AUTHOR("Alexander Sverdlin <subaparts@yandex.ru>");
|
|
MODULE_DESCRIPTION("ALSA SoC EDB93xx");
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_ALIAS("platform:edb93xx-audio");
|