iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net/ipv4
History
Eric Dumazet a181ceb501 tcp: autocork should not hold first packet in write queue 
Willem noticed a TCP_RR regression caused by TCP autocorking
on a Mellanox test bed. MLX4_EN_TX_COAL_TIME is 16 us, which can be
right above RTT between hosts.

We can receive a ACK for a packet still in NIC TX ring buffer or in a
softnet completion queue.

Fix this by always pushing the skb if it is at the head of write queue.

Also, as TX completion is lockless, it's safer to perform sk_wmem_alloc
test after setting TSQ_THROTTLED.

erd:~# MIB="MIN_LATENCY,MEAN_LATENCY,MAX_LATENCY,P99_LATENCY,STDDEV_LATENCY"
erd:~#  ./netperf -H remote -t TCP_RR -- -o $MIB | tail -n 1
(repeat 3 times)

Before patch :

18,1049.87,41004,39631,6295.47
17,239.52,40804,48,2912.79
18,348.40,40877,54,3573.39

After patch :

18,22.84,4606,38,16.39
17,21.56,2871,36,13.51
17,22.46,2705,37,11.83

Reported-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Fixes: f54b311142a9 ("tcp: auto corking")
Signed-off-by: David S. Miller <davem@davemloft.net>
2013-12-20 17:56:25 -05:00
..
netfilter
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
2013-12-18 16:42:06 -05:00
af_inet.c
Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next
2013-12-19 18:37:49 -05:00
ah4.c
ipv4: properly refresh rtable entries on pmtu/redirect events
2013-06-03 00:07:42 -07:00
arp.c
ipv4: fix wildcard search with inet_confirm_addr()
2013-12-11 14:47:40 -05:00
cipso_ipv4.c
ipv4/ipv6: Fix FSF address in file headers
2013-12-06 12:37:56 -05:00
datagram.c
net: Remove FLOWI_FLAG_CAN_SLEEP
2013-12-06 07:24:39 +01:00
devinet.c
netconf: add proxy-arp support
2013-12-14 00:58:22 -05:00
esp4.c
net: esp{4,6}: get rid of struct esp_data
2013-10-29 06:39:42 +01:00
fib_frontend.c
fib_trie: remove duplicated rcu lock
2013-10-18 13:53:59 -04:00
fib_lookup.h
net: ipv4/ipv6: Remove extern from function prototypes
2013-10-19 19:12:11 -04:00
fib_rules.c
inet: fix NULL pointer Oops in fib(6)_rule_suppress
2013-12-10 17:54:23 -05:00
fib_semantics.c
fib: Use const struct nl_info * in rtmsg_fib
2013-10-18 14:42:15 -04:00
fib_trie.c
seq_file: remove "%n" usage from seq_file users
2013-11-15 09:32:20 +09:00
gre_demux.c
ipv4: generalize gre_handle_offloads
2013-10-19 19:36:18 -04:00
gre_offload.c
ipip: add GSO/TSO support
2013-10-19 19:36:19 -04:00
icmp.c
ipv4: new ip_no_pmtu_disc mode to always discard incoming frag needed msgs
2013-12-18 16:58:20 -05:00
igmp.c
ipv4 igmp: use in_dev_put in timer handlers instead of __in_dev_put
2013-09-30 22:28:56 -07:00
inet_connection_sock.c
inet: rename ir_loc_port to ir_num
2013-10-10 14:37:35 -04:00
inet_diag.c
inet_diag: use sock_gen_put()
2013-10-17 15:02:02 -04:00
inet_fragment.c
inet: remove old fragmentation hash initializing
2013-10-23 17:01:41 -04:00
inet_hashtables.c
inet: convert inet_ehash_secret and ipv6_hash_secret to net_get_random_once
2013-10-19 19:45:35 -04:00
inet_lro.c
ipv4: replace ip_fast_csum with csum_replace2
2013-03-15 09:12:25 -04:00
inet_timewait_sock.c
tcp/dccp: remove twchain
2013-10-08 23:19:24 -04:00
inetpeer.c
ip: generate unique IP identificator if local fragmentation is allowed
2013-09-19 14:11:15 -04:00
ip_forward.c
ipv4: introduce rt_uses_gateway
2012-10-08 17:42:36 -04:00
ip_fragment.c
net: Add utility functions to clear rxhash
2013-12-17 16:36:21 -05:00
ip_gre.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
2013-08-16 15:37:26 -07:00
ip_input.c
net: add SNMP counters tracking incoming ECN bits
2013-08-08 22:24:59 -07:00
ip_options.c
net/ipv4: Ensure that location of timestamp option is stored
2013-03-12 05:35:39 -04:00
ip_output.c
ipv4: introduce new IP_MTU_DISCOVER mode IP_PMTUDISC_INTERFACE
2013-11-05 21:52:27 -05:00
ip_sockglue.c
net: more spelling fixes
2013-12-10 21:57:11 -05:00
ip_tunnel_core.c
net: Add utility functions to clear rxhash
2013-12-17 16:36:21 -05:00
ip_tunnel.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
2013-11-19 15:50:47 -08:00
ip_vti.c
xfrm: Release dst if this dst is improper for vti tunnel
2013-11-19 15:50:57 -05:00
ipcomp.c
ipv4: properly refresh rtable entries on pmtu/redirect events
2013-06-03 00:07:42 -07:00
ipconfig.c
ipconfig: add informative timeout messages while waiting for carrier
2013-04-02 14:35:33 -04:00
ipip.c
ipip: add GSO/TSO support
2013-10-19 19:36:19 -04:00
ipmr.c
neigh: restore old behaviour of default parms values
2013-12-09 20:56:12 -05:00
Kconfig
net: neighbour: Remove CONFIG_ARPD
2013-09-03 21:41:43 -04:00
Makefile
net: gre: move GSO functions to gre_offload
2013-07-03 14:37:39 -07:00
netfilter.c
netfilter: add my copyright statements
2013-04-18 20:27:55 +02:00
ping.c
inet: fix possible seqlock deadlocks
2013-11-29 16:37:36 -05:00
proc.c
tcp: auto corking
2013-12-06 12:51:41 -05:00
protocol.c
net: remove outdated comment for ipv4 and ipv6 protocol handler
2013-11-28 18:47:51 -05:00
raw.c
net: Remove FLOWI_FLAG_CAN_SLEEP
2013-12-06 07:24:39 +01:00
route.c
ipv4: fix race in concurrent ip_route_input_slow()
2013-11-20 15:28:44 -05:00
syncookies.c
inet: split syncookie keys for ipv4 and ipv6 and initialize with net_get_random_once
2013-10-19 19:45:35 -04:00
sysctl_net_ipv4.c
inet: make no_pmtu_disc per namespace and kill ipv4_config
2013-12-18 16:58:20 -05:00
tcp_bic.c
tcp: properly handle stretch acks in slow start
2013-11-04 19:57:59 -05:00
tcp_cong.c
tcp: properly handle stretch acks in slow start
2013-11-04 19:57:59 -05:00
tcp_cubic.c
tcp: properly handle stretch acks in slow start
2013-11-04 19:57:59 -05:00
tcp_diag.c
…
tcp_fastopen.c
tcp: enable sockets to use MSG_FASTOPEN by default
2013-11-04 19:57:47 -05:00
tcp_highspeed.c
tcp: properly handle stretch acks in slow start
2013-11-04 19:57:59 -05:00
tcp_htcp.c
tcp: properly handle stretch acks in slow start
2013-11-04 19:57:59 -05:00
tcp_hybla.c
tcp: properly handle stretch acks in slow start
2013-11-04 19:57:59 -05:00
tcp_illinois.c
tcp: properly handle stretch acks in slow start
2013-11-04 19:57:59 -05:00
tcp_input.c
tcp: properly handle stretch acks in slow start
2013-11-04 19:57:59 -05:00
tcp_ipv4.c
net: Remove FLOWI_FLAG_CAN_SLEEP
2013-12-06 07:24:39 +01:00
tcp_lp.c
tcp: properly handle stretch acks in slow start
2013-11-04 19:57:59 -05:00
tcp_memcontrol.c
tcp_memcontrol: Cleanup/fix cg_proto->memory_pressure handling.
2013-12-05 21:01:01 -05:00
tcp_metrics.c
genetlink: only pass array to genl_register_family_with_ops()
2013-11-19 16:39:05 -05:00
tcp_minisocks.c
ipv6: make lookups simpler and faster
2013-10-09 00:01:25 -04:00
tcp_offload.c
net-gro: Prepare GRO stack for the upcoming tunneling support
2013-12-12 13:47:53 -05:00
tcp_output.c
tcp: refine TSO splits
2013-12-17 15:15:25 -05:00
tcp_probe.c
ipv6: make lookups simpler and faster
2013-10-09 00:01:25 -04:00
tcp_scalable.c
tcp: properly handle stretch acks in slow start
2013-11-04 19:57:59 -05:00
tcp_timer.c
tcp: temporarily disable Fast Open on SYN timeout
2013-10-29 22:50:41 -04:00
tcp_vegas.c
tcp: properly handle stretch acks in slow start
2013-11-04 19:57:59 -05:00
tcp_vegas.h
net: ipv4/ipv6: Remove extern from function prototypes
2013-10-19 19:12:11 -04:00
tcp_veno.c
tcp: properly handle stretch acks in slow start
2013-11-04 19:57:59 -05:00
tcp_westwood.c
tcp: refactor F-RTO
2013-03-21 11:47:50 -04:00
tcp_yeah.c
tcp: properly handle stretch acks in slow start
2013-11-04 19:57:59 -05:00
tcp.c
tcp: autocork should not hold first packet in write queue
2013-12-20 17:56:25 -05:00
tunnel4.c
net: Convert printks to pr_<level>
2012-03-11 23:42:51 -07:00
udp_diag.c
netlink: rename ssk to sk in struct netlink_skb_params
2013-04-19 14:57:56 -04:00
udp_impl.h
net: ipv4/ipv6: Remove extern from function prototypes
2013-10-19 19:12:11 -04:00
udp_offload.c
ipip: add GSO/TSO support
2013-10-19 19:36:19 -04:00
udp.c
Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next
2013-12-19 18:37:49 -05:00
udplite.c
net: ipv4: Standardize prefixes for message logging
2012-03-12 17:05:21 -07:00
xfrm4_input.c
net: Add skb_unclone() helper function.
2013-02-15 15:10:37 -05:00
xfrm4_mode_beet.c
ipsec: be careful of non existing mac headers
2012-02-23 16:50:45 -05:00
xfrm4_mode_transport.c
…
xfrm4_mode_tunnel.c
Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next
2013-09-30 15:24:57 -04:00
xfrm4_output.c
xfrm: revert ipv4 mtu determination to dst_mtu
2013-08-26 12:40:53 +02:00
xfrm4_policy.c
xfrm: Fix null pointer dereference when decoding sessions
2013-11-01 07:08:46 +01:00
xfrm4_state.c
inet: make no_pmtu_disc per namespace and kill ipv4_config
2013-12-18 16:58:20 -05:00
xfrm4_tunnel.c
sit: add IPv4 over IPv4 support
2013-05-31 17:19:05 -07:00