Changwei Ge 298ed64f1e ocfs2: fix a misuse a of brelse after failing ocfs2_check_dir_entry ...

commit 29aa30167a upstream.

Somehow, file system metadata was corrupted, which causes
ocfs2_check_dir_entry() to fail in function ocfs2_dir_foreach_blk_el().

According to the original design intention, if above happens we should
skip the problematic block and continue to retrieve dir entry.  But
there is obviouse misuse of brelse around related code.

After failure of ocfs2_check_dir_entry(), current code just moves to
next position and uses the problematic buffer head again and again
during which the problematic buffer head is released for multiple times.
I suppose, this a serious issue which is long-lived in ocfs2.  This may
cause other file systems which is also used in a the same host insane.

So we should also consider about bakcporting this patch into linux
-stable.

Link: http://lkml.kernel.org/r/HK2PR06MB045211675B43EED794E597B6D56E0@HK2PR06MB0452.apcprd06.prod.outlook.com
Signed-off-by: Changwei Ge <ge.changwei@h3c.com>
Suggested-by: Changkuo Shi <shi.changkuo@h3c.com>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Cc: Mark Fasheh <mark@fasheh.com>
Cc: Joel Becker <jlbec@evilplan.org>
Cc: Junxiao Bi <junxiao.bi@oracle.com>
Cc: Joseph Qi <jiangqi903@gmail.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2018-11-21 09:27:42 +01:00

..

cluster

ocfs2: subsystem.su_mutex is required while accessing the item->ci_parent

2018-07-22 14:25:52 +02:00

dlm

ocfs2: fix locking for res->tracking and dlm->tracking_list

2018-10-10 08:52:13 +02:00

dlmfs

VFS: normal filesystems (and lustre): d_inode() annotations

2015-04-15 15:06:57 -04:00

acl.c

ocfs2/acl: use 'ip_xattr_sem' to protect getting extended attribute

2018-05-30 07:48:55 +02:00

acl.h

ocfs2: fix posix_acl_create deadlock

2016-05-18 17:06:44 -07:00

alloc.c

ocfs2: fstrim: Fix start offset of first cluster group during fstrim

2017-11-08 10:06:28 +01:00

alloc.h

ocfs2: reflink: fix slow unlink for refcounted file

2014-12-18 19:08:11 -08:00

aops.c

fs: add i_blocksize()

2017-06-14 13:16:24 +02:00

aops.h

ocfs2: remove OCFS2_IOCB_SEM lock type in direct io

2015-06-24 17:49:39 -07:00

blockcheck.c

…

blockcheck.h

…

buffer_head_io.c

ocfs2: fix ocfs2 read block panic

2018-09-29 03:08:53 -07:00

buffer_head_io.h

…

dcache.c

VFS: normal filesystems (and lustre): d_inode() annotations

2015-04-15 15:06:57 -04:00

dcache.h

ocfs2: revert iput deferring code in ocfs2_drop_dentry_lock

2014-04-03 16:20:55 -07:00

dir.c

ocfs2: fix a misuse a of brelse after failing ocfs2_check_dir_entry

2018-11-21 09:27:42 +01:00

dir.h

VFS: normal filesystems (and lustre): d_inode() annotations

2015-04-15 15:06:57 -04:00

dlmglue.c

ocfs2/dlmglue: prepare tracking logic to avoid recursive cluster lock

2017-10-21 17:09:05 +02:00

dlmglue.h

ocfs2/dlmglue: prepare tracking logic to avoid recursive cluster lock

2017-10-21 17:09:05 +02:00

export.c

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs

2015-04-26 17:22:07 -07:00

export.h

…

extent_map.c

ocfs2: neaten do_error, ocfs2_error and ocfs2_abort

2015-09-04 16:54:41 -07:00

extent_map.h

…

file.c

Revert "ocfs2: should wait dio before inode lock in ocfs2_setattr()"

2017-12-09 18:42:43 +01:00

file.h

ocfs2: prepare some interfaces used in append direct io

2015-02-16 17:56:04 -08:00

heartbeat.c

…

heartbeat.h

…

inode.c

ocfs2: neaten do_error, ocfs2_error and ocfs2_abort

2015-09-04 16:54:41 -07:00

inode.h

ocfs2: only take lock if dio entry when recover orphans

2015-11-05 19:34:48 -08:00

ioctl.c

ioctl_compat: handle FITRIM

2015-07-09 11:42:21 -07:00

ioctl.h

…

journal.c

ocfs2: return error when we attempt to access a dirty bh in jbd2

2018-05-30 07:48:55 +02:00

journal.h

ocfs2: add functions to add and remove inode in orphan dir

2015-02-16 17:56:04 -08:00

Kconfig

…

localalloc.c

ocfs2: neaten do_error, ocfs2_error and ocfs2_abort

2015-09-04 16:54:41 -07:00

localalloc.h

ocfs2: free allocated clusters if error occurs after ocfs2_claim_clusters

2014-02-06 13:48:51 -08:00

locks.c

ocfs2: fix flock panic issue

2015-12-29 17:45:49 -08:00

locks.h

…

Makefile

ocfs2: remove versioning information

2014-01-21 16:19:41 -08:00

mmap.c

mm: drop vm_ops->remap_pages and generic_file_remap_pages() stub

2015-02-10 14:30:30 -08:00

mmap.h

…

move_extents.c

ocfs2: neaten do_error, ocfs2_error and ocfs2_abort

2015-09-04 16:54:41 -07:00

move_extents.h

…

namei.c

ocfs2: fix posix_acl_create deadlock

2016-05-18 17:06:44 -07:00

namei.h

ocfs2: do not include dio entry in case of orphan scan

2015-11-05 19:34:48 -08:00

ocfs1_fs_compat.h

…

ocfs2_fs.h

treewide: fix typos in comment blocks

2015-08-07 14:46:24 +02:00

ocfs2_ioctl.h

…

ocfs2_lockid.h

…

ocfs2_lockingver.h

…

ocfs2_trace.h

ocfs2: fix a tiny race when running dirop_fileop_racer

2014-06-23 16:47:45 -07:00

ocfs2.h

ocfs2/dlmglue: prepare tracking logic to avoid recursive cluster lock

2017-10-21 17:09:05 +02:00

quota_global.c

ocfs2: Don't use MAXQUOTAS value

2014-09-17 11:59:12 +02:00

quota_local.c

ocfs2: neaten do_error, ocfs2_error and ocfs2_abort

2015-09-04 16:54:41 -07:00

quota.h

ocfs2: Move OLQF_CLEAN flag out of generic quota flags

2015-01-21 19:21:30 +01:00

refcounttree.c

ocfs2: fix posix_acl_create deadlock

2016-05-18 17:06:44 -07:00

refcounttree.h

ocfs2: fix NULL pointer dereference in ocfs2_duplicate_clusters_by_page

2013-08-13 17:57:49 -07:00

reservations.c

ocfs2: make resv_lock spinlock static

2015-02-10 14:30:29 -08:00

reservations.h

…

resize.c

ocfs2: fix BUG when calculate new backup super

2015-12-29 17:45:49 -08:00

resize.h

…

slot_map.c

ocfs2: one function call less in ocfs2_init_slot_info() after error detection

2015-04-14 16:48:57 -07:00

slot_map.h

…

stack_o2cb.c

ocfs2: avoid a pointless delay in o2cb_cluster_check()

2015-04-14 16:48:57 -07:00

stack_user.c

char: make misc_deregister a void function

2015-08-05 10:35:49 -07:00

stackglue.c

ocfs2: fix crash caused by stale lvb with fsdlm plugin

2017-01-19 20:17:19 +01:00

stackglue.h

ocfs2: fix crash caused by stale lvb with fsdlm plugin

2017-01-19 20:17:19 +01:00

suballoc.c

ocfs2: improve performance for localalloc

2015-11-05 19:34:48 -08:00

suballoc.h

ocfs2: rollback alloc_dinode counts when ocfs2_block_group_set_bits() failed

2014-04-03 16:20:56 -07:00

super.c

ocfs2: return -EROFS to mount.ocfs2 if inode block is invalid

2018-05-30 07:48:55 +02:00

super.h

ocfs2: neaten do_error, ocfs2_error and ocfs2_abort

2015-09-04 16:54:41 -07:00

symlink.c

…

symlink.h

…

sysfile.c

ocfs2: avoid system inode ref confusion by adding mutex lock

2014-04-03 16:20:57 -07:00

sysfile.h

…

uptodate.c

ocfs2: remove NULL assignments on static

2014-06-04 16:53:53 -07:00

uptodate.h

…

xattr.c

ocfs2/acl: use 'ip_xattr_sem' to protect getting extended attribute

2018-05-30 07:48:55 +02:00

xattr.h

ocfs2: fix posix_acl_create deadlock

2016-05-18 17:06:44 -07:00