iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net
History
Haishuang Yan 043b985f7c ip_vti: fix a null pointer deferrence when create vti fallback tunnel 
[ Upstream commit cd1aa9c2c665cafbd05b83507d3f1096f3912aa4 ]

After set fb_tunnels_only_for_init_net to 1, the itn->fb_tunnel_dev will
be NULL and will cause following crash:

[ 2742.849298] BUG: unable to handle kernel NULL pointer dereference at 0000000000000941
[ 2742.851380] PGD 800000042c21a067 P4D 800000042c21a067 PUD 42aaed067 PMD 0
[ 2742.852818] Oops: 0002 [#1] SMP PTI
[ 2742.853570] CPU: 7 PID: 2484 Comm: unshare Kdump: loaded Not tainted 4.18.0-rc8+ #2
[ 2742.855163] Hardware name: Fedora Project OpenStack Nova, BIOS seabios-1.7.5-11.el7 04/01/2014
[ 2742.856970] RIP: 0010:vti_init_net+0x3a/0x50 [ip_vti]
[ 2742.858034] Code: 90 83 c0 48 c7 c2 20 a1 83 c0 48 89 fb e8 6e 3b f6 ff 85 c0 75 22 8b 0d f4 19 00 00 48 8b 93 00 14 00 00 48 8b 14 ca 48 8b 12 <c6> 82 41 09 00 00 04 c6 82 38 09 00 00 45 5b c3 66 0f 1f 44 00 00
[ 2742.861940] RSP: 0018:ffff9be28207fde0 EFLAGS: 00010246
[ 2742.863044] RAX: 0000000000000000 RBX: ffff8a71ebed4980 RCX: 0000000000000013
[ 2742.864540] RDX: 0000000000000000 RSI: 0000000000000013 RDI: ffff8a71ebed4980
[ 2742.866020] RBP: ffff8a71ea717000 R08: ffffffffc083903c R09: ffff8a71ea717000
[ 2742.867505] R10: 0000000000000000 R11: 0000000000000000 R12: ffff8a71ebed4980
[ 2742.868987] R13: 0000000000000013 R14: ffff8a71ea5b49c0 R15: 0000000000000000
[ 2742.870473] FS:  00007f02266c9740(0000) GS:ffff8a71ffdc0000(0000) knlGS:0000000000000000
[ 2742.872143] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 2742.873340] CR2: 0000000000000941 CR3: 000000042bc20006 CR4: 00000000001606e0
[ 2742.874821] Call Trace:
[ 2742.875358]  ops_init+0x38/0xf0
[ 2742.876078]  setup_net+0xd9/0x1f0
[ 2742.876789]  copy_net_ns+0xb7/0x130
[ 2742.877538]  create_new_namespaces+0x11a/0x1d0
[ 2742.878525]  unshare_nsproxy_namespaces+0x55/0xa0
[ 2742.879526]  ksys_unshare+0x1a7/0x330
[ 2742.880313]  __x64_sys_unshare+0xe/0x20
[ 2742.881131]  do_syscall_64+0x5b/0x180
[ 2742.881933]  entry_SYSCALL_64_after_hwframe+0x44/0xa9

Reproduce:
echo 1 > /proc/sys/net/core/fb_tunnels_only_for_init_net
modprobe ip_vti
unshare -n

Fixes: 79134e6ce2c9 ("net: do not create fallback tunnels for non-default namespaces")
Cc: Eric Dumazet <edumazet@google.com>
Signed-off-by: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2018-08-22 07:43:44 +02:00
..
6lowpan
…
9p
net/9p/client.c: put refcount of trans_mod in error case in parse_opts()
2018-07-14 11:11:09 -07:00
802
…
8021q
net: fix use-after-free in GRO with ESP
2018-07-02 20:34:04 +09:00
appletalk
Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLL
2018-06-28 10:40:47 -07:00
atm
Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLL
2018-06-28 10:40:47 -07:00
ax25
Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLL
2018-06-28 10:40:47 -07:00
batman-adv
batman-adv: Fix multicast TT issues with bogus ROAM flags
2018-06-23 10:29:33 +02:00
bluetooth
Bluetooth: avoid killing an already killed socket
2018-08-22 07:43:43 +02:00
bpf
bpf: fix panic due to oob in bpf_prog_test_run_skb
2018-07-11 16:10:57 -07:00
bpfilter
bpfilter: include bpfilter_umh in assembly instead of using objcopy
2018-06-28 21:39:16 +09:00
bridge
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
2018-06-16 07:39:34 +09:00
caif
net: caif: Add a missing rcu_read_unlock() in caif_flow_cb
2018-07-21 16:14:39 -07:00
can
Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLL
2018-06-28 10:40:47 -07:00
ceph
The main piece is a set of libceph changes that revamps how OSD
2018-06-15 07:24:58 +09:00
core
net: sock_diag: Fix spectre v1 gadget in __sock_diag_cmd()
2018-08-22 07:43:43 +02:00
dcb
treewide: kmalloc() -> kmalloc_array()
2018-06-12 16:19:22 -07:00
dccp
dccp: fix undefined behavior with 'cwnd' shift in ccid2_cwnd_restart()
2018-08-07 15:34:44 -07:00
decnet
Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLL
2018-06-28 10:40:47 -07:00
dns_resolver
KEYS: DNS: fix parsing multiple options
2018-07-16 11:22:14 -07:00
dsa
dsa: slave: eee: Allow ports to use phylink
2018-08-08 19:19:03 -07:00
ethernet
net: core: rework basic flow dissection helper
2018-05-08 00:02:36 -04:00
hsr
…
ieee802154
ieee802154: 6lowpan: set IFLA_LINK
2018-07-05 11:13:17 +02:00
ife
net: sched: ife: check on metadata length
2018-04-22 21:12:00 -04:00
ipv4
ip_vti: fix a null pointer deferrence when create vti fallback tunnel
2018-08-22 07:43:44 +02:00
ipv6
ip6_tunnel: use the right value for ipv4 min mtu check in ip6_tnl_xmit
2018-08-05 17:35:02 -07:00
iucv
Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLL
2018-06-28 10:40:47 -07:00
kcm
Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLL
2018-06-28 10:40:47 -07:00
key
Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLL
2018-06-28 10:40:47 -07:00
l2tp
l2tp: use sk_dst_check() to avoid race on sk->sk_dst_cache
2018-08-22 07:43:40 +02:00
l3mdev
…
lapb
…
llc
llc: use refcount_inc_not_zero() for llc_sap_find()
2018-08-07 15:54:00 -07:00
mac80211
nl80211/mac80211: allow non-linear skb in rx_control_port
2018-07-06 14:34:42 +02:00
mac802154
net/mac802154: disambiguate mac80215 vs mac802154 trace events
2018-03-28 22:55:18 +02:00
mpls
net: Drop pernet_operations::async
2018-03-27 13:18:09 -04:00
ncsi
net/ncsi: Use netdev_dbg for debug messages
2018-06-20 07:26:58 +09:00
netfilter
netfilter: nf_tables: move dumper state allocation into ->start
2018-07-24 00:36:33 +02:00
netlabel
audit: use inline function to get audit context
2018-05-14 17:24:18 -04:00
netlink
netlink: Don't shift on 64 for ngroups
2018-08-04 17:52:51 -07:00
netrom
Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLL
2018-06-28 10:40:47 -07:00
nfc
net/nfc: Avoid stalls when nfc_alloc_send_skb() returned NULL.
2018-07-18 10:51:45 -07:00
nsh
nsh: set mac len based on inner packet
2018-07-12 16:55:29 -07:00
openvswitch
openvswitch: meter: Fix setting meter id for new entries
2018-07-29 13:20:54 -07:00
packet
packet: refine ring v3 block size test to hold one frame
2018-08-06 13:48:33 -07:00
phonet
Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLL
2018-06-28 10:40:47 -07:00
psample
…
qrtr
net: qrtr: Reset the node and port ID of broadcast messages
2018-07-05 20:20:03 +09:00
rds
RDS: RDMA: Fix the NULL-ptr deref in rds_ib_get_mr
2018-07-26 14:03:07 -07:00
rfkill
rfkill: Create rfkill-none LED trigger
2018-05-23 11:26:45 +02:00
rose
Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLL
2018-06-28 10:40:47 -07:00
rxrpc
rxrpc: Fix the keepalive generator [ver #2]
2018-08-08 19:10:26 -07:00
sched
net_sched: Fix missing res info when create new tc_index filter
2018-08-22 07:43:40 +02:00
sctp
sctp: fix the issue that pathmtu may be set lower than MINSEGMENT
2018-07-04 21:36:34 +09:00
smc
net/smc: move sock lock in smc_ioctl()
2018-08-08 19:14:22 -07:00
strparser
strparser: Remove early eaten to fix full tcp receive buffer stall
2018-06-28 21:37:26 +09:00
sunrpc
NFS client bugfixes for Linux 4.18
2018-06-22 06:21:34 +09:00
switchdev
…
tipc
tipc: fix an interrupt unsafe locking scenario
2018-08-07 13:15:35 -07:00
tls
tls: check RCV_SHUTDOWN in tls_wait_data
2018-07-20 14:38:14 -07:00
unix
Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLL
2018-06-28 10:40:47 -07:00
vmw_vsock
vsock: split dwork to avoid reinitializations
2018-08-07 12:39:13 -07:00
wimax
…
wireless
cfg80211: never ignore user regulatory hint
2018-07-24 09:11:31 +02:00
x25
Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLL
2018-06-28 10:40:47 -07:00
xdp
net: xsk: don't return frames via the allocator on error
2018-07-31 02:03:19 +02:00
xfrm
xfrm: free skb if nlsk pointer is NULL
2018-06-25 16:43:36 +02:00
compat.c
net: support compat 64-bit time in {s,g}etsockopt
2018-04-27 19:46:06 -04:00
Kconfig
net: Introduce generic failover module
2018-05-28 22:59:54 -04:00
Makefile
bpfilter: check compiler capability in Kconfig
2018-06-28 13:36:39 +09:00
socket.c
net: sock_diag: Fix spectre v1 gadget in __sock_diag_cmd()
2018-08-22 07:43:43 +02:00
sysctl_net.c
net: Drop pernet_operations::async
2018-03-27 13:18:09 -04:00