c28548012e
Interrupt entry sets the soft mask to IRQS_ALL_DISABLED to match the hard irq disabled state. So when should_hard_irq_enable() returns true because we want PMI interrupts in irq handlers, MSR[EE] is enabled but PMIs just get soft-masked. Fix this by clearing IRQS_PMI_DISABLED before enabling MSR[EE]. This also tidies some of the warnings, no need to duplicate them in both should_hard_irq_enable() and do_hard_irq_enable(). Signed-off-by: Nicholas Piggin <npiggin@gmail.com> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Link: https://lore.kernel.org/r/20230121100156.2824054-1-npiggin@gmail.com
48 lines
1006 B
C
48 lines
1006 B
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/*
|
|
* Author: Kumar Gala <galak@kernel.crashing.org>
|
|
*
|
|
* Copyright 2009 Freescale Semiconductor Inc.
|
|
*/
|
|
|
|
#include <linux/stddef.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/smp.h>
|
|
#include <linux/threads.h>
|
|
#include <linux/hardirq.h>
|
|
|
|
#include <asm/dbell.h>
|
|
#include <asm/interrupt.h>
|
|
#include <asm/irq_regs.h>
|
|
#include <asm/kvm_ppc.h>
|
|
#include <asm/trace.h>
|
|
|
|
#ifdef CONFIG_SMP
|
|
|
|
DEFINE_INTERRUPT_HANDLER_ASYNC(doorbell_exception)
|
|
{
|
|
struct pt_regs *old_regs = set_irq_regs(regs);
|
|
|
|
trace_doorbell_entry(regs);
|
|
|
|
ppc_msgsync();
|
|
|
|
if (should_hard_irq_enable(regs))
|
|
do_hard_irq_enable();
|
|
|
|
kvmppc_clear_host_ipi(smp_processor_id());
|
|
__this_cpu_inc(irq_stat.doorbell_irqs);
|
|
|
|
smp_ipi_demux_relaxed(); /* already performed the barrier */
|
|
|
|
trace_doorbell_exit(regs);
|
|
|
|
set_irq_regs(old_regs);
|
|
}
|
|
#else /* CONFIG_SMP */
|
|
DEFINE_INTERRUPT_HANDLER_ASYNC(doorbell_exception)
|
|
{
|
|
printk(KERN_WARNING "Received doorbell on non-smp system\n");
|
|
}
|
|
#endif /* CONFIG_SMP */
|