453431a549
As said by Linus: A symmetric naming is only helpful if it implies symmetries in use. Otherwise it's actively misleading. In "kzalloc()", the z is meaningful and an important part of what the caller wants. In "kzfree()", the z is actively detrimental, because maybe in the future we really _might_ want to use that "memfill(0xdeadbeef)" or something. The "zero" part of the interface isn't even _relevant_. The main reason that kzfree() exists is to clear sensitive information that should not be leaked to other future users of the same memory objects. Rename kzfree() to kfree_sensitive() to follow the example of the recently added kvfree_sensitive() and make the intention of the API more explicit. In addition, memzero_explicit() is used to clear the memory to make sure that it won't get optimized away by the compiler. The renaming is done by using the command sequence: git grep -w --name-only kzfree |\ xargs sed -i 's/kzfree/kfree_sensitive/' followed by some editing of the kfree_sensitive() kerneldoc and adding a kzfree backward compatibility macro in slab.h. [akpm@linux-foundation.org: fs/crypto/inline_crypt.c needs linux/slab.h] [akpm@linux-foundation.org: fix fs/crypto/inline_crypt.c some more] Suggested-by: Joe Perches <joe@perches.com> Signed-off-by: Waiman Long <longman@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Acked-by: David Howells <dhowells@redhat.com> Acked-by: Michal Hocko <mhocko@suse.com> Acked-by: Johannes Weiner <hannes@cmpxchg.org> Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> Cc: James Morris <jmorris@namei.org> Cc: "Serge E. Hallyn" <serge@hallyn.com> Cc: Joe Perches <joe@perches.com> Cc: Matthew Wilcox <willy@infradead.org> Cc: David Rientjes <rientjes@google.com> Cc: Dan Carpenter <dan.carpenter@oracle.com> Cc: "Jason A . Donenfeld" <Jason@zx2c4.com> Link: http://lkml.kernel.org/r/20200616154311.12314-3-longman@redhat.com Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> |
||
|---|---|---|
| .. | ||
| cfg80211.c | ||
| hfa384x_usb.c | ||
| hfa384x.h | ||
| Kconfig | ||
| Makefile | ||
| p80211conv.c | ||
| p80211conv.h | ||
| p80211hdr.h | ||
| p80211ioctl.h | ||
| p80211metadef.h | ||
| p80211metastruct.h | ||
| p80211mgmt.h | ||
| p80211msg.h | ||
| p80211netdev.c | ||
| p80211netdev.h | ||
| p80211req.c | ||
| p80211req.h | ||
| p80211types.h | ||
| p80211wep.c | ||
| prism2fw.c | ||
| prism2mgmt.c | ||
| prism2mgmt.h | ||
| prism2mib.c | ||
| prism2sta.c | ||
| prism2usb.c | ||
| README | ||
TODO: - checkpatch.pl cleanups - sparse warnings - move to use the in-kernel wireless stack Please send any patches or complaints about this driver to Greg Kroah-Hartman <greg@kroah.com> and don't bother the upstream wireless kernel developers about it, they want nothing to do with it.