Su Yue
2acc59dd88
bcachefs: grab s_umount only if snapshotting ...
When I was testing mongodb over bcachefs with compression,
there is a lockdep warning when snapshotting mongodb data volume.
$ cat test.sh
prog=bcachefs
$prog subvolume create /mnt/data
$prog subvolume create /mnt/data/snapshots
while true;do
$prog subvolume snapshot /mnt/data /mnt/data/snapshots/$(date +%s)
sleep 1s
done
$ cat /etc/mongodb.conf
systemLog:
destination: file
logAppend: true
path: /mnt/data/mongod.log
storage:
dbPath: /mnt/data/
lockdep reports:
[ 3437.452330] ======================================================
[ 3437.452750] WARNING: possible circular locking dependency detected
[ 3437.453168] 6.7.0-rc7-custom+ #85 Tainted: G E
[ 3437.453562] ------------------------------------------------------
[ 3437.453981] bcachefs/35533 is trying to acquire lock:
[ 3437.454325] ffffa0a02b2b1418 (sb_writers#10){.+.+}-{0:0}, at: filename_create+0x62/0x190
[ 3437.454875]
but task is already holding lock:
[ 3437.455268] ffffa0a02b2b10e0 (&type->s_umount_key#48){.+.+}-{3:3}, at: bch2_fs_file_ioctl+0x232/0xc90 [bcachefs]
[ 3437.456009]
which lock already depends on the new lock.
[ 3437.456553]
the existing dependency chain (in reverse order) is:
[ 3437.457054]
-> #3 (&type->s_umount_key#48){.+.+}-{3:3}:
[ 3437.457507] down_read+0x3e/0x170
[ 3437.457772] bch2_fs_file_ioctl+0x232/0xc90 [bcachefs]
[ 3437.458206] __x64_sys_ioctl+0x93/0xd0
[ 3437.458498] do_syscall_64+0x42/0xf0
[ 3437.458779] entry_SYSCALL_64_after_hwframe+0x6e/0x76
[ 3437.459155]
-> #2 (&c->snapshot_create_lock){++++}-{3:3}:
[ 3437.459615] down_read+0x3e/0x170
[ 3437.459878] bch2_truncate+0x82/0x110 [bcachefs]
[ 3437.460276] bchfs_truncate+0x254/0x3c0 [bcachefs]
[ 3437.460686] notify_change+0x1f1/0x4a0
[ 3437.461283] do_truncate+0x7f/0xd0
[ 3437.461555] path_openat+0xa57/0xce0
[ 3437.461836] do_filp_open+0xb4/0x160
[ 3437.462116] do_sys_openat2+0x91/0xc0
[ 3437.462402] __x64_sys_openat+0x53/0xa0
[ 3437.462701] do_syscall_64+0x42/0xf0
[ 3437.462982] entry_SYSCALL_64_after_hwframe+0x6e/0x76
[ 3437.463359]
-> #1 (&sb->s_type->i_mutex_key#15){+.+.}-{3:3}:
[ 3437.463843] down_write+0x3b/0xc0
[ 3437.464223] bch2_write_iter+0x5b/0xcc0 [bcachefs]
[ 3437.464493] vfs_write+0x21b/0x4c0
[ 3437.464653] ksys_write+0x69/0xf0
[ 3437.464839] do_syscall_64+0x42/0xf0
[ 3437.465009] entry_SYSCALL_64_after_hwframe+0x6e/0x76
[ 3437.465231]
-> #0 (sb_writers#10){.+.+}-{0:0}:
[ 3437.465471] __lock_acquire+0x1455/0x21b0
[ 3437.465656] lock_acquire+0xc6/0x2b0
[ 3437.465822] mnt_want_write+0x46/0x1a0
[ 3437.465996] filename_create+0x62/0x190
[ 3437.466175] user_path_create+0x2d/0x50
[ 3437.466352] bch2_fs_file_ioctl+0x2ec/0xc90 [bcachefs]
[ 3437.466617] __x64_sys_ioctl+0x93/0xd0
[ 3437.466791] do_syscall_64+0x42/0xf0
[ 3437.466957] entry_SYSCALL_64_after_hwframe+0x6e/0x76
[ 3437.467180]
other info that might help us debug this:
[ 3437.469670] 2 locks held by bcachefs/35533:
other info that might help us debug this:
[ 3437.467507] Chain exists of:
sb_writers#10 --> &c->snapshot_create_lock --> &type->s_umount_key#48
[ 3437.467979] Possible unsafe locking scenario:
[ 3437.468223] CPU0 CPU1
[ 3437.468405] ---- ----
[ 3437.468585] rlock(&type->s_umount_key#48);
[ 3437.468758] lock(&c->snapshot_create_lock);
[ 3437.469030] lock(&type->s_umount_key#48);
[ 3437.469291] rlock(sb_writers#10);
[ 3437.469434]
*** DEADLOCK ***
[ 3437.469670] 2 locks held by bcachefs/35533:
[ 3437.469838] #0 : ffffa0a02ce00a88 (&c->snapshot_create_lock){++++}-{3:3}, at: bch2_fs_file_ioctl+0x1e3/0xc90 [bcachefs]
[ 3437.470294] #1 : ffffa0a02b2b10e0 (&type->s_umount_key#48){.+.+}-{3:3}, at: bch2_fs_file_ioctl+0x232/0xc90 [bcachefs]
[ 3437.470744]
stack backtrace:
[ 3437.470922] CPU: 7 PID: 35533 Comm: bcachefs Kdump: loaded Tainted: G E 6.7.0-rc7-custom+ #85
[ 3437.471313] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Arch Linux 1.16.3-1-1 04/01/2014
[ 3437.471694] Call Trace:
[ 3437.471795] <TASK>
[ 3437.471884] dump_stack_lvl+0x57/0x90
[ 3437.472035] check_noncircular+0x132/0x150
[ 3437.472202] __lock_acquire+0x1455/0x21b0
[ 3437.472369] lock_acquire+0xc6/0x2b0
[ 3437.472518] ? filename_create+0x62/0x190
[ 3437.472683] ? lock_is_held_type+0x97/0x110
[ 3437.472856] mnt_want_write+0x46/0x1a0
[ 3437.473025] ? filename_create+0x62/0x190
[ 3437.473204] filename_create+0x62/0x190
[ 3437.473380] user_path_create+0x2d/0x50
[ 3437.473555] bch2_fs_file_ioctl+0x2ec/0xc90 [bcachefs]
[ 3437.473819] ? lock_acquire+0xc6/0x2b0
[ 3437.474002] ? __fget_files+0x2a/0x190
[ 3437.474195] ? __fget_files+0xbc/0x190
[ 3437.474380] ? lock_release+0xc5/0x270
[ 3437.474567] ? __x64_sys_ioctl+0x93/0xd0
[ 3437.474764] ? __pfx_bch2_fs_file_ioctl+0x10/0x10 [bcachefs]
[ 3437.475090] __x64_sys_ioctl+0x93/0xd0
[ 3437.475277] do_syscall_64+0x42/0xf0
[ 3437.475454] entry_SYSCALL_64_after_hwframe+0x6e/0x76
[ 3437.475691] RIP: 0033:0x7f2743c313af
======================================================
In __bch2_ioctl_subvolume_create(), we grab s_umount unconditionally
and unlock it at the end of the function. There is a comment
"why do we need this lock?" about the lock coming from
commit 42d237320e98 ("bcachefs: Snapshot creation, deletion")
The reason is that __bch2_ioctl_subvolume_create() calls
sync_inodes_sb() which enforce locked s_umount to writeback all dirty
nodes before doing snapshot works.
Fix it by read locking s_umount for snapshotting only and unlocking
s_umount after sync_inodes_sb().
Signed-off-by: Su Yue <glass.su@suse.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
2024-01-21 13:27:10 -05:00
2023-11-04 09:20:04 -10:00
2023-10-18 13:26:18 +02:00
2023-11-07 12:11:26 -08:00
2023-12-21 10:16:07 -08:00
2023-11-20 14:56:36 +01:00
2024-01-21 13:27:10 -05:00
2023-11-07 12:11:26 -08:00
2023-10-18 13:26:19 +02:00
2023-12-17 09:27:36 -08:00
2023-08-29 14:25:26 -07:00
2023-11-10 09:52:56 -08:00
2023-10-18 13:26:19 +02:00
2023-10-18 13:26:19 +02:00
2023-10-30 09:47:13 -10:00
2023-11-02 16:15:30 -10:00
2023-12-22 07:33:02 +01:00
2023-10-18 13:26:20 +02:00
2023-10-12 15:21:00 -05:00
2023-11-18 14:54:07 +01:00
2023-11-07 12:11:26 -08:00
2023-11-07 12:11:26 -08:00
2023-11-17 19:55:46 +08:00
2023-11-03 22:24:11 +09:00
2023-10-28 16:16:19 +02:00
2023-11-22 10:17:10 +01:00
2023-11-30 23:29:34 -05:00
2023-11-07 12:11:26 -08:00
2023-11-07 12:11:26 -08:00
2023-11-07 12:11:26 -08:00
2023-01-30 12:51:54 +00:00
2023-12-04 10:19:32 +01:00
2023-11-07 11:54:17 -08:00
2023-10-30 09:47:13 -10:00
2023-10-30 09:47:13 -10:00
2023-10-18 14:08:22 +02:00
2023-10-18 14:08:22 +02:00
2023-11-07 12:11:26 -08:00
2023-11-02 19:38:47 -10:00
2023-10-18 14:08:22 +02:00
2023-12-12 10:25:46 -05:00
2023-11-07 12:11:26 -08:00
2023-11-07 12:11:26 -08:00
2023-11-03 15:15:47 -10:00
2023-10-16 12:44:04 -04:00
2023-10-18 14:08:23 +02:00
2023-09-18 12:03:46 -07:00
2023-11-08 13:39:16 -08:00
2023-04-13 13:13:52 -07:00
2023-12-20 11:16:50 -08:00
2023-12-06 16:12:50 -08:00
2023-08-31 12:07:34 -05:00
2023-11-07 12:11:26 -08:00
2023-11-07 12:11:26 -08:00
2023-11-07 12:11:26 -08:00
2023-11-02 20:53:31 -10:00
2023-10-18 14:08:25 +02:00
2023-10-18 14:08:25 +02:00
2023-10-30 09:47:13 -10:00
2023-12-20 12:04:03 -08:00
2023-12-06 16:12:45 -08:00
2023-10-30 19:26:39 -10:00
2023-10-18 14:08:26 +02:00
2023-10-18 14:08:26 +02:00
2023-11-02 19:38:47 -10:00
2023-10-18 14:08:26 +02:00
2023-11-02 19:38:47 -10:00
2023-10-30 09:47:13 -10:00
2023-12-28 16:12:23 -08:00
2023-12-06 16:12:45 -08:00
2023-10-05 13:42:11 +02:00
2023-10-18 14:08:28 +02:00
2023-12-22 08:13:55 -05:00
2023-11-05 08:28:32 -10:00
2023-11-02 08:19:51 -10:00
2023-12-13 11:14:09 -05:00
2023-04-13 13:13:54 -07:00
2023-10-18 14:08:29 +02:00
2023-08-20 10:33:43 -07:00
2023-11-25 08:57:09 -08:00
2023-10-18 14:08:29 +02:00
2023-09-20 14:22:01 +02:00
2023-10-18 14:43:23 -07:00
2023-10-18 13:26:15 +02:00
2023-10-18 13:26:15 +02:00
2023-10-30 19:28:19 -10:00
2023-10-03 19:48:44 -07:00
2023-10-30 19:28:19 -10:00
2023-11-02 20:53:31 -10:00
2023-11-02 20:53:31 -10:00
2023-06-26 09:50:21 -07:00
2023-05-17 09:16:59 +02:00
2023-10-04 10:32:20 -07:00
2023-11-02 20:53:31 -10:00
2023-10-18 14:43:23 -07:00
2023-08-18 10:12:11 -07:00
2023-07-11 11:41:34 +02:00
2023-10-18 14:43:23 -07:00
2023-10-04 10:32:20 -07:00
2023-10-18 14:43:23 -07:00
2023-10-24 17:57:45 +02:00
2023-11-02 20:53:31 -10:00
2023-10-25 22:17:04 +02:00
2023-10-12 18:53:36 +03:00
2023-08-21 13:46:25 -07:00
2023-10-30 09:14:19 -10:00
2023-09-22 14:09:06 +02:00
2023-10-19 11:02:47 +02:00
2023-11-20 15:05:18 +01:00
2023-10-19 11:03:15 +02:00
2023-08-28 11:04:18 -07:00
2023-12-06 16:12:49 -08:00
2023-08-23 14:17:43 -07:00
2023-08-19 12:12:12 +02:00
2023-11-20 15:34:22 +01:00
2023-11-02 20:53:31 -10:00
2023-10-22 17:08:07 -04:00
2023-10-04 10:32:25 -07:00
2023-11-03 23:28:33 +01:00
2023-10-25 16:47:10 -07:00
2023-10-30 09:14:19 -10:00
2023-11-02 20:53:31 -10:00
2023-10-18 13:26:15 +02:00
2023-12-15 14:19:48 -08:00
2023-11-02 20:53:31 -10:00
2023-05-19 04:30:22 +02:00
2023-05-19 04:30:22 +02:00
2023-07-13 10:28:04 +02:00
2023-05-24 08:42:16 -06:00
2023-08-15 08:32:45 +02:00
2023-08-06 15:08:35 +02:00
2023-05-24 11:03:59 +02:00
2023-08-29 14:25:26 -07:00
2023-10-18 13:26:15 +02:00
2023-11-18 14:54:07 +01:00
2023-05-17 15:20:17 +02:00
2023-11-07 11:46:31 -08:00
2023-05-23 21:43:26 -07:00
2023-11-02 20:53:31 -10:00
2023-02-20 11:53:11 -08:00
2023-10-09 16:24:16 +02:00
2acc59dd88