d4d12c02bf
Unlinked list recovery requires errors removing the inode the from the unlinked list get fed back to the main recovery loop. Now that we offload the unlinking to the inodegc work, we don't get errors being fed back when we trip over a corruption that prevents the inode from being removed from the unlinked list. This means we never clear the corrupt unlinked list bucket, resulting in runtime operations eventually tripping over it and shutting down. Fix this by collecting inodegc worker errors and feed them back to the flush caller. This is largely best effort - the only context that really cares is log recovery, and it only flushes a single inode at a time so we don't need complex synchronised handling. Essentially the inodegc workers will capture the first error that occurs and the next flush will gather them and clear them. The flush itself will only report the first gathered error. In the cases where callers can return errors, propagate the collected inodegc flush error up the error handling chain. In the case of inode unlinked list recovery, there are several superfluous calls to flush queued unlinked inodes - xlog_recover_iunlink_bucket() guarantees that it has flushed the inodegc and collected errors before it returns. Hence nothing in the calling path needs to run a flush, even when an error is returned. Signed-off-by: Dave Chinner <dchinner@redhat.com> Reviewed-by: Darrick J. Wong <djwong@kernel.org> Signed-off-by: Dave Chinner <david@fromorbit.com>
90 lines
2.9 KiB
C
90 lines
2.9 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Copyright (c) 2000-2006 Silicon Graphics, Inc.
|
|
* All Rights Reserved.
|
|
*/
|
|
#ifndef XFS_SYNC_H
|
|
#define XFS_SYNC_H 1
|
|
|
|
struct xfs_mount;
|
|
struct xfs_perag;
|
|
|
|
struct xfs_icwalk {
|
|
__u32 icw_flags;
|
|
kuid_t icw_uid;
|
|
kgid_t icw_gid;
|
|
prid_t icw_prid;
|
|
__u64 icw_min_file_size;
|
|
long icw_scan_limit;
|
|
};
|
|
|
|
/* Flags that reflect xfs_fs_eofblocks functionality. */
|
|
#define XFS_ICWALK_FLAG_SYNC (1U << 0) /* sync/wait mode scan */
|
|
#define XFS_ICWALK_FLAG_UID (1U << 1) /* filter by uid */
|
|
#define XFS_ICWALK_FLAG_GID (1U << 2) /* filter by gid */
|
|
#define XFS_ICWALK_FLAG_PRID (1U << 3) /* filter by project id */
|
|
#define XFS_ICWALK_FLAG_MINFILESIZE (1U << 4) /* filter by min file size */
|
|
|
|
#define XFS_ICWALK_FLAGS_VALID (XFS_ICWALK_FLAG_SYNC | \
|
|
XFS_ICWALK_FLAG_UID | \
|
|
XFS_ICWALK_FLAG_GID | \
|
|
XFS_ICWALK_FLAG_PRID | \
|
|
XFS_ICWALK_FLAG_MINFILESIZE)
|
|
|
|
/*
|
|
* Flags for xfs_iget()
|
|
*/
|
|
#define XFS_IGET_CREATE (1U << 0)
|
|
#define XFS_IGET_UNTRUSTED (1U << 1)
|
|
#define XFS_IGET_DONTCACHE (1U << 2)
|
|
/* don't read from disk or reinit */
|
|
#define XFS_IGET_INCORE (1U << 3)
|
|
/* Return -EAGAIN immediately if the inode is unavailable. */
|
|
#define XFS_IGET_NORETRY (1U << 4)
|
|
|
|
int xfs_iget(struct xfs_mount *mp, struct xfs_trans *tp, xfs_ino_t ino,
|
|
uint flags, uint lock_flags, xfs_inode_t **ipp);
|
|
|
|
/* recovery needs direct inode allocation capability */
|
|
struct xfs_inode * xfs_inode_alloc(struct xfs_mount *mp, xfs_ino_t ino);
|
|
void xfs_inode_free(struct xfs_inode *ip);
|
|
|
|
void xfs_reclaim_worker(struct work_struct *work);
|
|
|
|
void xfs_reclaim_inodes(struct xfs_mount *mp);
|
|
long xfs_reclaim_inodes_count(struct xfs_mount *mp);
|
|
long xfs_reclaim_inodes_nr(struct xfs_mount *mp, unsigned long nr_to_scan);
|
|
|
|
void xfs_inode_mark_reclaimable(struct xfs_inode *ip);
|
|
|
|
int xfs_blockgc_free_dquots(struct xfs_mount *mp, struct xfs_dquot *udqp,
|
|
struct xfs_dquot *gdqp, struct xfs_dquot *pdqp,
|
|
unsigned int iwalk_flags);
|
|
int xfs_blockgc_free_quota(struct xfs_inode *ip, unsigned int iwalk_flags);
|
|
int xfs_blockgc_free_space(struct xfs_mount *mp, struct xfs_icwalk *icm);
|
|
int xfs_blockgc_flush_all(struct xfs_mount *mp);
|
|
|
|
void xfs_inode_set_eofblocks_tag(struct xfs_inode *ip);
|
|
void xfs_inode_clear_eofblocks_tag(struct xfs_inode *ip);
|
|
|
|
void xfs_inode_set_cowblocks_tag(struct xfs_inode *ip);
|
|
void xfs_inode_clear_cowblocks_tag(struct xfs_inode *ip);
|
|
|
|
void xfs_blockgc_worker(struct work_struct *work);
|
|
|
|
int xfs_icache_inode_is_allocated(struct xfs_mount *mp, struct xfs_trans *tp,
|
|
xfs_ino_t ino, bool *inuse);
|
|
|
|
void xfs_blockgc_stop(struct xfs_mount *mp);
|
|
void xfs_blockgc_start(struct xfs_mount *mp);
|
|
|
|
void xfs_inodegc_worker(struct work_struct *work);
|
|
void xfs_inodegc_push(struct xfs_mount *mp);
|
|
int xfs_inodegc_flush(struct xfs_mount *mp);
|
|
void xfs_inodegc_stop(struct xfs_mount *mp);
|
|
void xfs_inodegc_start(struct xfs_mount *mp);
|
|
void xfs_inodegc_cpu_dead(struct xfs_mount *mp, unsigned int cpu);
|
|
int xfs_inodegc_register_shrinker(struct xfs_mount *mp);
|
|
|
|
#endif
|