94dfc73e7c
There is a regular need in the kernel to provide a way to declare
having a dynamically sized set of trailing elements in a structure.
Kernel code should always use “flexible array members”[1] for these
cases. The older style of one-element or zero-length arrays should
no longer be used[2].
This code was transformed with the help of Coccinelle:
(linux-5.19-rc2$ spatch --jobs $(getconf _NPROCESSORS_ONLN) --sp-file script.cocci --include-headers --dir . > output.patch)
@@
identifier S, member, array;
type T1, T2;
@@
struct S {
...
T1 member;
T2 array[
- 0
];
};
-fstrict-flex-arrays=3 is coming and we need to land these changes
to prevent issues like these in the short future:
../fs/minix/dir.c:337:3: warning: 'strcpy' will always overflow; destination buffer has size 0,
but the source string has length 2 (including NUL byte) [-Wfortify-source]
strcpy(de3->name, ".");
^
Since these are all [0] to [] changes, the risk to UAPI is nearly zero. If
this breaks anything, we can use a union with a new member name.
[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays
Link: https://github.com/KSPP/linux/issues/78
Build-tested-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/lkml/62b675ec.wKX6AOZ6cbE71vtF%25lkp@intel.com/
Acked-by: Dan Williams <dan.j.williams@intel.com> # For ndctl.h
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
88 lines
2.6 KiB
C
88 lines
2.6 KiB
C
/*
|
|
* Copyright (c) 2018, Mellanox Technologies inc. All rights reserved.
|
|
*
|
|
* This software is available to you under a choice of one of two
|
|
* licenses. You may choose to be licensed under the terms of the GNU
|
|
* General Public License (GPL) Version 2, available from the file
|
|
* COPYING in the main directory of this source tree, or the
|
|
* OpenIB.org BSD license below:
|
|
*
|
|
* Redistribution and use in source and binary forms, with or
|
|
* without modification, are permitted provided that the following
|
|
* conditions are met:
|
|
*
|
|
* - Redistributions of source code must retain the above
|
|
* copyright notice, this list of conditions and the following
|
|
* disclaimer.
|
|
*
|
|
* - Redistributions in binary form must reproduce the above
|
|
* copyright notice, this list of conditions and the following
|
|
* disclaimer in the documentation and/or other materials
|
|
* provided with the distribution.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
|
|
* BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
|
|
* ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
|
|
* CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
|
|
* SOFTWARE.
|
|
*/
|
|
|
|
#ifndef RDMA_USER_IOCTL_CMDS_H
|
|
#define RDMA_USER_IOCTL_CMDS_H
|
|
|
|
#include <linux/types.h>
|
|
#include <linux/ioctl.h>
|
|
|
|
/* Documentation/userspace-api/ioctl/ioctl-number.rst */
|
|
#define RDMA_IOCTL_MAGIC 0x1b
|
|
#define RDMA_VERBS_IOCTL \
|
|
_IOWR(RDMA_IOCTL_MAGIC, 1, struct ib_uverbs_ioctl_hdr)
|
|
|
|
enum {
|
|
/* User input */
|
|
UVERBS_ATTR_F_MANDATORY = 1U << 0,
|
|
/*
|
|
* Valid output bit should be ignored and considered set in
|
|
* mandatory fields. This bit is kernel output.
|
|
*/
|
|
UVERBS_ATTR_F_VALID_OUTPUT = 1U << 1,
|
|
};
|
|
|
|
struct ib_uverbs_attr {
|
|
__u16 attr_id; /* command specific type attribute */
|
|
__u16 len; /* only for pointers and IDRs array */
|
|
__u16 flags; /* combination of UVERBS_ATTR_F_XXXX */
|
|
union {
|
|
struct {
|
|
__u8 elem_id;
|
|
__u8 reserved;
|
|
} enum_data;
|
|
__u16 reserved;
|
|
} attr_data;
|
|
union {
|
|
/*
|
|
* ptr to command, inline data, idr/fd or
|
|
* ptr to __u32 array of IDRs
|
|
*/
|
|
__aligned_u64 data;
|
|
/* Used by FD_IN and FD_OUT */
|
|
__s64 data_s64;
|
|
};
|
|
};
|
|
|
|
struct ib_uverbs_ioctl_hdr {
|
|
__u16 length;
|
|
__u16 object_id;
|
|
__u16 method_id;
|
|
__u16 num_attrs;
|
|
__aligned_u64 reserved1;
|
|
__u32 driver_id;
|
|
__u32 reserved2;
|
|
struct ib_uverbs_attr attrs[];
|
|
};
|
|
|
|
#endif
|