iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/fs
History
Liangyan 307aa80243 ovl: fix dentry leak in ovl_get_redirect 
commit e04527fefba6e4e66492f122cf8cc6314f3cf3bf upstream.

We need to lock d_parent->d_lock before dget_dlock, or this may
have d_lockref updated parallelly like calltrace below which will
cause dentry->d_lockref leak and risk a crash.

     CPU 0                                CPU 1
ovl_set_redirect                       lookup_fast
  ovl_get_redirect                       __d_lookup
    dget_dlock
      //no lock protection here            spin_lock(&dentry->d_lock)
      dentry->d_lockref.count++            dentry->d_lockref.count++

[   49.799059] PGD 800000061fed7067 P4D 800000061fed7067 PUD 61fec5067 PMD 0
[   49.799689] Oops: 0002 [#1] SMP PTI
[   49.800019] CPU: 2 PID: 2332 Comm: node Not tainted 4.19.24-7.20.al7.x86_64 #1
[   49.800678] Hardware name: Alibaba Cloud Alibaba Cloud ECS, BIOS 8a46cfe 04/01/2014
[   49.801380] RIP: 0010:_raw_spin_lock+0xc/0x20
[   49.803470] RSP: 0018:ffffac6fc5417e98 EFLAGS: 00010246
[   49.803949] RAX: 0000000000000000 RBX: ffff93b8da3446c0 RCX: 0000000a00000000
[   49.804600] RDX: 0000000000000001 RSI: 000000000000000a RDI: 0000000000000088
[   49.805252] RBP: 0000000000000000 R08: 0000000000000000 R09: ffffffff993cf040
[   49.805898] R10: ffff93b92292e580 R11: ffffd27f188a4b80 R12: 0000000000000000
[   49.806548] R13: 00000000ffffff9c R14: 00000000fffffffe R15: ffff93b8da3446c0
[   49.807200] FS:  00007ffbedffb700(0000) GS:ffff93b927880000(0000) knlGS:0000000000000000
[   49.807935] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[   49.808461] CR2: 0000000000000088 CR3: 00000005e3f74006 CR4: 00000000003606a0
[   49.809113] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[   49.809758] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[   49.810410] Call Trace:
[   49.810653]  d_delete+0x2c/0xb0
[   49.810951]  vfs_rmdir+0xfd/0x120
[   49.811264]  do_rmdir+0x14f/0x1a0
[   49.811573]  do_syscall_64+0x5b/0x190
[   49.811917]  entry_SYSCALL_64_after_hwframe+0x44/0xa9
[   49.812385] RIP: 0033:0x7ffbf505ffd7
[   49.814404] RSP: 002b:00007ffbedffada8 EFLAGS: 00000297 ORIG_RAX: 0000000000000054
[   49.815098] RAX: ffffffffffffffda RBX: 00007ffbedffb640 RCX: 00007ffbf505ffd7
[   49.815744] RDX: 0000000004449700 RSI: 0000000000000000 RDI: 0000000006c8cd50
[   49.816394] RBP: 00007ffbedffaea0 R08: 0000000000000000 R09: 0000000000017d0b
[   49.817038] R10: 0000000000000000 R11: 0000000000000297 R12: 0000000000000012
[   49.817687] R13: 00000000072823d8 R14: 00007ffbedffb700 R15: 00000000072823d8
[   49.818338] Modules linked in: pvpanic cirrusfb button qemu_fw_cfg atkbd libps2 i8042
[   49.819052] CR2: 0000000000000088
[   49.819368] ---[ end trace 4e652b8aa299aa2d ]---
[   49.819796] RIP: 0010:_raw_spin_lock+0xc/0x20
[   49.821880] RSP: 0018:ffffac6fc5417e98 EFLAGS: 00010246
[   49.822363] RAX: 0000000000000000 RBX: ffff93b8da3446c0 RCX: 0000000a00000000
[   49.823008] RDX: 0000000000000001 RSI: 000000000000000a RDI: 0000000000000088
[   49.823658] RBP: 0000000000000000 R08: 0000000000000000 R09: ffffffff993cf040
[   49.825404] R10: ffff93b92292e580 R11: ffffd27f188a4b80 R12: 0000000000000000
[   49.827147] R13: 00000000ffffff9c R14: 00000000fffffffe R15: ffff93b8da3446c0
[   49.828890] FS:  00007ffbedffb700(0000) GS:ffff93b927880000(0000) knlGS:0000000000000000
[   49.830725] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[   49.832359] CR2: 0000000000000088 CR3: 00000005e3f74006 CR4: 00000000003606a0
[   49.834085] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[   49.835792] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400

Cc: <stable@vger.kernel.org>
Fixes: a6c606551141 ("ovl: redirect on rename-dir")
Signed-off-by: Liangyan <liangyan.peng@linux.alibaba.com>
Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com>
Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-02-10 09:21:07 +01:00
..
9p
9P: Cast to loff_t before multiplying
2020-11-05 11:08:53 +01:00
adfs
fs/adfs: super: fix use-after-free bug
2019-08-06 19:06:49 +02:00
affs
affs: fix basic permission bits to actually work
2020-09-09 19:04:30 +02:00
afs
rxrpc: Fix deadlock around release of dst cached on udp tunnel
2021-02-10 09:21:06 +01:00
autofs
autofs: fix a leak in autofs_expire_indirect()
2019-12-13 08:51:01 +01:00
befs
…
bfs
bfs: add sanity check at bfs_fill_super()
2018-12-01 09:37:27 +01:00
btrfs
btrfs: fix lockdep splat in btrfs_recover_relocation
2021-01-27 11:05:35 +01:00
cachefiles
cachefiles: Handle readpage error correctly
2020-11-05 11:08:54 +01:00
ceph
ceph: fix race in concurrent __ceph_remove_cap invocations
2020-12-30 11:26:13 +01:00
cifs
SMB3.1.1: do not log warning message if server doesn't populate salt
2020-12-30 11:26:13 +01:00
coda
coda: add error handling for fget
2019-08-06 19:06:51 +02:00
configfs
configfs: fix config_item refcnt leak in configfs_rmdir()
2020-05-27 17:37:32 +02:00
cramfs
Cramfs: fix abad comparison when wrap-arounds occur
2018-11-13 11:08:55 -08:00
crypto
fscrypt: add fscrypt_is_nokey_name()
2021-01-06 14:44:58 +01:00
debugfs
debugfs: fix use-after-free on symlink traversal
2019-05-08 07:21:48 +02:00
devpts
fs/devpts: always delete dcache dentry-s in dput()
2019-03-23 20:09:59 +01:00
dlm
fs: dlm: fix configfs memory leak
2020-10-30 10:38:28 +01:00
ecryptfs
ecryptfs: replace BUG_ON with error handling code
2020-02-28 16:38:59 +01:00
efivarfs
efivarfs: revert "fix memory leak in efivarfs_create()"
2020-12-02 08:48:12 +01:00
efs
…
exofs
exofs_mount(): fix leaks on failure exits
2019-12-05 09:20:32 +01:00
exportfs
exportfs: fix 'passing zero to ERR_PTR()' warning
2020-01-27 14:50:02 +01:00
ext2
ext2: don't update mtime on COW faults
2020-09-09 19:04:28 +02:00
ext4
writeback: Drop I_DIRTY_TIME_EXPIRE
2021-01-30 13:32:13 +01:00
f2fs
f2fs: prevent creating duplicate encrypted filenames
2021-01-06 14:44:58 +01:00
fat
fat: don't allow to mount if the FAT length == 0
2020-06-22 09:05:08 +02:00
freevxfs
…
fscache
fscache: fix race between enablement and dropping of object
2018-12-17 09:24:40 +01:00
fuse
fuse: fix page dereference after free
2020-11-05 11:08:34 +01:00
gfs2
gfs2: check for empty rgrp tree in gfs2_ri_update
2020-12-11 13:25:04 +01:00
hfs
fs/hfs/extent.c: fix array out of bounds read of array extent
2019-12-01 09:17:10 +01:00
hfsplus
hfsplus: fix crash and filesystem corruption when deleting files
2020-04-17 10:48:52 +02:00
hostfs
vfs: discard ATTR_ATTR_FLAG
2018-08-17 16:20:28 -07:00
hpfs
hpfs: remove unnecessary checks on the value of r when assigning error code
2018-08-25 12:42:33 -07:00
hugetlbfs
hugetlb: use same fault hash key for shared and private mappings
2019-05-22 07:37:40 +02:00
isofs
isofs: reject hardware sector size > 2048 bytes
2018-08-21 11:37:41 +02:00
jbd2
jbd2: abort journal if free a async write error metadata buffer
2020-09-03 11:24:24 +02:00
jffs2
jffs2: Fix GC exit abnormally
2020-12-30 11:26:13 +01:00
jfs
jfs: Fix array index bounds check in dbAdjTree
2020-12-30 11:26:13 +01:00
kernfs
kernfs: fix ino wrap-around detection
2019-12-13 08:52:43 +01:00
lockd
lockd: don't use interval-based rebinding over TCP
2020-12-30 11:25:59 +01:00
minix
fs/minix: remove expected error message in block_to_path()
2020-08-21 11:05:38 +02:00
nfs
pNFS/NFSv4: Fix a layout segment leak in pnfs_layout_process()
2021-02-03 23:23:26 +01:00
nfs_common
nfs_common: need lock during iterate through the list
2020-12-30 11:26:02 +01:00
nfsd
nfsd4: readdirplus shouldn't return parent of export
2021-01-23 15:49:55 +01:00
nilfs2
nilfs2: fix null pointer dereference at nilfs_segctor_do_construct()
2020-06-22 09:05:03 +02:00
nls
…
notify
fanotify: fix ignore mask logic for events on child and on dir
2020-06-30 23:17:00 -04:00
ntfs
ntfs: add check for mft record size in superblock
2020-10-30 10:38:28 +01:00
ocfs2
ocfs2: initialize ip_next_orphan
2020-11-18 19:18:49 +01:00
omfs
…
openpromfs
…
orangefs
help_next should increase position index
2020-02-24 08:34:53 +01:00
overlayfs
ovl: fix dentry leak in ovl_get_redirect
2021-02-10 09:21:07 +01:00
proc
proc: fix lookup in /proc/net subdirectories after setns(2)
2021-01-12 20:10:17 +01:00
pstore
pstore: Fix linking when crypto API disabled
2020-08-19 08:15:04 +02:00
qnx4
…
qnx6
…
quota
quota: Don't overflow quota file offsets
2021-01-06 14:45:01 +01:00
ramfs
ramfs: fix nommu mmap with gaps in the page cache
2020-10-30 10:38:21 +01:00
reiserfs
reiserfs: add check for an invalid ih_entry_count
2021-01-06 14:45:00 +01:00
romfs
romfs: fix uninitialized memory leak in romfs_dev_read()
2020-08-26 10:30:59 +02:00
squashfs
…
sysfs
Driver core patches for 4.19-rc1
2018-08-18 11:44:53 -07:00
sysv
sysv: return 'err' instead of 0 in __sysv_write_inode
2018-12-17 09:24:30 +01:00
tracefs
…
ubifs
ubifs: prevent creating duplicate encrypted filenames
2021-01-06 14:44:59 +01:00
udf
udf: Fix memory leak when mounting
2020-11-05 11:08:50 +01:00
ufs
fs/ufs: avoid potential u32 multiplication overflow
2020-08-21 11:05:38 +02:00
xfs
writeback: Drop I_DIRTY_TIME_EXPIRE
2021-01-30 13:32:13 +01:00
aio.c
aio: fix async fsync creds
2020-06-22 09:05:01 +02:00
anon_inodes.c
…
attr.c
…
bad_inode.c
…
binfmt_aout.c
…
binfmt_elf_fdpic.c
…
binfmt_elf.c
fs/binfmt_elf.c: allocate initialized memory in fill_thread_core_info()
2020-06-03 08:19:41 +02:00
binfmt_em86.c
…
binfmt_flat.c
fs/binfmt_flat.c: make load_flat_shared_library() work
2019-07-03 13:14:44 +02:00
binfmt_misc.c
…
binfmt_script.c
exec: load_script: Do not exec truncated interpreter path
2019-11-06 13:05:37 +01:00
block_dev.c
bdev: Reduce time holding bd_mutex in sync in blkdev_close()
2020-10-01 13:14:42 +02:00
buffer.c
fs: Don't invalidate page buffers in block_write_full_page()
2020-11-05 11:08:46 +01:00
char_dev.c
chardev: Avoid potential use-after-free in 'chrdev_open()'
2020-01-14 20:06:57 +01:00
compat_binfmt_elf.c
…
compat_ioctl.c
fix compat handling of FICLONERANGE, FIDEDUPERANGE and FS_IOC_FIEMAP
2020-01-09 10:19:07 +01:00
compat.c
…
coredump.c
coredump: fix crash when umh is disabled
2020-05-14 07:57:21 +02:00
d_path.c
…
dax.c
dax: pass NOWAIT flag to iomap_apply
2020-03-05 16:42:12 +01:00
dcache.c
fs, fscrypt: clear DCACHE_ENCRYPTED_NAME when unaliasing directory
2020-11-05 11:08:35 +01:00
dcookies.c
…
direct-io.c
direct-io: allow direct writes to empty inodes
2019-03-05 17:58:50 +01:00
drop_caches.c
fs: avoid softlockups in s_inodes iterators
2020-01-12 12:17:20 +01:00
eventfd.c
eventfd: track eventfd_signal() recursion depth
2020-02-11 04:34:08 -08:00
eventpoll.c
ep_create_wakeup_source(): dentry name can change under you...
2020-10-07 08:00:09 +02:00
exec.c
exit/exec: Seperate mm_release()
2021-01-30 13:32:11 +01:00
fcntl.c
fcntl: Fix potential deadlock in send_sig{io, urg}()
2021-01-06 14:45:00 +01:00
fhandle.c
…
file_table.c
overlayfs update for 4.19
2018-08-21 18:19:09 -07:00
file.c
fix multiplication overflow in copy_fdtable()
2020-05-27 17:37:29 +02:00
filesystems.c
fs/filesystems.c: downgrade user-reachable WARN_ONCE() to pr_warn_once()
2020-04-17 10:48:51 +02:00
fs_pin.c
…
fs_struct.c
…
fs-writeback.c
fs: fix lazytime expiration handling in __writeback_single_inode()
2021-01-30 13:32:13 +01:00
inode.c
futex: Fix inode life-time issue
2020-03-25 08:06:14 +01:00
internal.h
acct_on(): don't mess with freeze protection
2019-05-31 06:46:05 -07:00
ioctl.c
vfs: fix FIGETBSZ ioctl on an overlayfs file
2018-11-21 09:19:14 +01:00
iomap.c
iomap: partially revert 4721a601099 (simulated directio short read on EFAULT)
2019-12-13 08:52:56 +01:00
Kconfig
…
Kconfig.binfmt
…
libfs.c
libfs: fix error cast of negative value in simple_attr_write()
2020-11-24 13:27:23 +01:00
locks.c
locks: print unsigned ino in /proc/locks
2020-01-09 10:19:00 +01:00
Makefile
…
mbcache.c
…
mount.h
…
mpage.c
mpage: mpage_readpages() should submit IO as read-ahead
2018-08-17 16:20:29 -07:00
namei.c
namei: only return -ECHILD from follow_dotdot_rcu()
2020-03-05 16:42:20 +01:00
namespace.c
fs/namespace.c: fix mountpoint reference counter race
2020-04-29 16:31:26 +02:00
no-block.c
…
nsfs.c
dcache: sort the freeing-without-RCU-delay mess for good.
2019-05-25 18:23:26 +02:00
open.c
cifs_atomic_open(): fix double-put on late allocation failure
2020-03-18 07:14:21 +01:00
pipe.c
fs: prevent page refcount overflow in pipe_buf_get
2019-05-04 09:20:11 +02:00
pnode.c
propagate_one(): mnt_set_mountpoint() needs mount_lock
2020-05-02 17:26:01 +02:00
pnode.h
…
posix_acl.c
…
proc_namespace.c
…
read_write.c
vfs: avoid problematic remapping requests into partial EOF block
2019-12-01 09:17:04 +01:00
readdir.c
filldir[64]: remove WARN_ON_ONCE() for bad directory entries
2020-01-04 19:13:26 +01:00
select.c
…
seq_file.c
seq_file: fix problem when seeking mid-record
2019-08-25 10:47:43 +02:00
signalfd.c
fs/signalfd.c: fix inconsistent return codes for signalfd4
2020-08-26 10:31:02 +02:00
splice.c
splice: only read in as much information as there is pipe buffer space
2019-12-17 20:35:43 +01:00
stack.c
…
stat.c
…
statfs.c
vfs: Fix EOVERFLOW testing in put_compat_statfs64
2019-10-11 18:21:39 +02:00
super.c
vfs: remove lockdep bogosity in __sb_start_write
2020-11-24 13:27:20 +01:00
sync.c
…
timerfd.c
Merge branch 'work.aio' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2018-08-13 20:56:23 -07:00
userfaultfd.c
userfaultfd: require CAP_SYS_PTRACE for UFFD_FEATURE_EVENT_FORK
2020-01-04 19:13:18 +01:00
utimes.c
…
xattr.c
xattr: break delegations in {set,remove}xattr
2020-08-11 15:32:34 +02:00