3ab5872df9
perf may fail to build in v4.19.y with the following error.
util/evsel.c: In function ‘perf_evsel__exit’:
util/util.h:25:28: error:
passing argument 1 of ‘free’ discards ‘const’ qualifier from pointer target type
This is observed (at least) with gcc v6.5.0. The underlying problem is
the following statement.
zfree(&evsel->pmu_name);
evsel->pmu_name is decared 'const *'. zfree in turn is defined as
#define zfree(ptr) ({ free(*ptr); *ptr = NULL; })
and thus passes the const * to free(). The problem is not seen
in the upstream kernel since zfree() has been rewritten there.
The problem has been introduced into v4.19.y with the backport of upstream
commit d4953f7ef1a2 (perf parse-events: Fix 3 use after frees found with
clang ASAN).
One possible fix of this problem would be to not declare pmu_name
as const. This patch chooses to typecast the parameter of zfree()
to void *, following the guidance from the upstream kernel which
does the same since commit 7f7c536f23e6a ("tools lib: Adopt
zalloc()/zfree() from tools/perf")
Fixes: a0100a363098 ("perf parse-events: Fix 3 use after frees found with clang ASAN")
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
84 lines
2.1 KiB
C
84 lines
2.1 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef GIT_COMPAT_UTIL_H
|
|
#define GIT_COMPAT_UTIL_H
|
|
|
|
#define _BSD_SOURCE 1
|
|
/* glibc 2.20 deprecates _BSD_SOURCE in favour of _DEFAULT_SOURCE */
|
|
#define _DEFAULT_SOURCE 1
|
|
|
|
#include <stdbool.h>
|
|
#include <stddef.h>
|
|
#include <stdlib.h>
|
|
#include <stdarg.h>
|
|
#include <linux/compiler.h>
|
|
#include <sys/types.h>
|
|
|
|
/* General helper functions */
|
|
void usage(const char *err) __noreturn;
|
|
void die(const char *err, ...) __noreturn __printf(1, 2);
|
|
|
|
static inline void *zalloc(size_t size)
|
|
{
|
|
return calloc(1, size);
|
|
}
|
|
|
|
#define zfree(ptr) ({ free((void *)*ptr); *ptr = NULL; })
|
|
|
|
struct dirent;
|
|
struct nsinfo;
|
|
struct strlist;
|
|
|
|
int mkdir_p(char *path, mode_t mode);
|
|
int rm_rf(const char *path);
|
|
struct strlist *lsdir(const char *name, bool (*filter)(const char *, struct dirent *));
|
|
bool lsdir_no_dot_filter(const char *name, struct dirent *d);
|
|
int copyfile(const char *from, const char *to);
|
|
int copyfile_mode(const char *from, const char *to, mode_t mode);
|
|
int copyfile_ns(const char *from, const char *to, struct nsinfo *nsi);
|
|
|
|
ssize_t readn(int fd, void *buf, size_t n);
|
|
ssize_t writen(int fd, const void *buf, size_t n);
|
|
|
|
size_t hex_width(u64 v);
|
|
int hex2u64(const char *ptr, u64 *val);
|
|
|
|
extern unsigned int page_size;
|
|
int __pure cacheline_size(void);
|
|
|
|
int sysctl__max_stack(void);
|
|
|
|
int fetch_kernel_version(unsigned int *puint,
|
|
char *str, size_t str_sz);
|
|
#define KVER_VERSION(x) (((x) >> 16) & 0xff)
|
|
#define KVER_PATCHLEVEL(x) (((x) >> 8) & 0xff)
|
|
#define KVER_SUBLEVEL(x) ((x) & 0xff)
|
|
#define KVER_FMT "%d.%d.%d"
|
|
#define KVER_PARAM(x) KVER_VERSION(x), KVER_PATCHLEVEL(x), KVER_SUBLEVEL(x)
|
|
|
|
const char *perf_tip(const char *dirpath);
|
|
|
|
#ifndef HAVE_SCHED_GETCPU_SUPPORT
|
|
int sched_getcpu(void);
|
|
#endif
|
|
|
|
#ifndef HAVE_SETNS_SUPPORT
|
|
int setns(int fd, int nstype);
|
|
#endif
|
|
|
|
extern bool perf_singlethreaded;
|
|
|
|
void perf_set_singlethreaded(void);
|
|
void perf_set_multithreaded(void);
|
|
|
|
#ifndef O_CLOEXEC
|
|
#ifdef __sparc__
|
|
#define O_CLOEXEC 0x400000
|
|
#elif defined(__alpha__) || defined(__hppa__)
|
|
#define O_CLOEXEC 010000000
|
|
#else
|
|
#define O_CLOEXEC 02000000
|
|
#endif
|
|
#endif
|
|
|
|
#endif /* GIT_COMPAT_UTIL_H */
|