Tom Rix f4544e5361 net: mvneta: fix double free of txq->buf
clang static analysis reports this problem:

drivers/net/ethernet/marvell/mvneta.c:3465:2: warning:
  Attempt to free released memory
        kfree(txq->buf);
        ^~~~~~~~~~~~~~~

When mvneta_txq_sw_init() fails to alloc txq->tso_hdrs,
it frees without poisoning txq->buf.  The error is caught
in the mvneta_setup_txqs() caller which handles the error
by cleaning up all of the txqs with a call to
mvneta_txq_sw_deinit which also frees txq->buf.

Since mvneta_txq_sw_deinit is a general cleaner, all of the
partial cleaning in mvneta_txq_sw_deinit()'s error handling
is not needed.

Fixes: 2adb719d74f6 ("net: mvneta: Implement software TSO")
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2020-10-04 15:07:19 -07:00
..
2020-09-04 13:19:19 -07:00
2020-09-13 09:02:59 -07:00
2020-08-02 18:26:51 +03:00
2020-09-18 11:48:25 -07:00
2020-09-04 12:12:39 -07:00
2020-09-20 15:18:11 -07:00
2020-07-27 11:49:37 +02:00
2020-09-18 08:52:06 +10:00
2020-09-15 16:20:43 -07:00
2020-08-29 12:37:00 -07:00
2020-08-05 19:24:27 -07:00
2020-09-03 08:22:16 -07:00
2020-08-28 10:15:33 -07:00
2020-09-13 08:52:21 -07:00
2020-09-04 12:41:55 +02:00
2020-08-14 16:00:09 -07:00
2020-09-11 11:25:55 -07:00
2020-09-11 11:35:55 -07:00
2020-09-08 11:42:58 -07:00
2020-09-15 13:52:14 +02:00
2020-09-20 10:46:26 -07:00
2020-09-06 09:59:27 -07:00