iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net/ipv6
History
Eric Dumazet 4b397c06cb net: tunnels: annotate lockless accesses to dev->needed_headroom 
IP tunnels can apparently update dev->needed_headroom
in their xmit path.

This patch takes care of three tunnels xmit, and also the
core LL_RESERVED_SPACE() and LL_RESERVED_SPACE_EXTRA()
helpers.

More changes might be needed for completeness.

BUG: KCSAN: data-race in ip_tunnel_xmit / ip_tunnel_xmit

read to 0xffff88815b9da0ec of 2 bytes by task 888 on cpu 1:
ip_tunnel_xmit+0x1270/0x1730 net/ipv4/ip_tunnel.c:803
__gre_xmit net/ipv4/ip_gre.c:469 [inline]
ipgre_xmit+0x516/0x570 net/ipv4/ip_gre.c:661
__netdev_start_xmit include/linux/netdevice.h:4881 [inline]
netdev_start_xmit include/linux/netdevice.h:4895 [inline]
xmit_one net/core/dev.c:3580 [inline]
dev_hard_start_xmit+0x127/0x400 net/core/dev.c:3596
__dev_queue_xmit+0x1007/0x1eb0 net/core/dev.c:4246
dev_queue_xmit include/linux/netdevice.h:3051 [inline]
neigh_direct_output+0x17/0x20 net/core/neighbour.c:1623
neigh_output include/net/neighbour.h:546 [inline]
ip_finish_output2+0x740/0x840 net/ipv4/ip_output.c:228
ip_finish_output+0xf4/0x240 net/ipv4/ip_output.c:316
NF_HOOK_COND include/linux/netfilter.h:291 [inline]
ip_output+0xe5/0x1b0 net/ipv4/ip_output.c:430
dst_output include/net/dst.h:444 [inline]
ip_local_out+0x64/0x80 net/ipv4/ip_output.c:126
iptunnel_xmit+0x34a/0x4b0 net/ipv4/ip_tunnel_core.c:82
ip_tunnel_xmit+0x1451/0x1730 net/ipv4/ip_tunnel.c:813
__gre_xmit net/ipv4/ip_gre.c:469 [inline]
ipgre_xmit+0x516/0x570 net/ipv4/ip_gre.c:661
__netdev_start_xmit include/linux/netdevice.h:4881 [inline]
netdev_start_xmit include/linux/netdevice.h:4895 [inline]
xmit_one net/core/dev.c:3580 [inline]
dev_hard_start_xmit+0x127/0x400 net/core/dev.c:3596
__dev_queue_xmit+0x1007/0x1eb0 net/core/dev.c:4246
dev_queue_xmit include/linux/netdevice.h:3051 [inline]
neigh_direct_output+0x17/0x20 net/core/neighbour.c:1623
neigh_output include/net/neighbour.h:546 [inline]
ip_finish_output2+0x740/0x840 net/ipv4/ip_output.c:228
ip_finish_output+0xf4/0x240 net/ipv4/ip_output.c:316
NF_HOOK_COND include/linux/netfilter.h:291 [inline]
ip_output+0xe5/0x1b0 net/ipv4/ip_output.c:430
dst_output include/net/dst.h:444 [inline]
ip_local_out+0x64/0x80 net/ipv4/ip_output.c:126
iptunnel_xmit+0x34a/0x4b0 net/ipv4/ip_tunnel_core.c:82
ip_tunnel_xmit+0x1451/0x1730 net/ipv4/ip_tunnel.c:813
__gre_xmit net/ipv4/ip_gre.c:469 [inline]
ipgre_xmit+0x516/0x570 net/ipv4/ip_gre.c:661
__netdev_start_xmit include/linux/netdevice.h:4881 [inline]
netdev_start_xmit include/linux/netdevice.h:4895 [inline]
xmit_one net/core/dev.c:3580 [inline]
dev_hard_start_xmit+0x127/0x400 net/core/dev.c:3596
__dev_queue_xmit+0x1007/0x1eb0 net/core/dev.c:4246
dev_queue_xmit include/linux/netdevice.h:3051 [inline]
neigh_direct_output+0x17/0x20 net/core/neighbour.c:1623
neigh_output include/net/neighbour.h:546 [inline]
ip_finish_output2+0x740/0x840 net/ipv4/ip_output.c:228
ip_finish_output+0xf4/0x240 net/ipv4/ip_output.c:316
NF_HOOK_COND include/linux/netfilter.h:291 [inline]
ip_output+0xe5/0x1b0 net/ipv4/ip_output.c:430
dst_output include/net/dst.h:444 [inline]
ip_local_out+0x64/0x80 net/ipv4/ip_output.c:126
iptunnel_xmit+0x34a/0x4b0 net/ipv4/ip_tunnel_core.c:82
ip_tunnel_xmit+0x1451/0x1730 net/ipv4/ip_tunnel.c:813
__gre_xmit net/ipv4/ip_gre.c:469 [inline]
ipgre_xmit+0x516/0x570 net/ipv4/ip_gre.c:661
__netdev_start_xmit include/linux/netdevice.h:4881 [inline]
netdev_start_xmit include/linux/netdevice.h:4895 [inline]
xmit_one net/core/dev.c:3580 [inline]
dev_hard_start_xmit+0x127/0x400 net/core/dev.c:3596
__dev_queue_xmit+0x1007/0x1eb0 net/core/dev.c:4246
dev_queue_xmit include/linux/netdevice.h:3051 [inline]
neigh_direct_output+0x17/0x20 net/core/neighbour.c:1623
neigh_output include/net/neighbour.h:546 [inline]
ip_finish_output2+0x740/0x840 net/ipv4/ip_output.c:228
ip_finish_output+0xf4/0x240 net/ipv4/ip_output.c:316
NF_HOOK_COND include/linux/netfilter.h:291 [inline]
ip_output+0xe5/0x1b0 net/ipv4/ip_output.c:430
dst_output include/net/dst.h:444 [inline]
ip_local_out+0x64/0x80 net/ipv4/ip_output.c:126
iptunnel_xmit+0x34a/0x4b0 net/ipv4/ip_tunnel_core.c:82
ip_tunnel_xmit+0x1451/0x1730 net/ipv4/ip_tunnel.c:813
__gre_xmit net/ipv4/ip_gre.c:469 [inline]
ipgre_xmit+0x516/0x570 net/ipv4/ip_gre.c:661
__netdev_start_xmit include/linux/netdevice.h:4881 [inline]
netdev_start_xmit include/linux/netdevice.h:4895 [inline]
xmit_one net/core/dev.c:3580 [inline]
dev_hard_start_xmit+0x127/0x400 net/core/dev.c:3596
__dev_queue_xmit+0x1007/0x1eb0 net/core/dev.c:4246
dev_queue_xmit include/linux/netdevice.h:3051 [inline]
neigh_direct_output+0x17/0x20 net/core/neighbour.c:1623
neigh_output include/net/neighbour.h:546 [inline]
ip_finish_output2+0x740/0x840 net/ipv4/ip_output.c:228
ip_finish_output+0xf4/0x240 net/ipv4/ip_output.c:316
NF_HOOK_COND include/linux/netfilter.h:291 [inline]
ip_output+0xe5/0x1b0 net/ipv4/ip_output.c:430
dst_output include/net/dst.h:444 [inline]
ip_local_out+0x64/0x80 net/ipv4/ip_output.c:126
iptunnel_xmit+0x34a/0x4b0 net/ipv4/ip_tunnel_core.c:82
ip_tunnel_xmit+0x1451/0x1730 net/ipv4/ip_tunnel.c:813
__gre_xmit net/ipv4/ip_gre.c:469 [inline]
ipgre_xmit+0x516/0x570 net/ipv4/ip_gre.c:661
__netdev_start_xmit include/linux/netdevice.h:4881 [inline]
netdev_start_xmit include/linux/netdevice.h:4895 [inline]
xmit_one net/core/dev.c:3580 [inline]
dev_hard_start_xmit+0x127/0x400 net/core/dev.c:3596
__dev_queue_xmit+0x1007/0x1eb0 net/core/dev.c:4246
dev_queue_xmit include/linux/netdevice.h:3051 [inline]
neigh_direct_output+0x17/0x20 net/core/neighbour.c:1623
neigh_output include/net/neighbour.h:546 [inline]
ip_finish_output2+0x740/0x840 net/ipv4/ip_output.c:228
ip_finish_output+0xf4/0x240 net/ipv4/ip_output.c:316
NF_HOOK_COND include/linux/netfilter.h:291 [inline]
ip_output+0xe5/0x1b0 net/ipv4/ip_output.c:430
dst_output include/net/dst.h:444 [inline]
ip_local_out+0x64/0x80 net/ipv4/ip_output.c:126
iptunnel_xmit+0x34a/0x4b0 net/ipv4/ip_tunnel_core.c:82
ip_tunnel_xmit+0x1451/0x1730 net/ipv4/ip_tunnel.c:813
__gre_xmit net/ipv4/ip_gre.c:469 [inline]
ipgre_xmit+0x516/0x570 net/ipv4/ip_gre.c:661
__netdev_start_xmit include/linux/netdevice.h:4881 [inline]
netdev_start_xmit include/linux/netdevice.h:4895 [inline]
xmit_one net/core/dev.c:3580 [inline]
dev_hard_start_xmit+0x127/0x400 net/core/dev.c:3596
__dev_queue_xmit+0x1007/0x1eb0 net/core/dev.c:4246

write to 0xffff88815b9da0ec of 2 bytes by task 2379 on cpu 0:
ip_tunnel_xmit+0x1294/0x1730 net/ipv4/ip_tunnel.c:804
__gre_xmit net/ipv4/ip_gre.c:469 [inline]
ipgre_xmit+0x516/0x570 net/ipv4/ip_gre.c:661
__netdev_start_xmit include/linux/netdevice.h:4881 [inline]
netdev_start_xmit include/linux/netdevice.h:4895 [inline]
xmit_one net/core/dev.c:3580 [inline]
dev_hard_start_xmit+0x127/0x400 net/core/dev.c:3596
__dev_queue_xmit+0x1007/0x1eb0 net/core/dev.c:4246
dev_queue_xmit include/linux/netdevice.h:3051 [inline]
neigh_direct_output+0x17/0x20 net/core/neighbour.c:1623
neigh_output include/net/neighbour.h:546 [inline]
ip6_finish_output2+0x9bc/0xc50 net/ipv6/ip6_output.c:134
__ip6_finish_output net/ipv6/ip6_output.c:195 [inline]
ip6_finish_output+0x39a/0x4e0 net/ipv6/ip6_output.c:206
NF_HOOK_COND include/linux/netfilter.h:291 [inline]
ip6_output+0xeb/0x220 net/ipv6/ip6_output.c:227
dst_output include/net/dst.h:444 [inline]
NF_HOOK include/linux/netfilter.h:302 [inline]
mld_sendpack+0x438/0x6a0 net/ipv6/mcast.c:1820
mld_send_cr net/ipv6/mcast.c:2121 [inline]
mld_ifc_work+0x519/0x7b0 net/ipv6/mcast.c:2653
process_one_work+0x3e6/0x750 kernel/workqueue.c:2390
worker_thread+0x5f2/0xa10 kernel/workqueue.c:2537
kthread+0x1ac/0x1e0 kernel/kthread.c:376
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:308

value changed: 0x0dd4 -> 0x0e14

Reported by Kernel Concurrency Sanitizer on:
CPU: 0 PID: 2379 Comm: kworker/0:0 Not tainted 6.3.0-rc1-syzkaller-00002-g8ca09d5fa354-dirty #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023
Workqueue: mld mld_ifc_work

Fixes: 8eb30be0352d ("ipv6: Create ip6_tnl_xmit")
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/20230310191109.2384387-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2023-03-15 00:04:04 -07:00
..
ila
ila: do not generate empty messages in ila_xlat_nl_cmd_get_mapping()
2023-03-01 08:48:46 +00:00
netfilter
netfilter: tproxy: fix deadlock due to missing BH disable
2023-03-06 12:09:48 +01:00
addrconf_core.c
net: rename reference+tracking helpers
2022-06-09 21:52:55 -07:00
addrconf.c
ip/ip6_gre: Fix non-point-to-point tunnel not generating IPv6 link local address
2023-02-01 19:52:22 -08:00
addrlabel.c
ipv6: addrlabel: fix infoleak when sending struct ifaddrlblmsg to network
2022-11-07 12:26:15 +00:00
af_inet6.c
net: no longer support SOCK_REFCNT_DEBUG feature
2023-02-15 10:25:21 +00:00
ah6.c
net: ipv6: Remove completion function scaffolding
2023-02-13 18:35:15 +08:00
anycast.c
ipv6: fix memory leaks on IPV6_ADDRFORM path
2020-07-30 16:30:55 -07:00
calipso.c
cipso,calipso: resolve a number of problems with the DOI refcounts
2021-03-04 15:26:57 -08:00
datagram.c
ipv6: Fix datagram socket connection with DSCP.
2023-02-09 22:49:04 -08:00
esp6_offload.c
Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next
2022-11-29 20:50:51 -08:00
esp6.c
net: ipv6: Remove completion function scaffolding
2023-02-13 18:35:15 +08:00
exthdrs_core.c
…
exthdrs_offload.c
…
exthdrs.c
net: ipv6: add skb drop reasons to TLV parse
2022-04-13 13:09:57 +01:00
fib6_notifier.c
…
fib6_rules.c
ipv6: change fib6_rules_net_exit() to batch mode
2022-02-08 20:41:34 -08:00
fou6.c
…
icmp.c
ipv6: icmp6: add drop reason support to icmpv6_echo_reply()
2023-02-20 08:54:23 +00:00
inet6_connection_sock.c
lsm,selinux: pass flowi_common instead of flowi to the LSM hooks
2020-11-23 18:36:21 -05:00
inet6_hashtables.c
tcp: Access &tcp_hashinfo via net.
2022-09-20 10:21:49 -07:00
ioam6_iptunnel.c
ipv6: ioam: Insertion frequency in lwtunnel output
2022-02-04 20:24:45 -08:00
ioam6.c
genetlink: start to validate reserved header bytes
2022-08-29 12:47:15 +01:00
ip6_checksum.c
…
ip6_fib.c
ipv6: fib6_new_sernum() optimization
2022-11-16 12:42:00 +00:00
ip6_flowlabel.c
treewide: use get_random_u32() when possible
2022-10-11 17:42:58 -06:00
ip6_gre.c
ipv6: tunnels: use DEV_STATS_INC()
2022-11-16 12:48:44 +00:00
ip6_icmp.c
net: icmp: pass zeroed opts from icmp{,v6}_ndo_send before sending
2021-02-23 11:29:52 -08:00
ip6_input.c
tcp/udp: Make early_demux back namespacified.
2022-07-15 18:50:35 -07:00
ip6_offload.c
IPv6/GRO: generic helper to remove temporary HBH/jumbo header in driver
2022-12-12 15:41:44 -08:00
ip6_offload.h
…
ip6_output.c
ipv6: fix reachability confirmation with proxy_ndp
2023-01-23 11:17:37 +00:00
ip6_tunnel.c
net: tunnels: annotate lockless accesses to dev->needed_headroom
2023-03-15 00:04:04 -07:00
ip6_udp_tunnel.c
…
ip6_vti.c
ipv6: tunnels: use DEV_STATS_INC()
2022-11-16 12:48:44 +00:00
ip6mr.c
treewide: Convert del_timer*() to timer_shutdown*()
2022-12-25 13:38:09 -08:00
ipcomp6.c
xfrm: ipcomp: add extack to ipcomp{4,6}_init_state
2022-09-29 07:18:00 +02:00
ipv6_sockglue.c
net: no longer support SOCK_REFCNT_DEBUG feature
2023-02-15 10:25:21 +00:00
Kconfig
crypto: lib - make the sha1 library optional
2022-07-15 16:43:59 +08:00
Makefile
net: ipv6: use ipv6-y directly instead of ipv6-objs
2021-09-28 13:13:40 +01:00
mcast_snoop.c
net: bridge: mcast: fix broken length + header check for MRDv6 Adv.
2021-04-27 14:02:06 -07:00
mcast.c
treewide: use get_random_u32_below() instead of deprecated function
2022-11-18 02:15:15 +01:00
mip6.c
xfrm: mip6: add extack to mip6_destopt_init_state, mip6_rthdr_init_state
2022-09-29 07:18:01 +02:00
ndisc.c
ipv6: icmp6: add SKB_DROP_REASON_IPV6_NDISC_NS_OTHERHOST
2023-02-20 08:54:23 +00:00
netfilter.c
netfilter: Use l3mdev flow key when re-routing mangled packets
2022-05-16 13:03:29 +02:00
output_core.c
treewide: use get_random_u32_{above,below}() instead of manual loop
2022-11-18 02:15:22 +01:00
ping.c
inet6: Remove inet6_destroy_sock() in sk->sk_prot->destroy().
2022-10-24 09:40:38 +01:00
proc.c
icmp: Add counters for rate limits
2023-01-26 10:52:18 +01:00
protocol.c
…
raw.c
raw: use net_hash_mix() in hash function
2023-02-03 19:56:23 -08:00
reassembly.c
net: dropreason: add SKB_DROP_REASON_DUP_FRAG
2022-10-31 20:14:26 -07:00
route.c
ipv6: Add lwtunnel encap size of all siblings in nexthop calculation
2023-02-23 10:54:13 +01:00
rpl_iptunnel.c
net: ipv6: rpl_iptunnel: Replace 0-length arrays with flexible arrays
2023-01-06 19:28:01 -08:00
rpl.c
net: ipv6: rpl*: Fix strange kerneldoc warnings due to bad header
2020-10-30 12:12:52 -07:00
seg6_hmac.c
net: ipv6: unexport __init-annotated seg6_hmac_net_init()
2022-06-28 21:23:30 -07:00
seg6_iptunnel.c
seg6: add support for SRv6 H.L2Encaps.Red behavior
2022-07-29 12:14:03 +01:00
seg6_local.c
seg6: add PSP flavor support for SRv6 End behavior
2023-02-16 13:18:06 +01:00
seg6.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2022-09-08 18:38:30 +02:00
sit.c
ipv6/sit: use DEV_STATS_INC() to avoid data-races
2022-11-16 12:48:44 +00:00
syncookies.c
tcp: Fix data-races around sysctl_tcp_syncookies.
2022-07-18 12:21:54 +01:00
sysctl_net_ipv6.c
net: sysctl: introduce sysctl SYSCTL_THREE
2022-05-03 10:15:06 +02:00
tcp_ipv6.c
Merge ra.kernel.org:/pub/scm/linux/kernel/git/netdev/net
2023-02-17 11:06:39 +00:00
tcpv6_offload.c
net: move gro definitions to include/net/gro.h
2021-11-16 13:16:54 +00:00
tunnel6.c
tunnel6: add tunnel6_input_afinfo for ipip and ipv6 tunnels
2020-07-09 12:52:37 +02:00
udp_impl.h
tcp/udp: Call inet6_destroy_sock() in IPv6 sk->sk_destruct().
2022-10-12 17:50:37 -07:00
udp_offload.c
udp: allow header check for dodgy GSO_UDP_L4 packets.
2022-12-12 09:29:56 +00:00
udp.c
udp: Access &udp_table via net.
2022-11-16 09:43:35 +00:00
udplite.c
tcp/udp: Call inet6_destroy_sock() in IPv6 sk->sk_destruct().
2022-10-12 17:50:37 -07:00
xfrm6_input.c
…
xfrm6_output.c
xfrm: fix tunnel model fragmentation behavior
2022-03-01 12:08:40 +01:00
xfrm6_policy.c
xfrm: Fix ignored return value in xfrm6_init()
2022-11-22 07:16:34 +01:00
xfrm6_protocol.c
…
xfrm6_state.c
…
xfrm6_tunnel.c
xfrm: tunnel: add extack to ipip_init_state, xfrm6_tunnel_init_state
2022-09-29 07:18:00 +02:00