Ivan Vecera 650d3d8512 kernfs: fix regression in kernfs_fop_write caused by wrong type
commit ba87977a49913129962af8ac35b0e13e0fa4382d upstream.

Commit b7ce40cff0b9 ("kernfs: cache atomic_write_len in
kernfs_open_file") changes type of local variable 'len' from ssize_t
to size_t. This change caused that the *ppos value is updated also
when the previous write callback failed.

Mentioned snippet:
...
len = ops->write(...); <- return value can be negative
...
if (len > 0)           <- true here in this case
        *ppos += len;
...

Fixes: b7ce40cff0b9 ("kernfs: cache atomic_write_len in kernfs_open_file")
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2018-02-16 20:22:59 +01:00
..
2017-12-14 09:53:15 +01:00
2017-08-24 13:23:03 -07:00
2017-12-14 09:53:14 +01:00
2017-11-30 08:40:45 +00:00
2017-09-04 19:05:15 -04:00
2017-11-30 08:40:53 +00:00
2017-10-18 14:51:50 -04:00
2018-01-05 15:48:57 +01:00
2017-06-22 11:44:55 -04:00
2018-02-03 17:38:53 +01:00