John W. Linville
2f81b47135
ipw2100: register pm_qos request before registering pci driver
...
It is necessary to call pm_qos_add_request prior to calling
pm_qos_update_request. It was revealed that ipw2100 has been
doing this wrong since "pm_qos: Get rid of the allocation in
pm_qos_add_request()" (commit 82f682514a5df89ffb3890627eebf0897b7a84ec)
added a WARN that results in the following backtrace:
WARNING: at kernel/pm_qos_params.c:264 pm_qos_update_request+0x5e/0x70()
pm_qos_update_request() called for unknown object
Call Trace:
[<c1024088>] ? warn_slowpath_common+0x78/0xb0
[<c1041c9e>] ? pm_qos_update_request+0x5e/0x70
[<c1041c9e>] ? pm_qos_update_request+0x5e/0x70
[<c1024153>] ? warn_slowpath_fmt+0x33/0x40
[<c1041c9e>] ? pm_qos_update_request+0x5e/0x70
[<f89fe15f>] ? ipw2100_up+0x3f/0xf10 [ipw2100]
[<c11961c9>] ? vsnprintf+0xc9/0x530
[<f89ff36c>] ? ipw2100_net_init+0x2c/0x1c0 [ipw2100]
[<c12f542d>] ? register_netdevice+0x7d/0x3c0
[<f89f9b00>] ? ipw2100_irq_tasklet+0x910/0x9a0 [ipw2100]
[<c12f579f>] ? register_netdev+0x2f/0x40
[<f89fd471>] ? ipw2100_pci_init_one+0xd21/0x1060 [ipw2100]
[<c11a5ebb>] ? local_pci_probe+0xb/0x10
[<c11a6d49>] ? pci_device_probe+0x69/0x90
[<c1224704>] ? driver_probe_device+0x74/0x180
[<c10dd15a>] ? sysfs_create_dir+0x6a/0xb0
[<c1224889>] ? __driver_attach+0x79/0x80
[<c1224810>] ? __driver_attach+0x0/0x80
[<c1223fa2>] ? bus_for_each_dev+0x52/0x80
[<c1224586>] ? driver_attach+0x16/0x20
[<c1224810>] ? __driver_attach+0x0/0x80
[<c122395f>] ? bus_add_driver+0x17f/0x250
[<c11a5ec0>] ? pci_device_shutdown+0x0/0x20
[<c11a6c80>] ? pci_device_remove+0x0/0x40
[<c1224b13>] ? driver_register+0x63/0x120
[<c11a6f96>] ? __pci_register_driver+0x36/0xa0
[<f84f9048>] ? ipw2100_init+0x48/0x67 [ipw2100]
[<c1001122>] ? do_one_initcall+0x32/0x170
[<c1087078>] ? __vunmap+0xb8/0xf0
[<f84f9000>] ? ipw2100_init+0x0/0x67 [ipw2100]
[<c10510c1>] ? sys_init_module+0x161/0x1000
[<c108f847>] ? sys_close+0x67/0xe0
[<c13647c1>] ? syscall_call+0x7/0xb
This patch moves pm_qos_add_request prior to pci_register_driver in
ipw2100 in order to avoid this problem.
Reported-by: Christoph Fritz <chf.fritz@googlemail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2010-08-11 16:18:01 -04:00
..
2010-06-16 18:05:05 +02:00
2010-07-18 15:07:15 -07:00
2010-07-18 19:15:25 -07:00
2010-06-01 00:28:12 -07:00
2010-05-14 00:19:28 -07:00
2010-06-03 03:18:23 -07:00
2010-08-04 15:31:02 -07:00
2010-07-28 22:20:34 -07:00
2010-07-30 23:27:57 -07:00
2010-07-26 21:05:03 -07:00
2010-08-03 16:37:58 -07:00
2010-06-03 03:18:20 -07:00
2010-07-14 13:41:53 -07:00
2010-08-04 16:18:02 -07:00
2010-08-02 16:26:44 -07:00
2010-08-04 16:18:02 -07:00
2010-08-08 20:02:45 -07:00
2010-08-08 20:02:45 -07:00
2010-07-01 22:45:52 -07:00
2010-08-04 16:18:04 -07:00
2010-08-04 11:47:58 -07:00
2010-05-28 01:57:18 -07:00
2010-06-16 18:08:13 +02:00
2010-08-08 20:02:45 -07:00
2010-08-08 20:02:45 -07:00
2010-07-21 14:44:28 -07:00
2010-08-08 20:02:45 -07:00
2010-08-08 20:02:45 -07:00
2010-08-08 20:02:45 -07:00
2010-05-10 05:01:31 -07:00
2010-07-15 19:05:17 -07:00
2010-06-30 14:09:35 -07:00
2010-08-07 23:05:23 -07:00
2010-07-18 19:15:25 -07:00
2010-07-12 20:13:02 -07:00
2010-08-04 11:47:58 -07:00
2010-07-25 16:32:41 -07:00
2010-07-21 14:44:18 -07:00
2010-07-08 23:12:29 -07:00
2010-05-17 22:47:34 -07:00
2010-07-27 20:43:50 -07:00
2010-05-14 00:19:28 -07:00
2010-08-04 15:31:02 -07:00
2010-08-05 13:21:24 -07:00
2010-07-25 17:06:52 -07:00
2010-07-30 23:27:57 -07:00
2010-08-02 16:01:35 -07:00
2010-08-04 15:31:02 -07:00
2010-08-11 16:18:01 -04:00
2010-07-25 16:48:44 -07:00
2010-05-14 00:19:28 -07:00
2009-09-01 01:13:50 -07:00
2010-05-14 00:19:28 -07:00
2010-05-10 05:01:31 -07:00
2010-05-28 01:57:18 -07:00
2010-05-14 00:19:28 -07:00
2010-05-14 00:19:28 -07:00
2010-05-10 05:01:31 -07:00
2010-06-16 18:05:05 +02:00
2010-06-03 03:18:23 -07:00
2010-05-14 00:19:28 -07:00
2010-06-11 13:32:31 -07:00
2010-06-11 13:32:31 -07:00
2009-09-01 01:14:07 -07:00
2009-09-01 01:14:07 -07:00
2009-09-01 01:14:07 -07:00
2010-07-19 15:27:13 -07:00
2010-05-18 23:01:55 -07:00
2010-07-11 18:15:08 -07:00
2010-05-14 00:19:28 -07:00
2010-04-01 18:38:33 -07:00
2010-05-10 05:01:31 -07:00
2010-02-22 15:45:51 -08:00
2010-05-14 00:19:28 -07:00
2010-05-18 23:01:55 -07:00
2009-12-04 15:39:55 +01:00
2010-07-11 18:15:08 -07:00
2010-05-10 05:01:31 -07:00
2010-05-14 00:19:28 -07:00
2010-07-18 19:15:25 -07:00
2010-04-07 02:07:49 -07:00
2010-07-08 23:42:40 -07:00
2010-07-07 18:24:29 -07:00
2010-07-18 19:15:25 -07:00
2009-09-17 20:07:53 +02:00
2010-06-15 15:04:10 -07:00
2010-06-15 15:04:10 -07:00
2010-06-02 17:50:38 +10:00
2010-07-19 20:30:07 -07:00
2010-07-19 20:30:06 -07:00
2010-07-14 13:36:18 -07:00
2010-07-14 12:18:31 -07:00
2010-02-26 02:10:14 -08:00
2010-06-25 20:37:21 -07:00
2010-07-27 20:35:39 -07:00
2010-06-25 20:37:19 -07:00
2010-07-18 19:15:25 -07:00
2010-07-19 13:32:57 -07:00
2010-07-14 13:40:36 -07:00
2010-08-04 16:18:03 -07:00
2010-05-10 05:01:31 -07:00
2010-05-10 05:01:31 -07:00
2010-07-26 19:08:14 +01:00
2010-04-03 14:22:15 -07:00
2010-07-12 20:21:40 -07:00
2010-05-14 00:19:28 -07:00
2010-01-07 23:54:26 -08:00
2010-06-03 03:18:23 -07:00
2009-11-11 19:22:21 -08:00
2010-07-30 23:27:58 -07:00
2009-09-01 01:13:40 -07:00
2010-08-08 20:02:45 -07:00
2010-05-14 00:19:28 -07:00
2010-05-10 05:01:31 -07:00
2010-05-14 00:19:28 -07:00
2010-05-10 05:01:31 -07:00
2010-07-05 19:41:14 -07:00
2010-05-17 22:47:34 -07:00
2010-05-14 00:19:28 -07:00
2010-07-14 17:57:19 -07:00
2010-07-26 18:45:05 -07:00
2010-05-14 00:19:28 -07:00
2010-07-05 19:41:13 -07:00
2010-06-02 03:45:22 -07:00
2010-07-18 19:15:25 -07:00
2010-07-22 14:14:46 -07:00
2010-05-24 00:36:13 -07:00
2010-07-25 21:54:28 -07:00
2010-05-22 00:36:56 -06:00
2010-06-03 03:18:23 -07:00
2010-03-30 22:02:32 +09:00
2010-03-30 22:02:32 +09:00
2010-08-04 15:31:02 -07:00
2010-06-30 11:35:43 -07:00
2010-06-07 01:08:11 -07:00
2010-02-17 15:59:40 -08:00
2010-07-05 19:41:15 -07:00
2010-08-04 15:31:02 -07:00
2010-05-14 00:19:28 -07:00
2010-05-14 00:19:28 -07:00
2010-03-30 22:02:32 +09:00
2010-05-17 21:37:41 +02:00
2010-04-11 14:53:53 -07:00
2010-07-16 13:03:23 -07:00
2010-05-10 05:01:31 -07:00
2010-07-05 19:41:12 -07:00
2010-04-11 14:53:53 -07:00
2010-03-30 23:42:26 -07:00
2010-04-11 14:53:53 -07:00
2010-07-12 20:21:44 -07:00
2010-05-17 22:47:34 -07:00
2010-03-18 21:14:00 -07:00
2010-07-30 22:10:01 -07:00
2010-06-02 06:12:19 -07:00
2010-07-27 22:24:37 -07:00
2010-04-11 14:53:53 -07:00
2010-05-05 21:27:45 -07:00
2010-05-05 21:27:44 -07:00
2010-08-04 15:31:02 -07:00
2010-07-05 19:41:16 -07:00
2010-03-30 22:02:32 +09:00
2010-05-14 00:19:28 -07:00
2010-06-21 13:50:18 -07:00
2010-08-04 15:31:02 -07:00
2010-03-30 22:02:32 +09:00
2010-05-26 20:44:30 -07:00
2010-05-14 00:19:28 -07:00
2010-07-07 14:58:56 -07:00
2010-05-10 05:01:31 -07:00
2010-07-05 19:41:18 -07:00
2010-06-03 03:18:20 -07:00
2010-07-18 19:15:25 -07:00
2010-06-02 17:50:38 +10:00
2010-05-10 05:01:31 -07:00
2010-07-12 20:21:44 -07:00
2010-07-27 21:02:42 -07:00
2010-07-27 21:01:35 -07:00
2010-07-27 20:35:39 -07:00
2009-10-12 23:59:08 -07:00
2010-05-14 00:19:28 -07:00
2009-09-03 20:02:11 -07:00
2010-06-21 13:40:25 -07:00
2010-07-23 13:05:12 -07:00
2010-03-30 22:02:32 +09:00
2010-05-22 00:36:56 -06:00
2010-07-05 19:41:17 -07:00
2010-05-14 00:19:28 -07:00
2010-05-14 00:19:28 -07:00
2010-05-14 00:19:28 -07:00
2010-05-14 00:19:28 -07:00
2010-07-05 20:08:05 -07:00
2010-05-06 00:47:21 -07:00
2010-05-10 05:01:31 -07:00
2010-07-05 19:41:19 -07:00
2010-05-10 05:01:31 -07:00
2010-05-14 00:19:28 -07:00
2010-07-07 18:20:30 -07:00
2010-04-22 15:48:17 -07:00
2010-07-05 19:41:18 -07:00
2009-10-12 13:26:39 -07:00
2010-05-14 00:19:28 -07:00
2010-05-10 05:01:31 -07:00
2010-05-14 00:19:28 -07:00
2010-05-14 00:19:28 -07:00
2010-08-04 21:53:17 -07:00
2009-12-03 13:18:01 -08:00
2010-07-12 20:21:47 -07:00
2009-12-03 13:18:01 -08:00
2010-08-04 21:53:17 -07:00
2010-08-04 21:53:17 -07:00
2010-03-30 22:02:32 +09:00
2010-05-10 05:01:31 -07:00
2009-12-02 00:52:31 -08:00
2010-05-20 21:04:44 -07:00
2010-06-03 03:18:23 -07:00
2010-07-26 13:15:21 -07:00
2010-04-13 02:54:17 -07:00
2010-07-21 21:10:49 -07:00
2010-07-20 18:25:24 -07:00
2010-03-30 22:02:32 +09:00
2010-05-10 05:01:31 -07:00
2009-09-01 01:14:07 -07:00
2010-07-15 20:46:22 -07:00
2010-07-23 13:05:13 -07:00
2010-07-27 21:01:35 -07:00
2010-05-10 05:01:31 -07:00
2010-05-14 00:19:28 -07:00
2010-07-18 19:15:25 -07:00
2010-05-10 05:01:31 -07:00
2010-05-14 00:19:28 -07:00
2010-05-10 05:01:31 -07:00
2010-08-04 15:31:02 -07:00
2009-10-13 03:44:05 -07:00
2010-04-11 14:53:53 -07:00
2010-05-14 00:19:28 -07:00
2010-05-15 23:29:31 -07:00
2010-05-15 23:29:31 -07:00
2010-07-30 23:59:04 -07:00
2010-06-03 03:18:23 -07:00
2010-05-14 00:19:28 -07:00
2010-05-17 22:47:34 -07:00
2010-05-10 05:01:31 -07:00
2010-03-10 07:37:06 -08:00
2010-05-10 05:01:31 -07:00
2010-02-15 09:27:02 -08:00
2010-05-14 00:19:28 -07:00
2010-05-14 00:19:28 -07:00
2010-05-14 00:19:28 -07:00
2010-05-14 00:19:28 -07:00
2010-07-19 13:36:21 -07:00
2009-12-04 15:39:55 +01:00
2010-07-18 19:15:25 -07:00
2010-03-30 22:02:32 +09:00
2010-05-10 05:01:31 -07:00
2010-07-14 12:17:35 -07:00
2010-05-14 00:19:28 -07:00
2010-07-05 19:41:15 -07:00
2010-05-14 00:19:28 -07:00
2010-07-05 19:41:11 -07:00
2010-05-10 05:01:31 -07:00
2010-05-22 00:36:56 -06:00
2010-05-14 00:19:28 -07:00
2010-05-14 00:19:28 -07:00
2009-12-03 13:18:01 -08:00
2010-05-22 00:36:56 -06:00
2010-05-22 00:36:56 -06:00
2010-05-22 00:36:56 -06:00
2010-05-10 05:01:31 -07:00
2010-07-18 19:15:25 -07:00
2010-06-03 03:28:23 -07:00
2010-06-03 03:18:23 -07:00
2010-08-02 15:46:33 -07:00
2010-08-02 15:46:33 -07:00
2010-05-10 05:01:31 -07:00
2010-01-13 20:37:01 -08:00
2010-04-14 16:11:33 -07:00
2010-07-30 22:06:41 -07:00
2010-06-03 03:18:23 -07:00
2010-06-03 03:18:23 -07:00
2010-03-30 22:02:32 +09:00
2010-07-30 22:08:50 -07:00
2010-06-03 03:18:23 -07:00
2010-05-06 00:53:53 -07:00
2010-05-10 05:01:31 -07:00
2010-08-04 16:18:03 -07:00
2010-06-03 03:18:23 -07:00
2010-08-04 21:53:17 -07:00
2010-07-14 17:53:18 -07:00
2010-05-31 00:27:44 -07:00
2010-05-22 00:36:56 -06:00
2010-07-12 20:21:45 -07:00
2010-05-14 00:19:28 -07:00
2010-05-14 00:19:28 -07:00
2010-05-18 23:01:55 -07:00