Pengcheng Yang
27e724bf7c
tcp: fix F-RTO may not work correctly when receiving DSACK ...
[ Upstream commit d9157f6806d1499e173770df1f1b234763de5c79 ]
Currently DSACK is regarded as a dupack, which may cause
F-RTO to incorrectly enter "loss was real" when receiving
DSACK.
Packetdrill to demonstrate:
// Enable F-RTO and TLP
0 `sysctl -q net.ipv4.tcp_frto=2`
0 `sysctl -q net.ipv4.tcp_early_retrans=3`
0 `sysctl -q net.ipv4.tcp_congestion_control=cubic`
// Establish a connection
+0 socket(..., SOCK_STREAM, IPPROTO_TCP) = 3
+0 setsockopt(3, SOL_SOCKET, SO_REUSEADDR, [1], 4) = 0
+0 bind(3, ..., ...) = 0
+0 listen(3, 1) = 0
// RTT 10ms, RTO 210ms
+.1 < S 0:0(0) win 32792 <mss 1000,sackOK,nop,nop,nop,wscale 7>
+0 > S. 0:0(0) ack 1 <...>
+.01 < . 1:1(0) ack 1 win 257
+0 accept(3, ..., ...) = 4
// Send 2 data segments
+0 write(4, ..., 2000) = 2000
+0 > P. 1:2001(2000) ack 1
// TLP
+.022 > P. 1001:2001(1000) ack 1
// Continue to send 8 data segments
+0 write(4, ..., 10000) = 10000
+0 > P. 2001:10001(8000) ack 1
// RTO
+.188 > . 1:1001(1000) ack 1
// The original data is acked and new data is sent(F-RTO step 2.b)
+0 < . 1:1(0) ack 2001 win 257
+0 > P. 10001:12001(2000) ack 1
// D-SACK caused by TLP is regarded as a dupack, this results in
// the incorrect judgment of "loss was real"(F-RTO step 3.a)
+.022 < . 1:1(0) ack 2001 win 257 <sack 1001:2001,nop,nop>
// Never-retransmitted data(3001:4001) are acked and
// expect to switch to open state(F-RTO step 3.b)
+0 < . 1:1(0) ack 4001 win 257
+0 %{ assert tcpi_ca_state == 0, tcpi_ca_state }%
Fixes: e33099f96d99 ("tcp: implement RFC5682 F-RTO")
Signed-off-by: Pengcheng Yang <yangpc@wangsu.com>
Acked-by: Neal Cardwell <ncardwell@google.com>
Tested-by: Neal Cardwell <ncardwell@google.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/1650967419-2150-1-git-send-email-yangpc@wangsu.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2022-05-09 09:14:39 +02:00
2021-07-22 16:19:03 +02:00
2022-03-11 12:22:36 +01:00
2021-08-13 16:30:35 -07:00
2021-12-01 09:04:53 +01:00
2021-07-23 14:20:25 +01:00
2022-04-20 09:34:22 +02:00
2022-04-13 20:59:03 +02:00
2022-04-13 20:59:09 +02:00
2022-04-13 20:59:25 +02:00
2021-06-25 13:13:50 +02:00
2022-02-23 12:03:13 +01:00
2021-09-14 12:51:15 +01:00
2022-04-27 14:38:54 +02:00
2021-06-30 15:51:09 -07:00
2022-05-09 09:14:35 +02:00
2022-03-08 19:12:52 +01:00
2021-11-18 19:16:33 +01:00
2021-08-05 13:27:50 +01:00
2022-05-09 09:14:34 +02:00
2021-08-03 13:05:26 +01:00
2021-12-14 10:57:09 +01:00
2022-02-08 18:34:09 +01:00
2022-05-09 09:14:39 +02:00
2022-05-09 09:14:37 +02:00
2021-08-09 10:13:32 +01:00
2021-06-29 11:28:21 -07:00
2022-04-08 14:22:47 +02:00
2021-09-09 11:00:20 +01:00
2022-04-27 14:38:53 +02:00
2022-03-28 09:58:46 +02:00
2022-04-08 14:23:28 +02:00
2021-09-07 14:06:08 +01:00
2022-04-13 20:59:16 +02:00
2021-12-08 09:04:47 +01:00
2022-03-08 19:12:48 +01:00
2022-01-05 12:42:37 +01:00
2022-05-09 09:14:38 +02:00
2022-04-13 20:59:10 +02:00
2022-04-27 14:38:54 +02:00
2022-01-27 11:04:00 +01:00
2022-04-20 09:34:13 +02:00
2022-04-27 14:39:01 +02:00
2022-04-27 14:38:53 +02:00
2022-01-11 15:35:16 +01:00
2021-09-02 11:37:02 +01:00
2021-12-22 09:32:42 +01:00
2022-04-08 14:23:00 +02:00
2022-04-27 14:38:53 +02:00
2022-04-27 14:39:01 +02:00
2022-05-09 09:14:35 +02:00
2022-05-09 09:14:36 +02:00
2021-11-18 19:17:11 +01:00
2022-04-20 09:34:18 +02:00
2021-08-04 12:35:07 +01:00
2022-04-08 14:23:43 +02:00
2022-05-09 09:14:38 +02:00
2022-04-08 14:24:14 +02:00
2022-04-08 14:23:51 +02:00
2022-04-20 09:34:19 +02:00
2022-04-08 14:23:53 +02:00
2022-05-09 09:14:32 +02:00
2022-04-08 14:22:46 +02:00
2021-07-29 15:06:49 +01:00
2021-07-29 15:06:49 +01:00
2022-01-27 11:03:52 +01:00
27e724bf7c