Abhi Das 3013317795 gfs2: fix quota refresh race in do_glock()
quotad periodically syncs in-memory quotas to the ondisk quota file
and sets the QDF_REFRESH flag so that a subsequent read of a synced
quota is re-read from disk.

gfs2_quota_lock() checks for this flag and sets a 'force' bit to
force re-read from disk if requested. However, there is a race
condition here. It is possible for gfs2_quota_lock() to find the
QDF_REFRESH flag unset (i.e force=0) and quotad comes in immediately
after and syncs the relevant quota and sets the QDF_REFRESH flag.
gfs2_quota_lock() resumes with force=0 and uses the stale in-memory
quota usage values that result in miscalculations.

This patch fixes this race by moving the check for the QDF_REFRESH
flag check further out into the gfs2_quota_lock() process, i.e, in
do_glock(), under the protection of the quota glock.

Signed-off-by: Abhi Das <adas@redhat.com>
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Acked-by: Steven Whitehouse <swhiteho@redhat.com>
2015-04-08 09:31:18 -05:00
..
2014-08-08 15:57:24 -07:00
2015-02-16 17:56:03 -08:00
2014-08-07 14:40:09 -04:00
2015-02-13 21:21:36 -08:00
2015-02-15 11:11:47 -08:00
2015-02-05 16:34:25 +01:00
2014-11-19 13:01:20 -05:00
2015-02-20 04:56:44 -05:00
2015-02-16 17:56:04 -08:00
2015-01-29 00:13:13 -05:00
2014-08-26 09:35:56 +02:00
2014-11-19 13:01:26 -05:00