iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net/sched
History
Jiri Pirko 30d65e8f96 net: sched: don't do tcf_chain_flush from tcf_chain_destroy 
tcf_chain_flush needs to be called with RTNL. However, on
free_tcf->
 tcf_action_goto_chain_fini->
  tcf_chain_put->
   tcf_chain_destroy->
    tcf_chain_flush
callpath, it is called without RTNL.
This issue was notified by following warning:

[  155.599052] WARNING: suspicious RCU usage
[  155.603165] 4.13.0-rc5jiri+ #54 Not tainted
[  155.607456] -----------------------------
[  155.611561] net/sched/cls_api.c:195 suspicious rcu_dereference_protected() usage!

Since on this callpath, the chain is guaranteed to be already empty
by check in tcf_chain_put, move the tcf_chain_flush call out and call it
only where it is needed - into tcf_block_put.

Fixes: db50514f9a9c ("net: sched: add termination action to allow goto chain")
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2017-08-22 14:39:58 -07:00
..
act_api.c
net sched actions: rename act_get_notify() to tcf_get_notify()
2017-07-14 08:52:33 -07:00
act_bpf.c
bpf: expose prog id for cls_bpf and act_bpf
2017-06-21 15:14:23 -04:00
act_connmark.c
netlink: pass extended ACK struct to parsing functions
2017-04-13 13:58:22 -04:00
act_csum.c
net: use skb->csum_not_inet to identify packets needing crc32c
2017-05-19 19:21:29 -04:00
act_gact.c
netlink: pass extended ACK struct to parsing functions
2017-04-13 13:58:22 -04:00
act_ife.c
netlink: pass extended ACK struct to parsing functions
2017-04-13 13:58:22 -04:00
act_ipt.c
net: sched: fix NULL pointer dereference when action calls some targets
2017-08-18 16:25:49 -07:00
act_meta_mark.c
Support to encoding decoding skb mark on IFE action
2016-03-01 17:15:23 -05:00
act_meta_skbprio.c
Support to encoding decoding skb prio on IFE action
2016-03-01 17:15:23 -05:00
act_meta_skbtcindex.c
net sched ife action: Introduce skb tcindex metadata encap decap
2016-09-19 21:55:28 -04:00
act_mirred.c
netlink: pass extended ACK struct to parsing functions
2017-04-13 13:58:22 -04:00
act_nat.c
netlink: pass extended ACK struct to parsing functions
2017-04-13 13:58:22 -04:00
act_pedit.c
net/act_pedit: fix an error code
2017-06-14 15:24:18 -04:00
act_police.c
net_sched: move tcf_lock down after gen_replace_estimator()
2017-06-14 14:39:19 -04:00
act_sample.c
netlink: pass extended ACK struct to parsing functions
2017-04-13 13:58:22 -04:00
act_simple.c
netlink: pass extended ACK struct to parsing functions
2017-04-13 13:58:22 -04:00
act_skbedit.c
netlink: pass extended ACK struct to parsing functions
2017-04-13 13:58:22 -04:00
act_skbmod.c
netlink: pass extended ACK struct to parsing functions
2017-04-13 13:58:22 -04:00
act_tunnel_key.c
net: sched: act_tunnel_key: make UDP checksum configurable
2017-06-15 14:21:03 -04:00
act_vlan.c
netlink: pass extended ACK struct to parsing functions
2017-04-13 13:58:22 -04:00
cls_api.c
net: sched: don't do tcf_chain_flush from tcf_chain_destroy
2017-08-22 14:39:58 -07:00
cls_basic.c
net_sched: move the empty tp check from ->destroy() to ->delete()
2017-04-21 13:58:15 -04:00
cls_bpf.c
bpf: expose prog id for cls_bpf and act_bpf
2017-06-21 15:14:23 -04:00
cls_cgroup.c
net_sched: move the empty tp check from ->destroy() to ->delete()
2017-04-21 13:58:15 -04:00
cls_flow.c
net_sched: move the empty tp check from ->destroy() to ->delete()
2017-04-21 13:58:15 -04:00
cls_flower.c
net: propagate tc filter chain index down the ndo_setup_tc call
2017-06-08 09:55:53 -04:00
cls_fw.c
net_sched: remove useless NULL to tp->root
2017-04-21 13:58:15 -04:00
cls_matchall.c
net: propagate tc filter chain index down the ndo_setup_tc call
2017-06-08 09:55:53 -04:00
cls_route.c
net_sched: remove useless NULL to tp->root
2017-04-21 13:58:15 -04:00
cls_rsvp6.c
…
cls_rsvp.c
…
cls_rsvp.h
net_sched: remove useless NULL to tp->root
2017-04-21 13:58:15 -04:00
cls_tcindex.c
net_sched: move the empty tp check from ->destroy() to ->delete()
2017-04-21 13:58:15 -04:00
cls_u32.c
net: propagate tc filter chain index down the ndo_setup_tc call
2017-06-08 09:55:53 -04:00
em_canid.c
net: sched: remove tcf_proto from ematch calls
2014-10-06 18:02:32 -04:00
em_cmp.c
…
em_ipset.c
netfilter: x_tables: move hook state into xt_action_param structure
2016-11-03 10:56:21 +01:00
em_meta.c
net: convert sock.sk_refcnt from atomic_t to refcount_t
2017-07-01 07:39:08 -07:00
em_nbyte.c
net: sched: remove tcf_proto from ematch calls
2014-10-06 18:02:32 -04:00
em_text.c
net: Remove state argument from skb_find_text()
2015-02-22 15:59:54 -05:00
em_u32.c
…
ematch.c
netlink: pass extended ACK struct to parsing functions
2017-04-13 13:58:22 -04:00
Kconfig
net: sched: select cls when cls_act is enabled
2017-06-05 10:56:36 -04:00
Makefile
net/sched: Introduce sample tc action
2017-01-24 13:44:28 -05:00
sch_api.c
net_sched: remove warning from qdisc_hash_add
2017-08-15 17:16:39 -07:00
sch_atm.c
net_sched: reset pointers to tcf blocks in classful qdiscs' destructors
2017-08-15 17:16:39 -07:00
sch_blackhole.c
net_sched: drop packets after root qdisc lock is released
2016-06-25 12:19:35 -04:00
sch_cbq.c
net_sched: reset pointers to tcf blocks in classful qdiscs' destructors
2017-08-15 17:16:39 -07:00
sch_choke.c
treewide: use kv[mz]alloc* rather than opencoded variants
2017-05-08 17:15:13 -07:00
sch_codel.c
netlink: pass extended ACK struct to parsing functions
2017-04-13 13:58:22 -04:00
sch_drr.c
net: sched: introduce a TRAP control action
2017-06-06 12:45:23 -04:00
sch_dsmark.c
net: sched: introduce a TRAP control action
2017-06-06 12:45:23 -04:00
sch_fifo.c
sched: don't use skb queue helpers
2016-09-19 01:47:18 -04:00
sch_fq_codel.c
net: sched: introduce a TRAP control action
2017-06-06 12:45:23 -04:00
sch_fq.c
mm, tree wide: replace __GFP_REPEAT by __GFP_RETRY_MAYFAIL with more useful semantic
2017-07-12 16:26:03 -07:00
sch_generic.c
net, sched: convert Qdisc.refcnt from atomic_t to refcount_t
2017-07-04 22:35:16 +01:00
sch_gred.c
netlink: pass extended ACK struct to parsing functions
2017-04-13 13:58:22 -04:00
sch_hfsc.c
net_sched: reset pointers to tcf blocks in classful qdiscs' destructors
2017-08-15 17:16:39 -07:00
sch_hhf.c
treewide: use kv[mz]alloc* rather than opencoded variants
2017-05-08 17:15:13 -07:00
sch_htb.c
net_sched: reset pointers to tcf blocks in classful qdiscs' destructors
2017-08-15 17:16:39 -07:00
sch_ingress.c
net: sched: introduce tcf block infractructure
2017-05-17 15:22:13 -04:00
sch_mq.c
net: sched: make default fifo qdiscs appear in the dump
2017-03-12 22:53:02 -07:00
sch_mqprio.c
net: propagate tc filter chain index down the ndo_setup_tc call
2017-06-08 09:55:53 -04:00
sch_multiq.c
net: sched: introduce a TRAP control action
2017-06-06 12:45:23 -04:00
sch_netem.c
treewide: use kv[mz]alloc* rather than opencoded variants
2017-05-08 17:15:13 -07:00
sch_pie.c
netlink: pass extended ACK struct to parsing functions
2017-04-13 13:58:22 -04:00
sch_plug.c
net_sched: drop packets after root qdisc lock is released
2016-06-25 12:19:35 -04:00
sch_prio.c
net: sched: introduce a TRAP control action
2017-06-06 12:45:23 -04:00
sch_qfq.c
net: sched: introduce a TRAP control action
2017-06-06 12:45:23 -04:00
sch_red.c
netlink: pass extended ACK struct to parsing functions
2017-04-13 13:58:22 -04:00
sch_sfb.c
net: sched: introduce a TRAP control action
2017-06-06 12:45:23 -04:00
sch_sfq.c
net_sched/sfq: update hierarchical backlog when drop packet
2017-08-15 17:16:39 -07:00
sch_tbf.c
netlink: pass extended ACK struct to parsing functions
2017-04-13 13:58:22 -04:00
sch_teql.c
net: make ndo_get_stats64 a void function
2017-01-08 17:51:44 -05:00