iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/arch/arm64/include/asm
History
Jia He 30e235389f arm64: mm: add missing PTE_SPECIAL in pte_mkdevmap on arm64 
Without this patch, the MAP_SYNC test case will cause a print_bad_pte
warning on arm64 as follows:

[   25.542693] BUG: Bad page map in process mapdax333 pte:2e8000448800f53 pmd:41ff5f003
[   25.546360] page:ffff7e0010220000 refcount:1 mapcount:-1 mapping:ffff8003e29c7440 index:0x0
[   25.550281] ext4_dax_aops
[   25.550282] name:"__aaabbbcccddd__"
[   25.551553] flags: 0x3ffff0000001002(referenced|reserved)
[   25.555802] raw: 03ffff0000001002 ffff8003dfffa908 0000000000000000 ffff8003e29c7440
[   25.559446] raw: 0000000000000000 0000000000000000 00000001fffffffe 0000000000000000
[   25.563075] page dumped because: bad pte
[   25.564938] addr:0000ffffbe05b000 vm_flags:208000fb anon_vma:0000000000000000 mapping:ffff8003e29c7440 index:0
[   25.574272] file:__aaabbbcccddd__ fault:ext4_dax_fault mmmmap:ext4_file_mmap readpage:0x0
[   25.578799] CPU: 1 PID: 1180 Comm: mapdax333 Not tainted 5.2.0+ #21
[   25.581702] Hardware name: QEMU KVM Virtual Machine, BIOS 0.0.0 02/06/2015
[   25.585624] Call trace:
[   25.587008]  dump_backtrace+0x0/0x178
[   25.588799]  show_stack+0x24/0x30
[   25.590328]  dump_stack+0xa8/0xcc
[   25.591901]  print_bad_pte+0x18c/0x218
[   25.593628]  unmap_page_range+0x778/0xc00
[   25.595506]  unmap_single_vma+0x94/0xe8
[   25.597304]  unmap_vmas+0x90/0x108
[   25.598901]  unmap_region+0xc0/0x128
[   25.600566]  __do_munmap+0x284/0x3f0
[   25.602245]  __vm_munmap+0x78/0xe0
[   25.603820]  __arm64_sys_munmap+0x34/0x48
[   25.605709]  el0_svc_common.constprop.0+0x78/0x168
[   25.607956]  el0_svc_handler+0x34/0x90
[   25.609698]  el0_svc+0x8/0xc
[...]

The root cause is in _vm_normal_page, without the PTE_SPECIAL bit,
the return value will be incorrectly set to pfn_to_page(pfn) instead
of NULL. Besides, this patch also rewrite the pmd_mkdevmap to avoid
setting PTE_SPECIAL for pmd

The MAP_SYNC test case is as follows(Provided by Yibo Cai)
$#include <stdio.h>
$#include <string.h>
$#include <unistd.h>
$#include <sys/file.h>
$#include <sys/mman.h>

$#ifndef MAP_SYNC
$#define MAP_SYNC 0x80000
$#endif

/* mount -o dax /dev/pmem0 /mnt */
$#define F "/mnt/__aaabbbcccddd__"

int main(void)
{
    int fd;
    char buf[4096];
    void *addr;

    if ((fd = open(F, O_CREAT|O_TRUNC|O_RDWR, 0644)) < 0) {
        perror("open1");
        return 1;
    }

    if (write(fd, buf, 4096) != 4096) {
        perror("lseek");
        return 1;
    }

    addr = mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_SHARED|MAP_SYNC, fd, 0);
    if (addr == MAP_FAILED) {
        perror("mmap");
        printf("did you mount with '-o dax'?\n");
        return 1;
    }

    memset(addr, 0x55, 4096);

    if (munmap(addr, 4096) == -1) {
        perror("munmap");
        return 1;
    }

    close(fd);

    return 0;
}

Fixes: 73b20c84d42d ("arm64: mm: implement pte_devmap support")
Reported-by: Yibo Cai <Yibo.Cai@arm.com>
Acked-by: Will Deacon <will@kernel.org>
Acked-by: Robin Murphy <Robin.Murphy@arm.com>
Signed-off-by: Jia He <justin.he@arm.com>
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
2019-08-08 18:38:20 +01:00
..
vdso
arm64: compat: vdso: Use legacy syscalls as fallback
2019-07-31 00:09:10 +02:00
xen
arm64/xen: fix xen-swiotlb cache flushing
2019-01-23 22:14:56 +01:00
acenv.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
acpi.h
arm64 updates for 5.3:
2019-07-08 09:54:55 -07:00
alternative.h
arm64: alternative: Apply alternatives early in boot process
2019-02-06 10:05:20 +00:00
arch_gicv3.h
arm64: Lower priority mask for GIC_PRIO_IRQON
2019-08-01 14:59:48 +01:00
arch_timer.h
Merge branch 'timers/vdso' into timers/core
2019-07-03 10:50:21 +02:00
arm_dsu_pmu.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
arm-cci.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
asm-bug.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
asm-offsets.h
…
asm-prototypes.h
arm64: asm-prototypes: Fix fat-fingered typo in comment
2019-01-10 11:11:46 +00:00
asm-uaccess.h
arm64: Rename get_thread_info()
2019-02-26 16:57:59 +00:00
assembler.h
arm64: assembler: Switch ESB-instruction with a vanilla nop if !ARM64_HAS_RAS
2019-07-05 13:03:29 +01:00
atomic_ll_sc.h
Merge branch 'locking-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2019-07-08 16:12:03 -07:00
atomic_lse.h
Merge branch 'locking-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2019-07-08 16:12:03 -07:00
atomic.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
barrier.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
bitops.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
bitrev.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
boot.h
treewide: replace #include <asm/sizes.h> with #include <linux/sizes.h>
2019-05-14 19:52:52 -07:00
brk-imm.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
bug.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
cache.h
arm64 updates for 5.3:
2019-07-08 09:54:55 -07:00
cacheflush.h
arm64 updates for 5.3:
2019-07-08 09:54:55 -07:00
checksum.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
clocksource.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
cmpxchg.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
compat.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
cpu_ops.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
cpu.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
cpucaps.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
cpufeature.h
arm64: cpufeature: Fix feature comparison for CTR_EL0.{CWG,ERG}
2019-07-31 18:10:55 +01:00
cpuidle.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
cputype.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
current.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
daifflags.h
arm64: kprobes: Recover pstate.D in single-step exception handler
2019-08-02 11:55:50 +01:00
dcc.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 284
2019-06-05 17:36:37 +02:00
debug-monitors.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
device.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
dma-mapping.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
dmi.h
…
efi.h
arm64/efi: fix variable 'si' set but not used
2019-07-31 18:13:46 +01:00
elf.h
arm64: vdso: Fix population of AT_SYSINFO_EHDR for compat vdso
2019-07-22 10:33:42 +01:00
esr.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
exception.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
exec.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
extable.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
fb.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
fixmap.h
firmware: arm_sdei: Add ACPI GHES registration helper
2019-02-11 11:07:49 +01:00
fpsimd.h
arm64 updates for 5.3:
2019-07-08 09:54:55 -07:00
fpsimdmacros.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
ftrace.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
futex.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
hardirq.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
hugetlb.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174
2019-05-30 11:26:41 -07:00
hw_breakpoint.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
hwcap.h
arm64 updates for 5.3:
2019-07-08 09:54:55 -07:00
hypervisor.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
image.h
docs: arm64: convert docs to ReST and rename to .rst
2019-06-14 14:20:27 -06:00
insn.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
io.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
irq_work.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
irq.h
arm64: Use the new GENERIC_IRQ_MULTI_HANDLER
2018-08-03 12:14:09 +02:00
irqflags.h
arm64 updates for 5.3:
2019-07-08 09:54:55 -07:00
jump_label.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
kasan.h
kasan: add tag related helper functions
2018-12-28 12:11:43 -08:00
Kbuild
treewide: Add SPDX license identifier - Kbuild
2019-05-30 11:32:33 -07:00
kernel-pgtable.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
kexec.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
kgdb.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
kprobes.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174
2019-05-30 11:26:41 -07:00
kvm_arm.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
kvm_asm.h
KVM: arm64: Consume pending SError as early as possible
2019-07-05 13:03:29 +01:00
kvm_coproc.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
kvm_emulate.h
KVM: arm64: Migrate _elx sysreg accessors to msr_s/mrs_s
2019-07-05 13:57:25 +01:00
kvm_host.h
ARM:
2019-07-12 15:35:14 -07:00
kvm_hyp.h
KVM: arm64: Migrate _elx sysreg accessors to msr_s/mrs_s
2019-07-05 13:57:25 +01:00
kvm_mmio.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
kvm_mmu.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
kvm_ptrauth.h
KVM: arm/arm64: Context-switch ptrauth registers
2019-04-24 15:30:40 +01:00
kvm_ras.h
arm64: KVM/mm: Move SEA handling behind a single 'claim' interface
2019-02-07 23:10:45 +01:00
linkage.h
arm64: relax assembly code alignment from 16 byte to 4 byte
2017-09-18 11:20:19 +01:00
lse.h
arm64: lse: Include compiler_types.h and export.h for out-of-line LL/SC
2018-03-27 13:14:49 +01:00
memory.h
arm64/mm: fix variable 'tag' set but not used
2019-08-01 15:53:10 +01:00
mmu_context.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
mmu.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
mmzone.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
module.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
neon-intrinsics.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
neon.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
numa.h
arm64: numa: separate out updates to percpu nodeid and NUMA node cpumap
2018-07-06 13:18:18 +01:00
page-def.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
page.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
paravirt.h
x86/paravirt: Use a single ops structure
2018-09-03 16:50:35 +02:00
pci.h
PCI: remove PCI_DMA_BUS_IS_PHYS
2018-05-07 07:15:41 +02:00
percpu.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
perf_event.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
pgalloc.h
arm64: switch to generic version of pte allocation
2019-07-12 11:05:45 -07:00
pgtable-hwdef.h
arm64 updates for 5.3:
2019-07-08 09:54:55 -07:00
pgtable-prot.h
arm64: mm: implement pte_devmap support
2019-07-16 19:23:25 -07:00
pgtable-types.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
pgtable.h
arm64: mm: add missing PTE_SPECIAL in pte_mkdevmap on arm64
2019-08-08 18:38:20 +01:00
pointer_auth.h
arm64: Use the correct style for SPDX License Identifier
2019-04-16 16:28:01 +01:00
preempt.h
arm64: preempt: Provide our own implementation of asm/preempt.h
2018-12-07 12:35:53 +00:00
probes.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174
2019-05-30 11:26:41 -07:00
proc-fns.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
processor.h
arm64: Force SSBS on context switch
2019-07-22 15:24:16 +01:00
ptdump.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
ptrace.h
arm64: Lower priority mask for GIC_PRIO_IRQON
2019-08-01 14:59:48 +01:00
sdei.h
arm64: Use the correct style for SPDX License Identifier
2019-04-16 16:28:01 +01:00
seccomp.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
sections.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
shmparam.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
signal32.h
arm64: compat: Expose signal related structures
2019-06-22 21:21:07 +02:00
simd.h
arm64 updates for 5.3:
2019-07-08 09:54:55 -07:00
smp_plat.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
smp.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
sparsemem.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
spinlock_types.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
spinlock.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
stack_pointer.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
stackprotector.h
arm64: enable per-task stack canaries
2018-12-12 18:45:31 +00:00
stacktrace.h
arm64: stacktrace: Better handle corrupted stacks
2019-07-22 11:44:15 +01:00
stage2_pgtable.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
stat.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
string.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
suspend.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
sync_bitops.h
arm64, locking/atomics: Use instrumented atomics
2018-11-01 11:01:40 +01:00
syscall_wrapper.h
arm64: use the correct function type in SYSCALL_DEFINE0
2019-05-29 13:45:59 +01:00
syscall.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
sysreg.h
arch: replace _BITUL() in kernel-space headers with BIT()
2019-07-16 19:23:22 -07:00
system_misc.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
thread_info.h
arm64 updates for 5.3:
2019-07-08 09:54:55 -07:00
timex.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
tlb.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
tlbflush.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
topology.h
sched/topology, arch/arm64: Rebuild the sched_domain hierarchy when the CPU capacity changes
2018-09-10 11:05:47 +02:00
traps.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
uaccess.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
unistd32.h
clone3-v5.3
2019-07-11 10:09:44 -07:00
unistd.h
clone3-v5.3
2019-07-11 10:09:44 -07:00
uprobes.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
vdso_datapage.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
vdso.h
arm64: compat: Get sigreturn trampolines from vDSO
2019-06-22 21:21:09 +02:00
virt.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
vmap_stack.h
arm64: Use the correct style for SPDX License Identifier
2019-04-16 16:28:01 +01:00
word-at-a-time.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
xor.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00