Nikanth Karthikesan 316d315bff block: Seperate read and write statistics of in_flight requests v2
Commit a9327cac440be4d8333bba975cbbf76045096275 added seperate read
and write statistics of in_flight requests. And exported the number
of read and write requests in progress seperately through sysfs.

But  Corrado Zoccolo <czoccolo@gmail.com> reported getting strange
output from "iostat -kx 2". Global values for service time and
utilization were garbage. For interval values, utilization was always
100%, and service time is higher than normal.

So this was reverted by commit 0f78ab9899e9d6acb09d5465def618704255963b

The problem was in part_round_stats_single(), I missed the following:
        if (now == part->stamp)
                return;

-       if (part->in_flight) {
+       if (part_in_flight(part)) {
                __part_stat_add(cpu, part, time_in_queue,
                                part_in_flight(part) * (now - part->stamp));
                __part_stat_add(cpu, part, io_ticks, (now - part->stamp));

With this chunk included, the reported regression gets fixed.

Signed-off-by: Nikanth Karthikesan <knikanth@suse.de>

--
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
2009-10-06 20:16:55 +02:00
..
2009-09-23 13:03:46 -05:00
2009-06-11 21:36:14 -04:00
2009-10-01 16:11:16 -07:00
2009-07-12 12:22:34 -07:00
2009-10-04 15:05:10 -07:00
2009-09-23 07:39:28 -07:00
2009-09-23 07:39:29 -07:00
2009-06-17 00:36:36 -04:00
2009-07-12 12:22:34 -07:00
2009-07-12 12:22:34 -07:00
2009-09-23 18:13:10 -07:00
2009-09-23 07:39:30 -07:00
2009-09-24 08:41:47 -04:00
2009-06-17 00:36:37 -04:00
2009-06-18 13:03:46 -07:00
2009-09-24 08:41:47 -04:00
2009-09-24 07:21:01 -07:00
2009-09-24 07:21:03 -07:00
2009-06-18 13:03:41 -07:00
2009-09-24 07:21:01 -07:00
2009-03-31 23:00:26 -04:00
2009-09-24 07:47:27 -04:00
2009-09-22 07:17:41 -07:00
2009-04-07 08:31:16 -07:00
2009-10-04 15:05:10 -07:00
2009-04-20 23:02:52 -04:00
2009-09-23 07:39:29 -07:00
2009-02-18 15:37:53 -08:00