Jason Baron
8a9093c798
net: sched: correct flower port blocking
...
tc flower rules that are based on src or dst port blocking are sometimes
ineffective due to uninitialized stack data. __skb_flow_dissect() extracts
ports from the skb for tc flower to match against. However, the port
dissection is not done when when the FLOW_DIS_IS_FRAGMENT bit is set in
key_control->flags. All callers of __skb_flow_dissect(), zero-out the
key_control field except for fl_classify() as used by the flower
classifier. Thus, the FLOW_DIS_IS_FRAGMENT may be set on entry to
__skb_flow_dissect(), since key_control is allocated on the stack
and may not be initialized.
Since key_basic and key_control are present for all flow keys, let's
make sure they are initialized.
Fixes: 62230715fd24 ("flow_dissector: do not dissect l4 ports for fragments")
Co-developed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: Jason Baron <jbaron@akamai.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2020-02-17 21:33:28 -08:00
..
2019-05-30 11:29:21 -07:00
2020-01-15 22:28:51 +01:00
2019-05-30 11:29:22 -07:00
2018-09-26 09:56:07 -07:00
2020-01-27 08:54:30 +01:00
2020-01-26 10:40:21 +01:00
2019-06-19 17:09:07 +02:00
2019-06-05 17:37:07 +02:00
2019-11-25 14:57:26 -08:00
2019-09-16 09:18:03 +02:00
2019-11-12 12:11:22 -08:00
2019-12-16 16:09:44 -08:00
2019-05-30 11:26:41 -07:00
2019-05-30 11:26:32 -07:00
2019-12-12 17:04:55 -08:00
2019-12-11 15:01:23 -08:00
2017-11-02 11:10:55 +01:00
2019-11-06 16:14:48 -08:00
2017-11-02 11:10:55 +01:00
2019-01-23 11:18:00 -08:00
2019-06-19 17:09:55 +02:00
2019-05-24 17:37:53 +02:00
2019-05-21 11:28:40 +02:00
2019-07-04 12:30:48 -07:00
2019-11-05 17:40:16 -08:00
2019-08-17 23:18:54 +02:00
2019-10-30 17:34:35 -07:00
2019-05-21 11:28:45 +02:00
2019-06-19 17:09:55 +02:00
2020-01-15 09:50:48 +01:00
2019-05-30 11:26:41 -07:00
2019-05-30 11:26:32 -07:00
2019-05-21 11:28:45 +02:00
2019-05-30 11:26:32 -07:00
2019-04-19 14:07:40 -07:00
2017-11-02 11:10:55 +01:00
2019-05-30 11:29:52 -07:00
2019-05-30 11:29:52 -07:00
2020-01-27 11:33:29 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2019-05-21 11:52:39 +02:00
2019-05-21 11:52:39 +02:00
2017-11-04 09:26:51 +09:00
2019-08-17 12:40:08 -07:00
2020-01-08 16:01:13 -08:00
2019-12-16 16:09:44 -08:00
2018-03-05 12:52:45 -05:00
2017-11-04 09:26:51 +09:00
2019-12-24 22:28:54 -08:00
2019-12-24 22:28:55 -08:00
2018-05-20 18:31:42 -04:00
2017-11-02 11:10:55 +01:00
2019-12-09 09:59:07 +01:00
2019-06-19 17:09:55 +02:00
2018-05-28 22:59:54 -04:00
2019-12-24 22:37:30 -08:00
2019-10-04 11:10:56 -07:00
2017-11-02 11:10:55 +01:00
2020-02-17 21:33:28 -08:00
2019-12-06 20:45:09 -08:00
2019-02-27 12:50:17 -08:00
2017-11-02 11:10:55 +01:00
2019-11-08 09:11:49 +01:00
2019-10-23 20:13:22 -07:00
2019-12-09 10:36:44 -08:00
2019-11-05 18:20:55 -08:00
2019-10-06 15:44:47 +02:00
2019-03-22 12:09:31 -07:00
2018-12-10 15:53:04 -08:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2019-07-01 10:58:23 -07:00
2019-10-25 16:24:32 -07:00
2020-02-13 14:19:00 -08:00
2019-02-22 12:56:24 -08:00
2019-05-30 11:26:41 -07:00
2019-08-28 14:43:03 -07:00
2019-04-22 21:50:53 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2019-07-03 13:51:54 -07:00
2019-08-31 23:44:28 -07:00
2018-10-17 17:45:07 -07:00
2019-08-08 15:55:10 -07:00
2019-12-13 21:40:49 -08:00
2019-09-13 21:44:19 +02:00
2019-09-27 12:05:02 +02:00
2019-02-08 21:50:15 -08:00
2019-05-30 11:26:32 -07:00
2020-01-14 18:53:35 -08:00
2019-06-27 21:06:39 -07:00
2019-06-18 20:48:45 -04:00
2020-01-14 18:53:35 -08:00
2019-12-09 10:36:44 -08:00
2019-11-02 13:54:56 -07:00
2019-12-07 11:55:11 -08:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2019-06-19 11:37:47 -04:00
2019-12-04 12:27:13 -08:00
2020-01-25 08:14:39 +01:00
2020-02-05 14:28:09 +01:00
2018-03-27 09:51:23 +02:00
2019-06-19 17:09:55 +02:00
2019-05-30 11:26:32 -07:00
2018-07-11 23:10:19 -07:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2019-10-08 13:23:05 -07:00
2018-09-13 09:04:58 -07:00
2019-04-23 19:42:29 -07:00
2020-02-07 11:32:27 +01:00
2019-05-30 11:26:41 -07:00
2020-01-14 11:31:41 -08:00
2019-05-21 11:28:45 +02:00
2017-11-02 11:10:55 +01:00
2019-06-05 17:36:38 +02:00
2019-06-05 17:36:38 +02:00
2020-01-30 10:55:54 +01:00
2019-12-09 10:36:44 -08:00
2017-11-02 11:10:55 +01:00
2019-11-06 16:14:48 -08:00
2019-12-09 09:48:47 -08:00
2018-05-28 22:59:54 -04:00
2020-01-17 13:25:24 +01:00
2017-11-02 11:10:55 +01:00
2018-08-01 09:52:30 -07:00
2019-05-21 11:28:45 +02:00
2019-12-12 17:07:05 -08:00
2019-11-12 08:18:03 -08:00
2019-04-11 13:59:49 -07:00
2019-09-05 12:35:58 +02:00
2017-11-08 16:12:33 +09:00
2017-11-02 11:10:55 +01:00
2019-11-20 12:34:28 -08:00
2020-01-23 11:38:31 +01:00
2019-05-30 11:26:32 -07:00
2020-01-27 10:51:43 +01:00
2019-09-17 23:51:10 +02:00
2017-11-02 11:10:55 +01:00
2019-05-30 11:26:32 -07:00
2019-09-16 09:18:03 +02:00
2017-11-02 11:10:55 +01:00
2019-05-30 11:26:32 -07:00
2017-11-02 11:10:55 +01:00
2017-12-05 14:37:13 -05:00
2018-08-28 11:11:47 +02:00
2019-10-09 21:34:31 -07:00
2018-05-16 07:23:35 +02:00
2019-11-21 14:45:55 -08:00
2018-03-13 18:37:02 +02:00
2018-11-06 15:00:45 -08:00
2019-04-22 21:47:25 -07:00
2020-01-27 10:51:43 +01:00
2018-07-21 10:43:12 -05:00
2017-11-02 11:10:55 +01:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2018-04-11 10:33:46 -04:00
2019-11-15 12:28:28 -08:00
2019-10-05 16:29:00 -07:00
2019-09-16 09:02:18 +02:00
2020-02-16 19:43:06 -08:00
2018-03-01 21:21:36 -05:00
2017-11-02 11:10:55 +01:00
2019-06-19 17:09:55 +02:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2020-01-23 08:10:16 +01:00
2019-05-30 11:26:32 -07:00
2018-05-08 00:02:41 -04:00
2019-10-04 14:07:07 -07:00
2019-12-19 17:46:51 -08:00
2018-07-07 10:58:49 +09:00
2017-11-02 11:10:55 +01:00
2019-03-29 10:53:45 -07:00
2020-01-30 09:59:53 +01:00
2018-02-16 15:57:42 -05:00
2019-11-14 18:12:17 -08:00
2019-10-24 14:53:49 -07:00
2018-01-24 19:13:45 -05:00
2019-06-05 17:30:29 +02:00
2019-12-09 10:28:43 -08:00
2017-11-02 11:10:55 +01:00
2019-11-16 12:39:10 -08:00
2019-12-20 16:00:09 -08:00
2019-06-19 11:23:13 -04:00
2019-12-09 09:59:07 +01:00