Peter Malone 250c6c49e3 fbdev: Fixing arbitrary kernel leak in case FBIOGETCMAP_SPARC in sbusfb_ioctl_helper().
Fixing arbitrary kernel leak in case FBIOGETCMAP_SPARC in
sbusfb_ioctl_helper().

'index' is defined as an int in sbusfb_ioctl_helper().
We retrieve this from the user:
if (get_user(index, &c->index) ||
    __get_user(count, &c->count) ||
    __get_user(ured, &c->red) ||
    __get_user(ugreen, &c->green) ||
    __get_user(ublue, &c->blue))
       return -EFAULT;

and then we use 'index' in the following way:
red = cmap->red[index + i] >> 8;
green = cmap->green[index + i] >> 8;
blue = cmap->blue[index + i] >> 8;

This is a classic information leak vulnerability. 'index' should be
an unsigned int, given its usage above.

This patch is straight-forward; it changes 'index' to unsigned int
in two switch-cases: FBIOGETCMAP_SPARC && FBIOPUTCMAP_SPARC.

This patch fixes CVE-2018-6412.

Signed-off-by: Peter Malone <peter.malone@gmail.com>
Acked-by: Mathieu Malaterre <malat@debian.org>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
2018-03-07 14:00:34 +01:00
..
2017-12-04 23:03:22 +01:00
2017-11-20 21:50:24 -10:00
2018-01-15 17:04:22 +01:00
2017-11-20 21:50:24 -10:00
2017-02-25 13:20:22 -08:00
2017-09-04 16:00:49 +02:00
2016-02-26 13:28:35 +02:00
2018-02-07 13:10:43 -08:00
2016-02-26 13:28:35 +02:00
2017-09-04 16:00:49 +02:00
2015-10-08 12:19:39 +03:00
2017-05-27 15:41:17 -04:00
2018-02-09 19:32:41 -08:00
2017-11-20 21:50:24 -10:00
2017-09-22 23:14:36 -04:00
2017-09-14 13:33:33 -07:00
2018-01-09 16:33:31 +01:00
2017-05-11 11:12:26 -07:00