Jaegeuk Kim
0bf5c6a1e4
f2fs: should use GFP_NOFS for directory inodes ...
commit 92d602bc7177325e7453189a22e0c8764ed3453e upstream.
We use inline_dentry which requires to allocate dentry page when adding a link.
If we allow to reclaim memory from filesystem, we do down_read(&sbi->cp_rwsem)
twice by f2fs_lock_op(). I think this should be okay, but how about stopping
the lockdep complaint [1]?
f2fs_create()
- f2fs_lock_op()
- f2fs_do_add_link()
- __f2fs_find_entry
- f2fs_get_read_data_page()
-> kswapd
- shrink_node
- f2fs_evict_inode
- f2fs_lock_op()
[1]
fs_reclaim
){+.+.}-{0:0}
:
kswapd0: lock_acquire+0x114/0x394
kswapd0: __fs_reclaim_acquire+0x40/0x50
kswapd0: prepare_alloc_pages+0x94/0x1ec
kswapd0: __alloc_pages_nodemask+0x78/0x1b0
kswapd0: pagecache_get_page+0x2e0/0x57c
kswapd0: f2fs_get_read_data_page+0xc0/0x394
kswapd0: f2fs_find_data_page+0xa4/0x23c
kswapd0: find_in_level+0x1a8/0x36c
kswapd0: __f2fs_find_entry+0x70/0x100
kswapd0: f2fs_do_add_link+0x84/0x1ec
kswapd0: f2fs_mkdir+0xe4/0x1e4
kswapd0: vfs_mkdir+0x110/0x1c0
kswapd0: do_mkdirat+0xa4/0x160
kswapd0: __arm64_sys_mkdirat+0x24/0x34
kswapd0: el0_svc_common.llvm.17258447499513131576+0xc4/0x1e8
kswapd0: do_el0_svc+0x28/0xa0
kswapd0: el0_svc+0x24/0x38
kswapd0: el0_sync_handler+0x88/0xec
kswapd0: el0_sync+0x1c0/0x200
kswapd0:
-> #1
(
&sbi->cp_rwsem
){++++}-{3:3}
:
kswapd0: lock_acquire+0x114/0x394
kswapd0: down_read+0x7c/0x98
kswapd0: f2fs_do_truncate_blocks+0x78/0x3dc
kswapd0: f2fs_truncate+0xc8/0x128
kswapd0: f2fs_evict_inode+0x2b8/0x8b8
kswapd0: evict+0xd4/0x2f8
kswapd0: iput+0x1c0/0x258
kswapd0: do_unlinkat+0x170/0x2a0
kswapd0: __arm64_sys_unlinkat+0x4c/0x68
kswapd0: el0_svc_common.llvm.17258447499513131576+0xc4/0x1e8
kswapd0: do_el0_svc+0x28/0xa0
kswapd0: el0_svc+0x24/0x38
kswapd0: el0_sync_handler+0x88/0xec
kswapd0: el0_sync+0x1c0/0x200
Cc: stable@vger.kernel.org
Fixes: bdbc90fa55af ("f2fs: don't put dentry page in pagecache into highmem")
Reviewed-by: Chao Yu <chao@kernel.org>
Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>
Reviewed-by: Light Hsieh <light.hsieh@mediatek.com>
Tested-by: Light Hsieh <light.hsieh@mediatek.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-11-18 14:04:29 +01:00
2021-09-08 08:49:01 +02:00
2020-10-24 12:26:05 -07:00
2021-03-04 11:38:37 +01:00
2021-09-30 10:11:01 +02:00
2020-10-16 11:11:22 -07:00
2020-09-18 16:45:50 -04:00
2021-01-06 14:56:52 +01:00
2021-11-18 14:04:00 +01:00
2021-03-30 14:32:07 +02:00
2021-10-27 09:56:51 +02:00
2021-10-09 14:40:57 +02:00
2021-07-14 16:56:48 +02:00
2020-09-18 16:45:50 -04:00
2021-11-18 14:03:54 +01:00
2021-10-06 15:55:59 +02:00
2021-07-14 16:55:59 +02:00
2021-05-26 12:06:55 +02:00
2020-11-25 16:55:02 +01:00
2020-09-18 16:45:50 -04:00
2021-11-18 14:04:01 +01:00
2021-11-18 14:03:37 +01:00
2021-10-09 14:40:56 +02:00
2021-11-18 14:03:40 +01:00
2021-11-18 14:04:29 +01:00
2020-09-18 16:45:50 -04:00
2021-09-18 13:40:15 +02:00
2021-11-18 14:03:40 +01:00
2021-11-18 14:04:00 +01:00
2021-07-31 08:16:12 +02:00
2021-05-19 10:13:10 +02:00
2021-04-14 08:42:06 +02:00
2020-09-18 16:45:50 -04:00
2021-07-28 14:35:46 +02:00
2021-09-30 10:11:04 +02:00
2021-11-12 14:58:33 +01:00
2021-05-19 10:13:19 +02:00
2021-05-11 14:47:36 +02:00
2021-11-18 14:04:15 +01:00
2021-01-27 11:55:29 +01:00
2021-09-18 13:40:30 +02:00
2020-09-18 16:45:50 -04:00
2021-11-18 14:04:25 +01:00
2020-12-30 11:53:45 +01:00
2021-10-27 09:56:47 +02:00
2021-09-26 14:09:01 +02:00
2021-09-18 13:40:38 +02:00
2021-07-14 16:55:38 +02:00
2021-11-18 14:03:37 +01:00
2020-09-22 23:39:45 -04:00
2021-11-18 14:04:23 +01:00
2021-11-18 14:03:49 +01:00
2021-11-18 14:03:56 +01:00
2021-07-14 16:56:12 +02:00
2021-09-30 10:11:08 +02:00
2020-09-18 16:45:50 -04:00
2021-11-18 14:03:51 +01:00
2020-10-16 11:11:22 -07:00
2021-08-12 13:22:19 +02:00
2020-10-24 12:26:05 -07:00
2021-05-19 10:13:10 +02:00
2020-10-02 12:02:30 +02:00
2020-09-18 16:45:50 -04:00
2021-11-18 14:03:56 +01:00
2021-09-30 10:11:04 +02:00
2021-09-15 09:50:27 +02:00
2020-10-24 12:26:05 -07:00
2020-09-10 14:03:31 -07:00
2021-10-17 10:43:33 +02:00
2021-10-06 15:55:46 +02:00
2021-09-30 10:11:04 +02:00
2021-03-25 09:04:05 +01:00
2020-11-10 16:53:07 -08:00
2020-10-16 11:11:21 -07:00
2021-10-06 15:55:59 +02:00
2021-03-17 17:06:35 +01:00
2021-06-03 09:00:45 +02:00
2020-10-18 09:27:09 -07:00
2021-09-26 14:08:56 +02:00
2020-10-14 14:54:45 -07:00
2021-07-14 16:56:13 +02:00
2021-04-14 08:41:58 +02:00
2021-05-11 14:47:12 +02:00
2021-09-08 08:49:00 +02:00
2021-09-15 09:50:27 +02:00
2020-10-17 15:05:30 -06:00
2021-01-30 13:55:18 +01:00
2020-10-13 18:38:27 -07:00
2021-07-14 16:56:31 +02:00
2020-12-30 11:53:49 +01:00
2021-07-31 08:16:11 +02:00
2021-11-06 14:10:08 +01:00
2021-09-18 13:40:06 +02:00
2021-02-13 13:54:56 +01:00
2021-02-17 11:02:21 +01:00
2021-10-27 09:56:51 +02:00
2020-11-22 10:48:22 -08:00
2021-03-20 10:43:44 +01:00
2020-10-23 11:33:41 -07:00
2021-04-14 08:41:58 +02:00
2021-08-26 08:35:57 -04:00
2021-07-14 16:55:59 +02:00
2021-09-03 10:09:28 +02:00
2021-03-17 17:06:13 +01:00
2020-12-30 11:54:02 +01:00
2020-10-23 11:33:41 -07:00
2021-04-21 13:00:54 +02:00
2020-10-15 09:48:49 -07:00
2021-03-25 09:04:16 +01:00
2021-07-20 16:05:59 +02:00
2020-10-24 12:40:18 -07:00
2021-05-11 14:47:33 +02:00
2020-11-10 16:53:11 -08:00
2021-10-27 09:56:51 +02:00
2020-10-13 18:38:27 -07:00
0bf5c6a1e4