linux

iv/linux

History

Mat Martineau b5177ed92b mptcp: Do not return EINPROGRESS when subflow creation succeeds

New subflows are created within the kernel using O_NONBLOCK, so
EINPROGRESS is the expected return value from kernel_connect().
__mptcp_subflow_connect() has the correct logic to consider EINPROGRESS
to be a successful case, but it has also used that error code as its
return value.

Before v5.19 this was benign: all the callers ignored the return
value. Starting in v5.19 there is a MPTCP_PM_CMD_SUBFLOW_CREATE generic
netlink command that does use the return value, so the EINPROGRESS gets
propagated to userspace.

Make __mptcp_subflow_connect() always return 0 on success instead.

Fixes: ec3edaa7ca6c ("mptcp: Add handling of outgoing MP_JOIN requests")
Fixes: 702c2f646d42 ("mptcp: netlink: allow userspace-driven subflow establishment")
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Link: https://lore.kernel.org/r/20220725205231.87529-1-mathew.j.martineau@linux.intel.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

2022-07-26 19:57:55 -07:00

bpf.c

bpf: Add bpf_skc_to_mptcp_sock_proto

2022-05-20 15:29:00 -07:00

crypto_test.c

mptcp: move crypto test to KUNIT

2020-06-26 16:21:39 -07:00

crypto.c

kunit: mptcp: adhere to KUNIT formatting standard

2021-04-16 17:10:40 -07:00

ctrl.c

mptcp: Add a per-namespace sysctl to set the default path manager type