Paolo Abeni 9bd780f5e0 udp: fix poll() ...

Michael reported an UDP breakage caused by the commit b65ac44674dd
("udp: try to avoid 2 cache miss on dequeue").
The function __first_packet_length() can update the checksum bits
of the pending skb, making the scratched area out-of-sync, and
setting skb->csum, if the skb was previously in need of checksum
validation.

On later recvmsg() for such skb, checksum validation will be
invoked again - due to the wrong udp_skb_csum_unnecessary()
value - and will fail, causing the valid skb to be dropped.

This change addresses the issue refreshing the scratch area in
__first_packet_length() after the possible checksum update.

Fixes: b65ac44674dd ("udp: try to avoid 2 cache miss on dequeue")
Reported-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

2017-06-23 11:18:43 -04:00

..

netfilter

networking: make skb_put & friends return void pointers

2017-06-16 11:48:39 -04:00

af_inet.c

net: ping: do not abuse udp_poll()

2017-06-04 22:56:55 -04:00

ah4.c

ipsec: check return value of skb_to_sgvec always

2017-06-04 23:01:47 -04:00

arp.c

networking: make skb_put & friends return void pointers

2017-06-16 11:48:39 -04:00

cipso_ipv4.c

netlabel: out of bound access in cipso_v4_validate()

2017-02-04 19:44:22 -05:00

datagram.c

net: Set sk_txhash from a random number

2015-07-29 22:44:04 -07:00

devinet.c

Ipvlan should return an error when an address is already in use.

2017-06-09 12:26:07 -04:00

esp4_offload.c

esp4/6: Fix GSO path for non-GSO SW-crypto packets

2017-04-19 07:48:57 +02:00

esp4.c

networking: make skb_push & __skb_push return void pointers

2017-06-16 11:48:40 -04:00

fib_frontend.c

net: lwtunnel: Add extack to encap attr validation

2017-05-30 11:55:31 -04:00

fib_lookup.h

net: add extack arg to lwtunnel build state

2017-05-30 11:55:32 -04:00

fib_notifier.c

ipv4: fib: Remove redundant argument

2017-03-10 09:45:09 -08:00

fib_rules.c

ipv4: fib_rules: Dump FIB rules when registering FIB notifier

2017-03-16 10:18:34 -07:00

fib_semantics.c

ipv4: mark DST_NOGC and remove the operation of dst_free()

2017-06-17 22:54:00 -04:00

fib_trie.c

net: add extack arg to lwtunnel build state

2017-05-30 11:55:32 -04:00

fou.c

fou: make local function static

2017-05-21 13:42:36 -04:00

gre_demux.c

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

2016-06-30 05:03:36 -04:00

gre_offload.c

net: add recursion limit to GRO

2016-10-20 14:32:22 -04:00

icmp.c

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

2017-06-15 11:59:32 -04:00

igmp.c

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

2017-06-21 17:35:22 -04:00

inet_connection_sock.c

dccp: consistently use dccp_write_space()

2017-06-04 19:58:35 -04:00

inet_diag.c

tcp: remove early retransmit

2017-01-13 22:37:16 -05:00

inet_fragment.c

net: disable fragment reassembly if high_thresh is zero

2016-06-05 22:56:42 -04:00

inet_hashtables.c

treewide: use kv[mz]alloc* rather than opencoded variants

2017-05-08 17:15:13 -07:00

inet_timewait_sock.c

ipv4: Namespaceify tcp_tw_recycle and tcp_max_tw_buckets knob

2016-12-29 11:38:31 -05:00

inetpeer.c

net: Add helper function to compare inetpeer addresses

2015-08-28 13:32:36 -07:00

ip_forward.c

ipv4: allow local fragmentation in ip_finish_output_gso()

2016-11-03 16:10:26 -04:00

ip_fragment.c

inet: frag: release spinlock before calling icmp_send()

2017-03-22 15:40:45 -07:00

ip_gre.c

networking: make skb_push & __skb_push return void pointers

2017-06-16 11:48:40 -04:00

ip_input.c

net: Add sysctl to toggle early demux for tcp and udp

2017-03-24 13:17:07 -07:00

ip_options.c

Replace <asm/uaccess.h> with <linux/uaccess.h> globally

2016-12-24 11:46:01 -08:00

ip_output.c

udp: avoid ufo handling on IP payload compression packets

2017-03-09 18:28:42 -08:00

ip_sockglue.c

ipv4: get rid of ip_ra_lock

2017-04-30 22:44:04 -04:00

ip_tunnel_core.c

net: add extack arg to lwtunnel build state

2017-05-30 11:55:32 -04:00

ip_tunnel.c

ip_tunnel: fix potential issue in ip_tunnel_rcv

2017-06-16 12:01:29 -04:00

ip_vti.c

vti: check nla_put_* return value

2017-05-08 15:10:31 -04:00

ipcomp.c

ipv4: coding style: comparison for equality with NULL

2015-04-03 12:11:15 -04:00

ipconfig.c

networking: convert many more places to skb_put_zero()

2017-06-16 11:48:35 -04:00

ipip.c

ip_tunnel: Allow policy-based routing through tunnels

2017-04-21 13:21:31 -04:00

ipmr.c

ipmr: add netlink notifications on igmpmsg cache reports

2017-06-21 11:22:52 -04:00

Kconfig

Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next

2017-02-16 21:25:49 -05:00

Makefile

tcp: ULP infrastructure

2017-06-15 12:12:40 -04:00

netfilter.c

netfilter: use skb_to_full_sk in ip_route_me_harder

2017-02-28 12:49:36 +01:00

ping.c

ping: implement proper locking

2017-03-24 20:50:28 -07:00

proc.c

tcp: add TCPMemoryPressuresChrono counter

2017-06-08 11:26:19 -04:00

protocol.c

net: Add sysctl to toggle early demux for tcp and udp

2017-03-24 13:17:07 -07:00

raw_diag.c

net: ip, raw_diag -- Use jump for exiting from nested loop

2016-11-03 15:25:26 -04:00

raw.c

ipv4, ipv6: ensure raw socket message is big enough to hold an IP header

2017-05-04 11:02:46 -04:00

route.c

net: remove DST_NOCACHE flag

2017-06-17 22:54:01 -04:00

syncookies.c

tcp: Namespaceify sysctl_tcp_timestamps

2017-06-08 10:53:29 -04:00

sysctl_net_ipv4.c

tcp: ULP infrastructure

2017-06-15 12:12:40 -04:00

tcp_bbr.c

tcp: switch TCP TS option (RFC 7323) to 1ms clock

2017-05-17 16:06:01 -04:00

tcp_bic.c

tcp: bic, cubic: use tcp_jiffies32 instead of tcp_time_stamp

2017-05-17 16:06:01 -04:00

tcp_cdg.c

sched/headers: Prepare for new header dependencies before moving code to <linux/sched/clock.h>

2017-03-02 08:42:27 +01:00

tcp_cong.c

tcp: disallow cwnd undo when switching congestion control

2017-06-02 14:18:13 -04:00

tcp_cubic.c

tcp: bic, cubic: use tcp_jiffies32 instead of tcp_time_stamp

2017-05-17 16:06:01 -04:00

tcp_dctcp.c

Revert "dctcp: update cwnd on congestion event"

2016-12-06 11:34:24 -05:00

tcp_diag.c

net: diag: Fix refcnt leak in error path destroying socket

2016-08-23 23:11:36 -07:00

tcp_fastopen.c

net/tcp_fastopen: Add snmp counter for blackhole detection

2017-04-24 14:27:17 -04:00

tcp_highspeed.c

tcp: add cwnd_undo functions to various tcp cc algorithms

2016-11-21 13:20:17 -05:00

tcp_htcp.c

tcp: replace misc tcp_time_stamp to tcp_jiffies32

2017-05-17 16:06:01 -04:00

tcp_hybla.c

tcp: make undo_cwnd mandatory for congestion modules

2016-11-21 13:20:17 -05:00

tcp_illinois.c

tcp: add cwnd_undo functions to various tcp cc algorithms

2016-11-21 13:20:17 -05:00

tcp_input.c

tcp: Namespaceify sysctl_tcp_timestamps

2017-06-08 10:53:29 -04:00

tcp_ipv4.c

tcp: Add a tcp_filter hook before handle ack packet

2017-06-22 11:13:56 -04:00

tcp_lp.c

tcp: switch TCP TS option (RFC 7323) to 1ms clock

2017-05-17 16:06:01 -04:00

tcp_metrics.c

tcp: use tcp_jiffies32 to feed tp->snd_cwnd_stamp

2017-05-17 16:06:01 -04:00

tcp_minisocks.c

tcp: add a struct net parameter to tcp_parse_options()

2017-06-08 10:53:28 -04:00

tcp_nv.c

tcpnv: do not export local function

2017-05-21 13:42:36 -04:00

tcp_offload.c

gso: Support partial splitting at the frag_list pointer

2016-09-19 20:59:34 -04:00

tcp_output.c

tcp: Namespaceify sysctl_tcp_timestamps

2017-06-08 10:53:29 -04:00

tcp_probe.c

tcp: Revert "tcp: tcp_probe: use spin_lock_bh()"

2017-02-21 13:26:03 -05:00

tcp_rate.c

tcp: export do_tcp_sendpages and tcp_rate_check_app_limited functions

2017-06-15 12:12:40 -04:00

tcp_recovery.c

tcp: switch TCP TS option (RFC 7323) to 1ms clock

2017-05-17 16:06:01 -04:00

tcp_scalable.c

tcp: add cwnd_undo functions to various tcp cc algorithms

2016-11-21 13:20:17 -05:00

tcp_timer.c

tcp: fix TCP_SYNCNT flakes

2017-05-24 16:29:57 -04:00

tcp_ulp.c

tcp: ULP infrastructure

2017-06-15 12:12:40 -04:00

tcp_vegas.c

tcp: make undo_cwnd mandatory for congestion modules

2016-11-21 13:20:17 -05:00

tcp_vegas.h

tcp: replace cnt & rtt with struct in pkts_acked()

2016-05-11 14:43:19 -04:00

tcp_veno.c

tcp: add cwnd_undo functions to various tcp cc algorithms

2016-11-21 13:20:17 -05:00

tcp_westwood.c

tcp_westwood: use tcp_jiffies32 instead of tcp_time_stamp

2017-05-17 16:06:01 -04:00

tcp_yeah.c

tcp: add cwnd_undo functions to various tcp cc algorithms

2016-11-21 13:20:17 -05:00

tcp.c

tcp: md5: add TCP_MD5SIG_EXT socket option to set a key address prefix

2017-06-19 13:51:34 -04:00

tunnel4.c

tunnels: correct conditional build of MPLS and IPv6

2016-07-11 13:27:06 -07:00

udp_diag.c

net: inet: diag: expose the socket mark to privileged processes.

2016-09-08 16:13:09 -07:00

udp_impl.h

udp: make *udp*_queue_rcv_skb() functions static

2017-05-18 10:23:33 -04:00

udp_offload.c

udp: disable inner UDP checksum offloads in IPsec case

2017-04-24 13:48:54 -04:00

udp_tunnel.c

net: Remove deprecated tunnel specific UDP offload functions

2016-06-17 20:23:32 -07:00

udp.c

udp: fix poll()

2017-06-23 11:18:43 -04:00

udplite.c

udplite: call proper backlog handlers

2016-11-24 15:32:14 -05:00

xfrm4_input.c

esp: Add a software GRO codepath

2017-02-15 11:04:11 +01:00

xfrm4_mode_beet.c

networking: make skb_pull & friends return void pointers

2017-06-16 11:48:39 -04:00

xfrm4_mode_transport.c

xfrm: Add encapsulation header offsets while SKB is not encrypted

2017-04-14 10:07:39 +02:00

xfrm4_mode_tunnel.c

xfrm: Add encapsulation header offsets while SKB is not encrypted

2017-04-14 10:07:39 +02:00

xfrm4_output.c

xfrm: Add an IPsec hardware offloading API

2017-04-14 10:06:10 +02:00

xfrm4_policy.c

xfrm: policy: make policy backend const

2017-02-09 10:22:19 +01:00

xfrm4_protocol.c

xfrm: input: constify xfrm_input_afinfo

2017-02-09 10:22:17 +01:00

xfrm4_state.c

xfrm: remove unused function

2017-01-10 10:57:12 +01:00

xfrm4_tunnel.c

sit: add IPv4 over IPv4 support

2013-05-31 17:19:05 -07:00