Files
linux/net/tipc
Junwei Hu 5bce46edeb tipc: fix modprobe tipc failed after switch order of device registration -v2
commit 526f5b851a upstream.

Error message printed:
modprobe: ERROR: could not insert 'tipc': Address family not
supported by protocol.
when modprobe tipc after the following patch: switch order of
device registration, commit 7e27e8d613
("tipc: switch order of device registration to fix a crash")

Because sock_create_kern(net, AF_TIPC, ...) called by
tipc_topsrv_create_listener() in the initialization process
of tipc_init_net(), so tipc_socket_init() must be execute before that.
Meanwhile, tipc_net_id need to be initialized when sock_create()
called, and tipc_socket_init() is no need to be called for each namespace.

I add a variable tipc_topsrv_net_ops, and split the
register_pernet_subsys() of tipc into two parts, and split
tipc_socket_init() with initialization of pernet params.

By the way, I fixed resources rollback error when tipc_bcast_init()
failed in tipc_init_net().

Fixes: 7e27e8d613 ("tipc: switch order of device registration to fix a crash")
Signed-off-by: Junwei Hu <hujunwei4@huawei.com>
Reported-by: Wang Wang <wangwang2@huawei.com>
Reported-by: syzbot+1e8114b61079bfe9cbc5@syzkaller.appspotmail.com
Reviewed-by: Kang Zhou <zhoukang7@huawei.com>
Reviewed-by: Suanming Mou <mousuanming@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-06-11 12:24:07 +02:00
..
2015-05-14 12:24:45 -04:00
2015-05-14 12:24:45 -04:00
2016-03-03 15:07:07 -08:00
2017-04-30 05:49:28 +02:00
2017-04-30 05:49:28 +02:00
2017-04-30 05:49:27 +02:00
2015-03-05 22:08:42 -05:00
2015-03-05 22:08:42 -05:00
2018-04-29 07:50:06 +02:00
2017-04-30 05:49:27 +02:00
2017-04-30 05:49:28 +02:00
2017-04-30 05:49:28 +02:00