iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net
History
Eric Dumazet 33e1cea2dc net: add annotations on hh->hh_len lockless accesses 
[ Upstream commit c305c6ae79e2ce20c22660ceda94f0d86d639a82 ]

KCSAN reported a data-race [1]

While we can use READ_ONCE() on the read sides,
we need to make sure hh->hh_len is written last.

[1]

BUG: KCSAN: data-race in eth_header_cache / neigh_resolve_output

write to 0xffff8880b9dedcb8 of 4 bytes by task 29760 on cpu 0:
 eth_header_cache+0xa9/0xd0 net/ethernet/eth.c:247
 neigh_hh_init net/core/neighbour.c:1463 [inline]
 neigh_resolve_output net/core/neighbour.c:1480 [inline]
 neigh_resolve_output+0x415/0x470 net/core/neighbour.c:1470
 neigh_output include/net/neighbour.h:511 [inline]
 ip6_finish_output2+0x7a2/0xec0 net/ipv6/ip6_output.c:116
 __ip6_finish_output net/ipv6/ip6_output.c:142 [inline]
 __ip6_finish_output+0x2d7/0x330 net/ipv6/ip6_output.c:127
 ip6_finish_output+0x41/0x160 net/ipv6/ip6_output.c:152
 NF_HOOK_COND include/linux/netfilter.h:294 [inline]
 ip6_output+0xf2/0x280 net/ipv6/ip6_output.c:175
 dst_output include/net/dst.h:436 [inline]
 NF_HOOK include/linux/netfilter.h:305 [inline]
 ndisc_send_skb+0x459/0x5f0 net/ipv6/ndisc.c:505
 ndisc_send_ns+0x207/0x430 net/ipv6/ndisc.c:647
 rt6_probe_deferred+0x98/0xf0 net/ipv6/route.c:615
 process_one_work+0x3d4/0x890 kernel/workqueue.c:2269
 worker_thread+0xa0/0x800 kernel/workqueue.c:2415
 kthread+0x1d4/0x200 drivers/block/aoe/aoecmd.c:1253
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:352

read to 0xffff8880b9dedcb8 of 4 bytes by task 29572 on cpu 1:
 neigh_resolve_output net/core/neighbour.c:1479 [inline]
 neigh_resolve_output+0x113/0x470 net/core/neighbour.c:1470
 neigh_output include/net/neighbour.h:511 [inline]
 ip6_finish_output2+0x7a2/0xec0 net/ipv6/ip6_output.c:116
 __ip6_finish_output net/ipv6/ip6_output.c:142 [inline]
 __ip6_finish_output+0x2d7/0x330 net/ipv6/ip6_output.c:127
 ip6_finish_output+0x41/0x160 net/ipv6/ip6_output.c:152
 NF_HOOK_COND include/linux/netfilter.h:294 [inline]
 ip6_output+0xf2/0x280 net/ipv6/ip6_output.c:175
 dst_output include/net/dst.h:436 [inline]
 NF_HOOK include/linux/netfilter.h:305 [inline]
 ndisc_send_skb+0x459/0x5f0 net/ipv6/ndisc.c:505
 ndisc_send_ns+0x207/0x430 net/ipv6/ndisc.c:647
 rt6_probe_deferred+0x98/0xf0 net/ipv6/route.c:615
 process_one_work+0x3d4/0x890 kernel/workqueue.c:2269
 worker_thread+0xa0/0x800 kernel/workqueue.c:2415
 kthread+0x1d4/0x200 drivers/block/aoe/aoecmd.c:1253
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:352

Reported by Kernel Concurrency Sanitizer on:
CPU: 1 PID: 29572 Comm: kworker/1:4 Not tainted 5.4.0-rc6+ #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: events rt6_probe_deferred

Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2020-01-09 10:17:59 +01:00
..
6lowpan
6lowpan: iphc: reset mac_header after decompress to fix panic
2018-10-03 17:00:47 -07:00
9p
9p/virtio: Add cleanup path in p9_virtio_init
2019-07-31 07:28:39 +02:00
802
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
8021q
vlan: disable SIOCSHWTSTAMP in container
2019-05-16 19:42:34 +02:00
appletalk
appletalk: Set error code if register_snap_client failed
2019-12-17 20:38:59 +01:00
atm
net: use skb_queue_empty_lockless() in poll() handlers
2019-11-10 11:25:34 +01:00
ax25
ax25: enforce CAP_NET_RAW for raw sockets
2019-10-05 12:47:43 +02:00
batman-adv
batman-adv: Only read OGM2 tvlv_len after buffer len check
2019-09-21 07:15:35 +02:00
bluetooth
Bluetooth: Fix memory leak in hci_connect_le_scan
2020-01-09 10:17:57 +01:00
bpf
…
bridge
net: add bool confirm_neigh parameter for dst_ops.update_pmtu
2020-01-04 14:00:14 +01:00
caif
net: use skb_queue_empty_lockless() in poll() handlers
2019-11-10 11:25:34 +01:00
can
can: af_can: Fix error path of can_init()
2019-07-21 09:04:22 +02:00
ceph
libceph: fix PG split vs OSD (re)connect race
2019-08-29 08:26:42 +02:00
core
net: add annotations on hh->hh_len lockless accesses
2020-01-09 10:17:59 +01:00
dcb
net: dcb: For wild-card lookups, use priority -1, not 0
2018-09-19 22:43:43 +02:00
dccp
inet: stop leaking jiffies on the wire
2019-11-10 11:25:37 +01:00
decnet
net: add bool confirm_neigh parameter for dst_ops.update_pmtu
2020-01-04 14:00:14 +01:00
dns_resolver
KEYS: DNS: fix parsing multiple options
2018-07-22 14:28:49 +02:00
dsa
net: dsa: fix switch tree list
2019-11-10 11:25:32 +01:00
ethernet
net: add annotations on hh->hh_len lockless accesses
2020-01-09 10:17:59 +01:00
hsr
net/hsr: fix possible crash in add_timer()
2019-03-19 13:13:22 +01:00
ieee802154
ieee802154: enforce CAP_NET_RAW for raw sockets
2019-10-05 12:47:44 +02:00
ife
net: sched: ife: check on metadata length
2018-04-29 11:33:13 +02:00
ipv4
tcp: do not send empty skb from tcp_write_xmit()
2020-01-04 14:00:20 +01:00
ipv6
tcp/dccp: fix possible race __inet_lookup_established()
2020-01-04 14:00:19 +01:00
ipx
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
iucv
net/iucv: Free memory obtained by kzalloc
2018-03-31 18:10:41 +02:00
kcm
kcm: switch order of device registration to fix a crash
2019-04-17 08:37:45 +02:00
key
xfrm: clean up xfrm protocol checks
2019-09-16 08:20:44 +02:00
l2tp
compat_ioctl: pppoe: fix PPPOEIOCSFWD handling
2019-08-09 17:53:35 +02:00
l3mdev
…
lapb
lapb: fixed leak of control-blocks.
2019-06-22 08:16:14 +02:00
llc
llc: avoid blocking in llc_sap_close()
2019-11-20 17:59:59 +01:00
mac80211
mac80211: consider QoS Null frames for STA_NULLFUNC_ACKED
2019-12-31 12:37:49 +01:00
mac802154
net: mac802154: tx: expand tailroom if necessary
2018-09-09 19:55:52 +02:00
mpls
mpls: Return error for RTA_GATEWAY attribute
2019-03-13 14:03:09 -07:00
ncsi
net/ncsi: Fix length of GVI response packet
2017-10-21 01:56:38 +01:00
netfilter
net: add bool confirm_neigh parameter for dst_ops.update_pmtu
2020-01-04 14:00:14 +01:00
netlabel
netlabel: fix out-of-bounds memory accesses
2019-03-13 14:03:08 -07:00
netlink
genetlink: Fix a memory leak on error path
2019-04-03 06:25:08 +02:00
netrom
netrom: hold sock when setting skb->destructor
2019-07-31 07:28:46 +02:00
nfc
net: nfc: nci: fix a possible sleep-in-atomic-context bug in nci_uart_tty_receive()
2019-12-31 12:36:41 +01:00
nsh
nsh: set mac len based on inner packet
2018-07-22 14:28:49 +02:00
openvswitch
openvswitch: support asymmetric conntrack
2019-12-21 10:47:34 +01:00
packet
af_packet: set defaule value for tmo
2019-12-31 12:36:38 +01:00
phonet
net: use skb_queue_empty_lockless() in poll() handlers
2019-11-10 11:25:34 +01:00
psample
net: psample: fix skb_over_panic
2019-12-05 15:38:15 +01:00
qrtr
net: qrtr: Stop rx_worker before freeing node
2019-10-05 12:47:40 +02:00
rds
net/rds: Fix error handling in rds_ib_add_one()
2019-10-07 18:55:20 +02:00
rfkill
rfkill: allocate static minor
2019-12-31 12:37:21 +01:00
rose
net/rose: fix unbound loop in rose_loopback_timer()
2019-05-02 09:40:34 +02:00
rxrpc
rxrpc: Fix possible NULL pointer access in ICMP handling
2020-01-09 10:17:59 +01:00
sched
net: sched: fix tc -s class show no bstats on class with nolock subqueues
2019-12-05 15:38:19 +01:00
sctp
net: add bool confirm_neigh parameter for dst_ops.update_pmtu
2020-01-04 14:00:14 +01:00
smc
net/smc: use after free fix in smc_wr_tx_put_slot()
2019-12-17 20:38:01 +01:00
strparser
strparser: Remove early eaten to fix full tcp receive buffer stall
2018-07-22 14:28:47 +02:00
sunrpc
sunrpc: fix crash when cache_head become valid before update
2019-12-17 20:40:00 +01:00
switchdev
net: switchdev: Remove bridge bypass support from switchdev
2017-08-07 14:48:48 -07:00
tipc
tipc: fix ordering of tipc module init and exit routine
2019-12-21 10:47:35 +01:00
tls
net/tls: Fixed return value when tls_complete_pending_work() fails
2018-12-05 19:41:11 +01:00
unix
net: fix warning in af_unix
2019-12-01 09:13:35 +01:00
vmw_vsock
VSOCK: bind to random port for VMADDR_PORT_ANY
2019-12-05 15:37:24 +01:00
wimax
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
wireless
cfg80211: call disconnect_wk when AP stops
2019-12-01 09:14:15 +01:00
x25
net/x25: fix null_x25_address handling
2019-12-17 20:38:25 +01:00
xfrm
xfrm: release device reference for invalid state
2019-12-17 20:37:28 +01:00
compat.c
sock: Make sock->sk_stamp thread-safe
2019-01-09 17:14:46 +01:00
Kconfig
net: Remove CONFIG_NETFILTER_DEBUG and _ASSERT() macros.
2017-09-04 13:25:20 +02:00
Makefile
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
socket.c
net: make socket read/write_iter() honor IOCB_NOWAIT
2020-01-09 10:17:52 +01:00
sysctl_net.c
…