linux

iv/linux

History

Somya Anand 87e3dbc27c Staging: gdm72xx: use !x instead of x == NULL

Functions like devm_kzalloc, kmalloc_array, devm_ioremap,
usb_alloc_urb, alloc_netdev return NULL as a return value on failure.
Generally, When NULL represents failure, !x is commonly used.

This patch cleans up the tests on the results of these functions, thereby
using !x instead of x == NULL or NULL == x. This is done via following
coccinelle script:
@prob_7@
identifier x;
statement S;
@@

(
 x = devm_kzalloc(...);
|
 x = usb_alloc_urb(...);
|
 x = kmalloc_array(...);
|
 x = devm_ioremap(...);
|
 x = alloc_netdev(...);
)
 ...
- if(NULL == x)
+ if(!x)
        S
Further we have used isomorphism characteristics of coccinelle to
indicate x == NULL and NULL == x are equivalent. This is done via
following iso script.

Expression
@ is_null @ expression X; @@
X == NULL <=> NULL == X

Signed-off-by: Somya Anand <somyaanand214@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2015-03-16 16:28:47 +01:00

gdm_qos.c

staging: gdm72xx: Condense two statements into one to improve code readability.

2015-03-01 16:57:36 -08:00

gdm_qos.h

staging: gdm72xx: use consistent style for header guards

2014-07-09 11:49:15 -07:00

gdm_sdio.c

Staging: gdm72xx: clean dev_err logging

2015-03-06 15:55:36 -08:00

gdm_sdio.h

staging: gdm72xx: use consistent style for header guards