David Howells 1a31b0d0dd afs: Fix leak in afs_lookup_cell_rcu() ...

[ Upstream commit a5fb8e6c02d6a518fb2b1a2b8c2471fa77b69436 ]

Fix a leak on the cell refcount in afs_lookup_cell_rcu() due to
non-clearance of the default error in the case a NULL cell name is passed
and the workstation default cell is used.

Also put a bit at the end to make sure we don't leak a cell ref if we're
going to be returning an error.

This leak results in an assertion like the following when the kafs module is
unloaded:

	AFS: Assertion failed
	2 == 1 is false
	0x2 == 0x1 is false
	------------[ cut here ]------------
	kernel BUG at fs/afs/cell.c:770!
	...
	RIP: 0010:afs_manage_cells+0x220/0x42f [kafs]
	...
	 process_one_work+0x4c2/0x82c
	 ? pool_mayday_timeout+0x1e1/0x1e1
	 ? do_raw_spin_lock+0x134/0x175
	 worker_thread+0x336/0x4a6
	 ? rescuer_thread+0x4af/0x4af
	 kthread+0x1de/0x1ee
	 ? kthread_park+0xd4/0xd4
	 ret_from_fork+0x24/0x30

Fixes: 989782dcdc91 ("afs: Overhaul cell database management")
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2019-09-10 10:33:52 +01:00

..

addr_list.c

Merge branch 'afs-proc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs

2018-06-16 16:32:04 +09:00

afs_cm.h

…

afs_fs.h

afs: Prospectively look up extra files when doing a single lookup

2018-04-09 21:12:31 +01:00

afs_vl.h

afs: Make use of the YFS service upgrade to fully support IPv6

2017-11-13 15:38:19 +00:00

afs.h

afs: Rearrange status mapping

2018-04-09 21:53:59 +01:00

cache.c

fscache: Pass object size in rather than calling back for it

2018-04-06 14:05:14 +01:00

callback.c

afs: Fix uninitialised spinlock afs_volume::cb_break_lock

2019-07-21 09:03:06 +02:00

cell.c

afs: Fix leak in afs_lookup_cell_rcu()

2019-09-10 10:33:52 +01:00

cmservice.c

afs: Fix the CB.ProbeUuid service handler to reply correctly

2019-09-06 10:21:54 +02:00

dir_edit.c

afs: Locally edit directory data for mkdir/create/unlink/...

2018-04-09 21:54:48 +01:00

dir.c

afs: Only update d_fsdata if different in afs_d_revalidate()

2019-09-06 10:21:55 +02:00

dynroot.c

afs: Fix cell proc list

2018-10-12 13:18:57 +02:00

file.c

fs: afs: Fix a possible null-pointer dereference in afs_put_read()

2019-09-06 10:21:54 +02:00

flock.c

afs: Fix key refcounting in file locking code

2019-02-27 10:08:56 +01:00

fsclient.c

Merge branch 'afs-proc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs

2018-06-16 16:32:04 +09:00

inode.c

afs: Fix key refcounting in file locking code

2019-02-27 10:08:56 +01:00

internal.h

afs: Fix uninitialised spinlock afs_volume::cb_break_lock

2019-07-21 09:03:06 +02:00

Kconfig

fs/afs: remove depends on CONFIG_EXPERIMENTAL

2013-01-21 14:39:04 -08:00

main.c

afs: Fix cell proc list

2018-10-12 13:18:57 +02:00

Makefile

afs: Handle CONFIG_PROC_FS=n

2018-06-15 00:52:55 -04:00

misc.c

afs: Consolidate abort_to_error translators

2017-11-13 15:38:17 +00:00

mntpt.c

afs: Support the AFS dynamic root

2018-02-06 14:43:37 +00:00

netdevices.c

afs: Implement network namespacing

2018-05-23 12:01:15 +01:00

proc.c

afs: Fix cell proc list

2018-10-12 13:18:57 +02:00

rotate.c

rxrpc: Fix handling of call quietly cancelled out on server

2018-06-04 16:06:26 -04:00

rxrpc.c

afs: Handle EIO from delivery function

2018-11-27 16:13:00 +01:00

security.c

afs: Fix directory permissions check

2018-05-16 21:35:23 +01:00

server_list.c

afs: Fix refcounting in callback registration

2018-05-14 13:17:35 +01:00

server.c

afs: Fix clearance of reply

2018-10-15 15:31:47 +02:00

super.c

afs: Display manually added cells in dynamic root mount

2018-06-15 15:27:09 +01:00

vlclient.c

afs: Fix loop index mixup in afs_deliver_vl_get_entry_by_name_u()

2019-09-06 10:21:54 +02:00

volume.c

afs: Fix uninitialised spinlock afs_volume::cb_break_lock

2019-07-21 09:03:06 +02:00

write.c

afs: Unlock pages for __pagevec_release()

2019-05-16 19:41:21 +02:00

xattr.c

afs: Overhaul volume and server record caching and fileserver rotation

2017-11-13 15:38:19 +00:00

xdr_fs.h

afs: Adjust the directory XDR structures

2018-04-09 21:54:48 +01:00