Colin Ian King 347876ad47 rtc: tx4939: avoid unintended sign extension on a 24 bit shift
The shifting of buf[5] by 24 bits to the left will be promoted to
a 32 bit signed int and then sign-extended to an unsigned long. If
the top bit of buf[5] is set then all then all the upper bits sec
end up as also being set because of the sign-extension. Fix this by
casting buf[5] to an unsigned long before the shift.

Detected by CoverityScan, CID#1465292 ("Unintended sign extension")

Fixes: 0e1492330cd2 ("rtc: add rtc-tx4939 driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
2018-03-01 10:49:38 +01:00
..
2018-02-06 09:59:40 -08:00
2018-02-01 16:35:31 -08:00
2018-02-07 11:22:44 -08:00
2018-02-02 10:01:04 -08:00
2018-02-10 13:16:35 -08:00
2018-02-06 09:59:40 -08:00
2018-02-08 12:03:54 -08:00
2018-02-06 09:59:40 -08:00
2018-02-01 16:35:31 -08:00
2018-02-09 19:32:41 -08:00
2018-01-31 11:32:27 -08:00
2018-02-01 10:31:17 -08:00
2018-02-04 11:16:35 -08:00
2018-02-06 09:59:40 -08:00
2018-02-01 09:40:49 -08:00
2018-01-30 12:25:59 +00:00
2018-02-05 10:07:40 -08:00
2018-02-06 09:59:40 -08:00
2018-02-01 16:35:31 -08:00
2018-02-09 19:32:41 -08:00
2018-02-01 10:31:17 -08:00
2018-02-06 09:59:40 -08:00