Mian Yousaf Kaukab 34f35f8f14 ipmi: ssif: initialize ssif_info->client early ... During probe ssif_info->client is dereferenced in error path. However, it is set when some of the error checking has already been done. This causes following kernel crash if an error path is taken: [ 30.645593][ T674] ipmi_ssif 0-000e: ipmi_ssif: Not probing, Interface already present [ 30.657616][ T674] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000088 ... [ 30.657723][ T674] pc : __dev_printk+0x28/0xa0 [ 30.657732][ T674] lr : _dev_err+0x7c/0xa0 ... [ 30.657772][ T674] Call trace: [ 30.657775][ T674] __dev_printk+0x28/0xa0 [ 30.657778][ T674] _dev_err+0x7c/0xa0 [ 30.657781][ T674] ssif_probe+0x548/0x900 [ipmi_ssif 62ce4b08badc1458fd896206d9ef69a3c31f3d3e] [ 30.657791][ T674] i2c_device_probe+0x37c/0x3c0 ... Initialize ssif_info->client before any error path can be taken. Clear i2c_client data in the error path to prevent the dangling pointer from leaking. Fixes: c4436c9149 ("ipmi_ssif: avoid registering duplicate ssif interface") Cc: stable@vger.kernel.org # 5.4.x Suggested-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Mian Yousaf Kaukab <ykaukab@suse.de> Message-Id: <20211208093239.4432-1-ykaukab@suse.de> Signed-off-by: Corey Minyard <cminyard@mvista.com>		2021-12-08 07:13:37 -06:00
..
agp	parisc: parisc-agp requires SBA IOMMU driver	2021-04-06 11:46:39 +02:00
hw_random	vhost,virtio,vhost: fixes,features	2021-11-03 15:00:39 -07:00
ipmi	ipmi: ssif: initialize ssif_info->client early	2021-12-08 07:13:37 -06:00
mwave	char: mware: fix returnvar.cocci warnings	2021-08-27 16:20:37 +02:00
pcmcia	cm4000_cs: Use struct_group() to zero struct cm4000_dev region	2021-09-25 08:20:49 -07:00
tpm	tpm_tis_spi: Add missing SPI ID	2021-10-26 05:03:34 +03:00
xilinx_hwicap
xillybus	char: xillybus: fix msg_ep UAF in xillyusb_probe()	2021-10-19 09:40:18 +02:00
adi.c
apm-emulation.c
applicom.c	Merge 5.12-rc6 into char-misc-next	2021-04-05 08:43:50 +02:00
applicom.h
bsr.c	mm: don't include asm/pgtable.h if linux/mm.h is already included	2020-06-09 09:39:13 -07:00
ds1620.c
dsp56k.c
dtlk.c
hangcheck-timer.c
hpet.c	char: hpet: Remove unused variable 'm'	2021-05-21 10:09:30 +02:00
Kconfig	char: move RANDOM_TRUST_CPU & RANDOM_TRUST_BOOTLOADER into the Character devices menu	2021-08-16 19:02:19 +02:00
lp.c	char: lp: remove redundant space around (inside) parenthesized expressions	2021-03-24 08:26:32 +01:00
Makefile	remove the raw driver	2021-06-04 15:35:03 +02:00
mem.c	/dev/mem: nowait zero/null ops	2021-09-14 10:46:19 +02:00
misc.c	char: misc: increase DYNAMIC_MINORS value	2020-11-03 09:52:04 +01:00
mspec.c	char: mspec: Use kvzalloc() in mspec_mmap()	2020-08-28 12:10:04 +02:00
nsc_gpio.c
nvram.c	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
nwbutton.c
nwbutton.h	misc: cleanup minor number definitions in c file into miscdevice.h	2020-03-18 12:27:03 +01:00
nwflash.c	misc: move FLASH_MINOR into miscdevice.h and fix conflicts	2020-03-18 12:27:04 +01:00
pc8736x_gpio.c
powernv-op-panel.c	powerpc/powernv: Fix fall-through warning for Clang	2021-07-13 19:21:41 -05:00
ppdev.c	ppdev: Distribute switch variables for initialization	2020-02-23 20:28:12 +01:00
ps3flash.c	powerpc/ps3: make system bus's remove and shutdown callbacks return void	2020-12-04 01:01:22 +11:00
random.c	random: remove dead code left over from blocking pool	2021-04-02 18:28:12 +11:00
scx200_gpio.c
sonypi.c
tb0219.c
tlclk.c	drivers: char: tlclk.c: Avoid data race between init and interrupt handler	2020-04-23 16:55:24 +02:00
toshiba.c	module: remove never implemented MODULE_SUPPORTED_DEVICE	2021-03-17 13:16:18 -07:00
ttyprintk.c	tty: drop put_tty_driver	2021-07-27 12:17:21 +02:00
uv_mmtimer.c
virtio_console.c	virtio_console: validate max_nr_ports before trying to use it	2021-11-01 05:26:48 -04:00