Cheng Lin
353b19562a
nfs_common: need lock during iterate through the list ...
[ Upstream commit 4a9d81caf841cd2c0ae36abec9c2963bf21d0284 ]
If the elem is deleted during be iterated on it, the iteration
process will fall into an endless loop.
kernel: NMI watchdog: BUG: soft lockup - CPU#4 stuck for 22s! [nfsd:17137]
PID: 17137 TASK: ffff8818d93c0000 CPU: 4 COMMAND: "nfsd"
[exception RIP: __state_in_grace+76]
RIP: ffffffffc00e817c RSP: ffff8818d3aefc98 RFLAGS: 00000246
RAX: ffff881dc0c38298 RBX: ffffffff81b03580 RCX: ffff881dc02c9f50
RDX: ffff881e3fce8500 RSI: 0000000000000001 RDI: ffffffff81b03580
RBP: ffff8818d3aefca0 R8: 0000000000000020 R9: ffff8818d3aefd40
R10: ffff88017fc03800 R11: ffff8818e83933c0 R12: ffff8818d3aefd40
R13: 0000000000000000 R14: ffff8818e8391068 R15: ffff8818fa6e4000
CS: 0010 SS: 0018
#0 [ffff8818d3aefc98] opens_in_grace at ffffffffc00e81e3 [grace]
#1 [ffff8818d3aefca8] nfs4_preprocess_stateid_op at ffffffffc02a3e6c [nfsd]
#2 [ffff8818d3aefd18] nfsd4_write at ffffffffc028ed5b [nfsd]
#3 [ffff8818d3aefd80] nfsd4_proc_compound at ffffffffc0290a0d [nfsd]
#4 [ffff8818d3aefdd0] nfsd_dispatch at ffffffffc027b800 [nfsd]
#5 [ffff8818d3aefe08] svc_process_common at ffffffffc02017f3 [sunrpc]
#6 [ffff8818d3aefe70] svc_process at ffffffffc0201ce3 [sunrpc]
#7 [ffff8818d3aefe98] nfsd at ffffffffc027b117 [nfsd]
#8 [ffff8818d3aefec8] kthread at ffffffff810b88c1
#9 [ffff8818d3aeff50] ret_from_fork at ffffffff816d1607
The troublemake elem:
crash> lock_manager ffff881dc0c38298
struct lock_manager {
list = {
next = 0xffff881dc0c38298,
prev = 0xffff881dc0c38298
},
block_opens = false
}
Fixes: c87fb4a378f9 ("lockd: NLM grace period shouldn't block NFSv4 opens")
Signed-off-by: Cheng Lin <cheng.lin130@zte.com.cn>
Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2020-12-30 11:51:22 +01:00
2020-11-05 11:43:34 +01:00
2019-07-19 11:33:22 -07:00
2020-09-09 19:12:34 +02:00
2020-12-30 11:50:54 +01:00
2019-10-25 00:03:11 -04:00
2019-08-30 07:27:17 -07:00
2019-08-30 07:27:17 -07:00
2020-12-02 08:49:45 +01:00
2020-11-05 11:43:36 +01:00
2020-11-05 11:43:34 +01:00
2020-12-11 13:23:29 +01:00
2019-09-19 09:42:37 -07:00
2020-05-27 17:46:30 +02:00
2019-11-23 21:44:49 -05:00
2020-03-18 07:17:53 +01:00
2020-09-17 13:47:55 +02:00
2019-09-03 09:30:56 -04:00
2020-10-29 09:58:03 +01:00
2020-02-28 17:22:26 +01:00
2020-12-02 08:49:53 +01:00
2019-08-30 07:27:17 -07:00
2020-11-18 19:20:28 +01:00
2019-11-10 11:56:05 -05:00
2020-09-09 19:12:30 +02:00
2020-11-24 13:29:21 +01:00
2020-12-30 11:51:04 +01:00
2020-06-17 16:40:36 +02:00
2019-08-30 07:27:17 -07:00
2019-07-10 18:43:43 -07:00
2020-11-01 12:01:05 +01:00
2020-12-11 13:23:32 +01:00
2020-04-17 10:50:22 +02:00
2019-08-30 08:11:25 -07:00
2020-09-03 11:26:48 +02:00
2020-10-29 09:58:06 +01:00
2019-09-19 09:42:37 -07:00
2020-11-18 19:20:30 +01:00
2020-08-26 10:40:56 +02:00
2019-09-19 09:42:37 -07:00
2020-08-19 08:16:12 +02:00
2020-12-30 11:51:16 +01:00
2020-08-21 13:05:37 +02:00
2020-12-30 11:51:16 +01:00
2020-12-30 11:51:22 +01:00
2020-12-30 11:51:22 +01:00
2020-06-17 16:40:29 +02:00
2020-06-17 16:40:24 +02:00
2020-10-29 09:58:03 +01:00
2020-11-18 19:20:30 +01:00
2019-08-30 08:11:25 -07:00
2019-07-19 10:42:02 -07:00
2020-08-21 13:05:29 +02:00
2020-07-22 09:33:12 +02:00
2020-12-16 10:56:58 +01:00
2020-08-19 08:16:27 +02:00
2019-08-30 07:27:17 -07:00
2019-08-30 07:27:17 -07:00
2020-12-30 11:51:00 +01:00
2020-10-29 09:57:53 +01:00
2020-10-29 09:58:08 +01:00
2020-08-26 10:40:51 +02:00
2019-09-19 10:06:57 -07:00
2019-07-19 10:42:02 -07:00
2019-08-30 07:27:18 -07:00
2019-10-12 20:49:07 -04:00
2020-11-05 11:43:32 +01:00
2020-11-05 11:43:29 +01:00
2020-08-21 13:05:37 +02:00
2019-09-17 11:48:24 -04:00
2019-08-12 19:33:50 -07:00
2020-11-24 13:29:18 +01:00
2020-06-17 16:40:24 +02:00
2019-07-19 10:42:02 -07:00
2020-02-11 04:35:12 -08:00
2020-06-03 08:21:27 +02:00
2020-09-03 11:26:39 +02:00
2019-07-19 10:42:02 -07:00
2020-10-01 13:17:55 +02:00
2020-11-05 11:43:24 +01:00
2020-01-14 20:08:18 +01:00
2020-01-09 10:20:05 +01:00
2020-12-11 13:23:30 +01:00
2020-10-29 09:57:45 +01:00
2020-03-05 16:43:36 +01:00
2020-10-01 13:17:19 +02:00
2019-10-14 15:04:01 -07:00
2020-01-12 12:21:37 +01:00
2020-02-11 04:35:37 -08:00
2020-10-07 08:01:31 +02:00
2020-11-05 11:43:13 +01:00
2019-08-07 21:51:47 -04:00
2019-08-19 11:00:39 -04:00
2020-05-27 17:46:12 +02:00
2020-04-17 10:50:21 +02:00
2019-09-06 21:28:49 +02:00
2019-09-12 21:06:14 -04:00
2019-07-16 22:52:37 -04:00
2020-09-03 11:27:04 +02:00
2019-07-19 10:42:02 -07:00
2020-03-25 08:25:58 +01:00
2020-01-17 19:48:21 +01:00
2020-10-14 10:32:57 +02:00
2019-12-17 19:55:30 +01:00
2019-09-18 16:59:14 -07:00
2020-11-24 13:29:19 +01:00
2020-03-25 08:25:41 +01:00
2019-09-18 16:59:14 -07:00
2019-07-16 22:52:37 -04:00
2020-01-17 19:48:21 +01:00
2020-03-05 16:43:48 +01:00
2019-10-16 23:15:09 -04:00
2020-03-18 07:17:51 +01:00
2020-05-02 08:48:44 +02:00
2019-09-06 21:28:49 +02:00
2020-02-11 04:35:23 -08:00
2020-01-29 16:45:31 +01:00
2019-07-16 19:23:25 -07:00
2019-08-13 16:06:52 -07:00
2020-08-26 10:40:58 +02:00
2019-12-17 19:56:52 +01:00
2019-10-03 14:21:35 -07:00
2020-11-24 13:29:01 +01:00
2019-08-01 20:51:23 +02:00
2020-01-04 19:18:32 +01:00
2020-02-11 04:35:12 -08:00
2020-08-11 15:33:39 +02:00
353b19562a