iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/arch/riscv/kernel
History
Xianting Tian 357628e68f
RISC-V: kexec: Fixup use of smp_processor_id() in preemptible context 
Use __smp_processor_id() to avoid check the preemption context when
CONFIG_DEBUG_PREEMPT enabled, as we will enter crash kernel and no
return.

Without the patch,
[  103.781044] sysrq: Trigger a crash
[  103.784625] Kernel panic - not syncing: sysrq triggered crash
[  103.837634] CPU1: off
[  103.889668] CPU2: off
[  103.933479] CPU3: off
[  103.939424] Starting crashdump kernel...
[  103.943442] BUG: using smp_processor_id() in preemptible [00000000] code: sh/346
[  103.950884] caller is debug_smp_processor_id+0x1c/0x26
[  103.956051] CPU: 0 PID: 346 Comm: sh Kdump: loaded Not tainted 5.10.113-00002-gce03f03bf4ec-dirty #149
[  103.965355] Call Trace:
[  103.967805] [<ffffffe00020372a>] walk_stackframe+0x0/0xa2
[  103.973206] [<ffffffe000bcf1f4>] show_stack+0x32/0x3e
[  103.978258] [<ffffffe000bd382a>] dump_stack_lvl+0x72/0x8e
[  103.983655] [<ffffffe000bd385a>] dump_stack+0x14/0x1c
[  103.988705] [<ffffffe000bdc8fe>] check_preemption_disabled+0x9e/0xaa
[  103.995057] [<ffffffe000bdc926>] debug_smp_processor_id+0x1c/0x26
[  104.001150] [<ffffffe000206c64>] machine_kexec+0x22/0xd0
[  104.006463] [<ffffffe000291a7e>] __crash_kexec+0x6a/0xa4
[  104.011774] [<ffffffe000bcf3fa>] panic+0xfc/0x2b0
[  104.016480] [<ffffffe000656ca4>] sysrq_reset_seq_param_set+0x0/0x70
[  104.022745] [<ffffffe000657310>] __handle_sysrq+0x8c/0x154
[  104.028229] [<ffffffe0006577e8>] write_sysrq_trigger+0x5a/0x6a
[  104.034061] [<ffffffe0003d90e0>] proc_reg_write+0x58/0xd4
[  104.039459] [<ffffffe00036cff4>] vfs_write+0x7e/0x254
[  104.044509] [<ffffffe00036d2f6>] ksys_write+0x58/0xbe
[  104.049558] [<ffffffe00036d36a>] sys_write+0xe/0x16
[  104.054434] [<ffffffe000201b9a>] ret_from_syscall+0x0/0x2
[  104.067863] Will call new kernel at ecc00000 from hart id 0
[  104.074939] FDT image at fc5ee000
[  104.079523] Bye...

With the patch we can got clear output,
[   67.740553] sysrq: Trigger a crash
[   67.744166] Kernel panic - not syncing: sysrq triggered crash
[   67.809123] CPU1: off
[   67.865210] CPU2: off
[   67.909075] CPU3: off
[   67.919123] Starting crashdump kernel...
[   67.924900] Will call new kernel at ecc00000 from hart id 0
[   67.932045] FDT image at fc5ee000
[   67.935560] Bye...

Fixes: 0e105f1d0037 ("riscv: use hart id instead of cpu id on machine_kexec")
Reviewed-by: Guo Ren <guoren@kernel.org>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Reviewed-by: Atish Patra <atishp@rivosinc.com>
Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
Link: https://lore.kernel.org/r/20220811074150.3020189-2-xianting.tian@linux.alibaba.com
Cc: stable@vger.kernel.org
Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
2022-08-11 08:54:32 -07:00
..
compat_vdso
riscv: compat: vdso: Add COMPAT_VDSO base code implementation
2022-04-26 13:36:53 -07:00
probes
ftrace: disable preemption when recursion locked
2021-10-27 11:21:49 -04:00
vdso
riscv: compat: vdso: Add COMPAT_VDSO base code implementation
2022-04-26 13:36:53 -07:00
.gitignore
.gitignore: add SPDX License Identifier
2020-03-25 11:50:48 +01:00
alternative.c
riscv: add memory-type errata for T-Head
2022-05-11 21:36:33 -07:00
asm-offsets.c
RISC-V: Add arch functions for non-retentive suspend entry/exit
2022-03-10 09:29:31 -08:00
cacheinfo.c
drivers: base: cacheinfo: Get rid of DEFINE_SMP_CALL_CACHE_FUNCTION()
2021-09-01 10:29:10 +02:00
compat_signal.c
riscv: compat: signal: Add rt_frame implementation
2022-05-17 16:37:21 -07:00
compat_syscall_table.c
riscv: compat: syscall: Add compat_sys_call_table implementation
2022-04-26 13:36:25 -07:00
cpu_ops_sbi.c
RISC-V: Declare per cpu boot data as static
2022-03-31 12:44:32 -07:00
cpu_ops_spinwait.c
RISC-V: Use __cpu_up_stack/task_pointer only for spinwait method
2022-01-20 09:27:08 -08:00
cpu_ops.c
RISC-V: Move spinwait booting method to its own config
2022-01-20 09:27:16 -08:00
cpu-hotplug.c
riscv: cpu-hotplug: clear cpu from numa map when teardown
2022-02-10 09:16:50 -08:00
cpu.c
riscv: Don't output a bogus mmu-type on a no MMU kernel
2022-05-21 12:20:04 -07:00
cpufeature.c
Bitmap patches for 5.19-rc1
2022-06-04 14:04:27 -07:00
crash_dump.c
vmcore: convert copy_oldmem_page() to take an iov_iter
2022-04-29 14:37:59 -07:00
crash_save_regs.S
RISC-V: Add kdump support
2021-04-26 08:25:23 -07:00
efi-header.S
RISC-V: Add PE/COFF header for EFI stub
2020-10-02 14:31:16 -07:00
efi.c
riscv: read-only pages should not be writable
2022-05-28 11:39:31 +02:00
elf_kexec.c
RISC-V: Load purgatory in kexec_file
2022-05-19 12:19:03 -07:00
entry.S
riscv: compat: syscall: Add entry.S implementation
2022-04-26 13:36:31 -07:00
fpu.S
riscv: abstract out CSR names for supervisor vs machine mode
2019-11-05 09:20:42 -08:00
ftrace.c
ftrace: Remove return value of ftrace_arch_modify_*()
2022-05-26 21:13:00 -04:00
head.h
RISC-V: Move spinwait booting method to its own config
2022-01-20 09:27:16 -08:00
head.S
riscv: Initialize thread pointer before calling C functions
2022-06-01 21:46:23 -07:00
image-vars.h
arch/riscv:fix typo in a comment in arch/riscv/kernel/image-vars.h
2021-02-18 23:18:00 -08:00
irq.c
RISC-V: Remove do_IRQ() function
2020-06-09 19:11:24 -07:00
jump_label.c
riscv: Add jump-label implementation
2020-07-30 11:37:43 -07:00
kexec_relocate.S
riscv: Don't use va_pa_offset on kdump
2022-01-09 10:38:06 -08:00
kgdb.c
riscv: Fix "no previous prototype" compile warning in kgdb.c file
2020-07-09 20:09:30 -07:00
machine_kexec_file.c
RISC-V: Add kexec_file support
2022-05-19 12:14:18 -07:00
machine_kexec.c
RISC-V: kexec: Fixup use of smp_processor_id() in preemptible context
2022-08-11 08:54:32 -07:00
Makefile
riscv: kexec: add kexec_file_load() support
2022-05-19 16:26:50 -07:00
mcount-dyn.S
riscv: Using PATCHABLE_FUNCTION_ENTRY instead of MCOUNT
2021-01-14 15:09:05 -08:00
mcount.S
riscv: Workaround mcount name prior to clang-13
2021-04-26 08:25:01 -07:00
module-sections.c
riscv: add missing header file includes
2019-10-28 00:46:01 -07:00
module.c
riscv: implement module alternatives
2022-05-11 21:36:31 -07:00
patch.c
riscv: patch_text: Fixup last cpu should be master
2022-04-22 08:29:24 -07:00
perf_callchain.c
riscv: Fix fill_callchain return value
2022-03-30 23:01:42 -07:00
perf_regs.c
perf/arch: Remove perf_sample_data::regs_user_copy
2020-11-09 18:12:34 +01:00
process.c
This set of changes updates init and user mode helper tasks to be
2022-06-03 16:03:05 -07:00
ptrace.c
riscv: compat: ptrace: Add compat_arch_ptrace implement
2022-05-17 16:37:22 -07:00
reset.c
riscv: Use do_kernel_power_off()
2022-05-19 19:30:30 +02:00
riscv_ksyms.c
riscv: provide memmove implementation
2020-12-10 17:27:54 -08:00
sbi.c
RISC-V: Fix IPI/RFENCE hmask on non-monotonic hartid ordering
2022-02-14 12:27:45 -08:00
setup.c
RISC-V: Mark IORESOURCE_EXCLUSIVE for reserved mem instead of IORESOURCE_BUSY
2022-06-01 22:03:50 -07:00
signal.c
riscv: compat: signal: Add rt_frame implementation
2022-05-17 16:37:21 -07:00
smp.c
RISC-V: Use common riscv_cpuid_to_hartid_mask() for both SMP=y and SMP=n
2022-01-09 12:13:31 -08:00
smpboot.c
riscv: move boot alternatives to after fill_hwcap
2022-05-11 21:36:32 -07:00
soc.c
riscv: Fix builtin DTB handling
2021-01-07 19:00:50 -08:00
stacktrace.c
riscv: Rename "sp_in_global" to "current_stack_pointer"
2022-03-30 15:15:27 -07:00
suspend_entry.S
RISC-V: Split out the XIP fixups into their own file
2022-05-25 14:43:33 -07:00
suspend.c
RISC-V: Add arch functions for non-retentive suspend entry/exit
2022-03-10 09:29:31 -08:00
sys_riscv.c
riscv: compat: syscall: Add compat_sys_call_table implementation
2022-04-26 13:36:25 -07:00
syscall_table.c
riscv/vdso: Refactor asm/vdso.h
2021-10-02 13:42:23 -07:00
time.c
RISC-V Patches for the 5.13 Merge Window, Part 1
2021-05-06 09:24:18 -07:00
trace_irq.c
riscv: fix oops caused by irqsoff latency tracer
2022-02-24 20:30:30 -08:00
trace_irq.h
riscv: fix oops caused by irqsoff latency tracer
2022-02-24 20:30:30 -08:00
traps_misaligned.c
riscv: Unaligned load/store handling for M_MODE
2020-04-03 10:45:33 -07:00
traps.c
riscv: integrate alternatives better into the main architecture
2022-05-11 21:36:31 -07:00
vdso.c
riscv: compat: Using seperated vdso_maps for compat_vdso_info
2022-05-25 17:24:06 -07:00
vmlinux-xip.lds.S
riscv: vmlinux.lds.S|vmlinux-xip.lds.S: remove .fixup section
2022-01-05 17:53:37 -08:00
vmlinux.lds.S
riscv: vmlinux.lds.S|vmlinux-xip.lds.S: remove .fixup section
2022-01-05 17:53:37 -08:00