iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
37d69ee30808110bd8336d65af3f999a7a475e1d
linux/net/ipv4
History
Alexander Potapenko 86f4c90a1c ipv4, ipv6: ensure raw socket message is big enough to hold an IP header 
raw_send_hdrinc() and rawv6_send_hdrinc() expect that the buffer copied
from the userspace contains the IPv4/IPv6 header, so if too few bytes are
copied, parts of the header may remain uninitialized.

This bug has been detected with KMSAN.

For the record, the KMSAN report:

==================================================================
BUG: KMSAN: use of unitialized memory in nf_ct_frag6_gather+0xf5a/0x44a0
inter: 0
CPU: 0 PID: 1036 Comm: probe Not tainted 4.11.0-rc5+ #2455
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:16
 dump_stack+0x143/0x1b0 lib/dump_stack.c:52
 kmsan_report+0x16b/0x1e0 mm/kmsan/kmsan.c:1078
 __kmsan_warning_32+0x5c/0xa0 mm/kmsan/kmsan_instr.c:510
 nf_ct_frag6_gather+0xf5a/0x44a0 net/ipv6/netfilter/nf_conntrack_reasm.c:577
 ipv6_defrag+0x1d9/0x280 net/ipv6/netfilter/nf_defrag_ipv6_hooks.c:68
 nf_hook_entry_hookfn ./include/linux/netfilter.h:102
 nf_hook_slow+0x13f/0x3c0 net/netfilter/core.c:310
 nf_hook ./include/linux/netfilter.h:212
 NF_HOOK ./include/linux/netfilter.h:255
 rawv6_send_hdrinc net/ipv6/raw.c:673
 rawv6_sendmsg+0x2fcb/0x41a0 net/ipv6/raw.c:919
 inet_sendmsg+0x3f8/0x6d0 net/ipv4/af_inet.c:762
 sock_sendmsg_nosec net/socket.c:633
 sock_sendmsg net/socket.c:643
 SYSC_sendto+0x6a5/0x7c0 net/socket.c:1696
 SyS_sendto+0xbc/0xe0 net/socket.c:1664
 do_syscall_64+0x72/0xa0 arch/x86/entry/common.c:285
 entry_SYSCALL64_slow_path+0x25/0x25 arch/x86/entry/entry_64.S:246
RIP: 0033:0x436e03
RSP: 002b:00007ffce48baf38 EFLAGS: 00000246 ORIG_RAX: 000000000000002c
RAX: ffffffffffffffda RBX: 00000000004002b0 RCX: 0000000000436e03
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000003
RBP: 00007ffce48baf90 R08: 00007ffce48baf50 R09: 000000000000001c
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000401790 R14: 0000000000401820 R15: 0000000000000000
origin: 00000000d9400053
 save_stack_trace+0x16/0x20 arch/x86/kernel/stacktrace.c:59
 kmsan_save_stack_with_flags mm/kmsan/kmsan.c:362
 kmsan_internal_poison_shadow+0xb1/0x1a0 mm/kmsan/kmsan.c:257
 kmsan_poison_shadow+0x6d/0xc0 mm/kmsan/kmsan.c:270
 slab_alloc_node mm/slub.c:2735
 __kmalloc_node_track_caller+0x1f4/0x390 mm/slub.c:4341
 __kmalloc_reserve net/core/skbuff.c:138
 __alloc_skb+0x2cd/0x740 net/core/skbuff.c:231
 alloc_skb ./include/linux/skbuff.h:933
 alloc_skb_with_frags+0x209/0xbc0 net/core/skbuff.c:4678
 sock_alloc_send_pskb+0x9ff/0xe00 net/core/sock.c:1903
 sock_alloc_send_skb+0xe4/0x100 net/core/sock.c:1920
 rawv6_send_hdrinc net/ipv6/raw.c:638
 rawv6_sendmsg+0x2918/0x41a0 net/ipv6/raw.c:919
 inet_sendmsg+0x3f8/0x6d0 net/ipv4/af_inet.c:762
 sock_sendmsg_nosec net/socket.c:633
 sock_sendmsg net/socket.c:643
 SYSC_sendto+0x6a5/0x7c0 net/socket.c:1696
 SyS_sendto+0xbc/0xe0 net/socket.c:1664
 do_syscall_64+0x72/0xa0 arch/x86/entry/common.c:285
 return_from_SYSCALL_64+0x0/0x6a arch/x86/entry/entry_64.S:246
==================================================================

, triggered by the following syscalls:
  socket(PF_INET6, SOCK_RAW, IPPROTO_RAW) = 3
  sendto(3, NULL, 0, 0, {sa_family=AF_INET6, sin6_port=htons(0), inet_pton(AF_INET6, "ff00::", &sin6_addr), sin6_flowinfo=0, sin6_scope_id=0}, 28) = -1 EPERM

A similar report is triggered in net/ipv4/raw.c if we use a PF_INET socket
instead of a PF_INET6 one.

Signed-off-by: Alexander Potapenko <glider@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2017-05-04 11:02:46 -04:00
..
netfilter
Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next
2017-05-01 10:47:53 -04:00
af_inet.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next
2017-05-02 16:40:27 -07:00
ah4.c
IPsec: do not ignore crypto err in ah4 input
2017-01-16 12:57:48 +01:00
arp.c
neighbour: fix nlmsg_pid in notifications
2017-03-22 10:48:49 -07:00
cipso_ipv4.c
netlabel: out of bound access in cipso_v4_validate()
2017-02-04 19:44:22 -05:00
datagram.c
…
devinet.c
net: rtnetlink: plumb extended ack to doit function
2017-04-17 15:35:38 -04:00
esp4_offload.c
esp4/6: Fix GSO path for non-GSO SW-crypto packets
2017-04-19 07:48:57 +02:00
esp4.c
net/esp4: Fix invalid esph pointer crash
2017-05-01 14:58:50 -04:00
fib_frontend.c
net: fib: Decrease one unnecessary rt cache flush in fib_disable_ip
2017-04-27 16:33:30 -04:00
fib_lookup.h
…
fib_notifier.c
ipv4: fib: Remove redundant argument
2017-03-10 09:45:09 -08:00
fib_rules.c
ipv4: fib_rules: Dump FIB rules when registering FIB notifier
2017-03-16 10:18:34 -07:00
fib_semantics.c
net: ipv4: add support for ECMP hash policy choice
2017-03-21 15:27:19 -07:00
fib_trie.c
ipv4: fib: Remove redundant argument
2017-03-10 09:45:09 -08:00
fou.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
2016-10-30 12:42:58 -04:00
gre_demux.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
2016-06-30 05:03:36 -04:00
gre_offload.c
net: add recursion limit to GRO
2016-10-20 14:32:22 -04:00
icmp.c
net: ipv4: add support for ECMP hash policy choice
2017-03-21 15:27:19 -07:00
igmp.c
igmp, mld: Fix memory leak in igmpv3/mld_del_delrec()
2017-02-09 16:43:45 -05:00
inet_connection_sock.c
net: Work around lockdep limitation in sockets that use sockets
2017-03-09 18:23:27 -08:00
inet_diag.c
tcp: remove early retransmit
2017-01-13 22:37:16 -05:00
inet_fragment.c
net: disable fragment reassembly if high_thresh is zero
2016-06-05 22:56:42 -04:00
inet_hashtables.c
inet: kill smallest_size and smallest_port
2017-01-18 13:04:29 -05:00
inet_timewait_sock.c
ipv4: Namespaceify tcp_tw_recycle and tcp_max_tw_buckets knob
2016-12-29 11:38:31 -05:00
inetpeer.c
net: Add helper function to compare inetpeer addresses
2015-08-28 13:32:36 -07:00
ip_forward.c
ipv4: allow local fragmentation in ip_finish_output_gso()
2016-11-03 16:10:26 -04:00
ip_fragment.c
inet: frag: release spinlock before calling icmp_send()
2017-03-22 15:40:45 -07:00
ip_gre.c
ip_tunnel: Allow policy-based routing through tunnels
2017-04-21 13:21:31 -04:00
ip_input.c
net: Add sysctl to toggle early demux for tcp and udp
2017-03-24 13:17:07 -07:00
ip_options.c
Replace <asm/uaccess.h> with <linux/uaccess.h> globally
2016-12-24 11:46:01 -08:00
ip_output.c
udp: avoid ufo handling on IP payload compression packets
2017-03-09 18:28:42 -08:00
ip_sockglue.c
ipv4: get rid of ip_ra_lock
2017-04-30 22:44:04 -04:00
ip_tunnel_core.c
netlink: pass extended ACK struct to parsing functions
2017-04-13 13:58:22 -04:00
ip_tunnel.c
ip_tunnel: Allow policy-based routing through tunnels
2017-04-21 13:21:31 -04:00
ip_vti.c
ip_tunnel: Allow policy-based routing through tunnels
2017-04-21 13:21:31 -04:00
ipcomp.c
…
ipconfig.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
2017-04-06 08:24:51 -07:00
ipip.c
ip_tunnel: Allow policy-based routing through tunnels
2017-04-21 13:21:31 -04:00
ipmr.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
2017-04-20 10:35:33 -04:00
Kconfig
Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next
2017-02-16 21:25:49 -05:00
Makefile
ipv4: fib: Move FIB notification code to a separate file
2017-03-10 09:45:09 -08:00
netfilter.c
netfilter: use skb_to_full_sk in ip_route_me_harder
2017-02-28 12:49:36 +01:00
ping.c
ping: implement proper locking
2017-03-24 20:50:28 -07:00
proc.c
net/tcp_fastopen: Add snmp counter for blackhole detection
2017-04-24 14:27:17 -04:00
protocol.c
net: Add sysctl to toggle early demux for tcp and udp
2017-03-24 13:17:07 -07:00
raw_diag.c
net: ip, raw_diag -- Use jump for exiting from nested loop
2016-11-03 15:25:26 -04:00
raw.c
ipv4, ipv6: ensure raw socket message is big enough to hold an IP header
2017-05-04 11:02:46 -04:00
route.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
2017-04-26 22:39:08 -04:00
syncookies.c
syncookies: use SipHash in place of SHA1
2017-01-09 13:58:57 -05:00
sysctl_net_ipv4.c
net/tcp_fastopen: Disable active side TFO in certain scenarios
2017-04-24 14:27:17 -04:00
tcp_bbr.c
tcp_bbr: add a state transition diagram and accompanying comment
2016-10-29 17:12:43 -04:00
tcp_bic.c
tcp: replace cnt & rtt with struct in pkts_acked()
2016-05-11 14:43:19 -04:00
tcp_cdg.c
sched/headers: Prepare for new header dependencies before moving code to <linux/sched/clock.h>
2017-03-02 08:42:27 +01:00
tcp_cong.c
tcp: memset ca_priv data to 0 properly
2017-04-26 14:58:32 -04:00
tcp_cubic.c
tcp_cubic: fix typo in module param description
2017-04-20 16:16:44 -04:00
tcp_dctcp.c
Revert "dctcp: update cwnd on congestion event"
2016-12-06 11:34:24 -05:00
tcp_diag.c
net: diag: Fix refcnt leak in error path destroying socket
2016-08-23 23:11:36 -07:00
tcp_fastopen.c
net/tcp_fastopen: Add snmp counter for blackhole detection
2017-04-24 14:27:17 -04:00
tcp_highspeed.c
tcp: add cwnd_undo functions to various tcp cc algorithms
2016-11-21 13:20:17 -05:00
tcp_htcp.c
tcp: replace cnt & rtt with struct in pkts_acked()
2016-05-11 14:43:19 -04:00
tcp_hybla.c
tcp: make undo_cwnd mandatory for congestion modules
2016-11-21 13:20:17 -05:00
tcp_illinois.c
tcp: add cwnd_undo functions to various tcp cc algorithms
2016-11-21 13:20:17 -05:00
tcp_input.c
tcp: switch rcv_rtt_est and rcvq_space to high resolution timestamps
2017-04-26 14:44:39 -04:00
tcp_ipv4.c
net/tcp_fastopen: Disable active side TFO in certain scenarios
2017-04-24 14:27:17 -04:00
tcp_lp.c
tcp: fix wraparound issue in tcp_lp
2017-05-02 15:07:02 -04:00
tcp_metrics.c
tcp: remove per-destination timestamp cache
2017-03-16 20:33:56 -07:00
tcp_minisocks.c
tcp: do not inherit fastopen_req from parent
2017-05-04 11:00:04 -04:00
tcp_nv.c
tcp: add NV congestion control
2016-06-10 23:07:49 -07:00
tcp_offload.c
gso: Support partial splitting at the frag_list pointer
2016-09-19 20:59:34 -04:00
tcp_output.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next
2017-05-02 16:40:27 -07:00
tcp_probe.c
tcp: Revert "tcp: tcp_probe: use spin_lock_bh()"
2017-02-21 13:26:03 -05:00
tcp_rate.c
tcp: do not pass timestamp to tcp_rate_gen()
2017-04-26 14:44:38 -04:00
tcp_recovery.c
tcp: tcp_rack_reo_timeout() must update tp->tcp_mstamp
2017-04-27 11:46:15 -04:00
tcp_scalable.c
tcp: add cwnd_undo functions to various tcp cc algorithms
2016-11-21 13:20:17 -05:00
tcp_timer.c
net/tcp_fastopen: Remove mss check in tcp_write_timeout()
2017-04-24 14:27:17 -04:00
tcp_vegas.c
tcp: make undo_cwnd mandatory for congestion modules
2016-11-21 13:20:17 -05:00
tcp_vegas.h
tcp: replace cnt & rtt with struct in pkts_acked()
2016-05-11 14:43:19 -04:00
tcp_veno.c
tcp: add cwnd_undo functions to various tcp cc algorithms
2016-11-21 13:20:17 -05:00
tcp_westwood.c
tcp_westwood: fix tcp_westwood_info() style mistakes
2017-03-16 20:23:28 -07:00
tcp_yeah.c
tcp: add cwnd_undo functions to various tcp cc algorithms
2016-11-21 13:20:17 -05:00
tcp.c
tcp: fix access to sk->sk_state in tcp_poll()
2017-04-30 22:24:16 -04:00
tunnel4.c
tunnels: correct conditional build of MPLS and IPv6
2016-07-11 13:27:06 -07:00
udp_diag.c
net: inet: diag: expose the socket mark to privileged processes.
2016-09-08 16:13:09 -07:00
udp_impl.h
udplite: call proper backlog handlers
2016-11-24 15:32:14 -05:00
udp_offload.c
udp: disable inner UDP checksum offloads in IPsec case
2017-04-24 13:48:54 -04:00
udp_tunnel.c
net: Remove deprecated tunnel specific UDP offload functions
2016-06-17 20:23:32 -07:00
udp.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
2017-02-07 16:29:30 -05:00
udplite.c
udplite: call proper backlog handlers
2016-11-24 15:32:14 -05:00
xfrm4_input.c
esp: Add a software GRO codepath
2017-02-15 11:04:11 +01:00
xfrm4_mode_beet.c
…
xfrm4_mode_transport.c
xfrm: Add encapsulation header offsets while SKB is not encrypted
2017-04-14 10:07:39 +02:00
xfrm4_mode_tunnel.c
xfrm: Add encapsulation header offsets while SKB is not encrypted
2017-04-14 10:07:39 +02:00
xfrm4_output.c
xfrm: Add an IPsec hardware offloading API
2017-04-14 10:06:10 +02:00
xfrm4_policy.c
xfrm: policy: make policy backend const
2017-02-09 10:22:19 +01:00
xfrm4_protocol.c
xfrm: input: constify xfrm_input_afinfo
2017-02-09 10:22:17 +01:00
xfrm4_state.c
xfrm: remove unused function
2017-01-10 10:57:12 +01:00
xfrm4_tunnel.c
…