00085f1efa
The dma-mapping core and the implementations do not change the DMA attributes passed by pointer. Thus the pointer can point to const data. However the attributes do not have to be a bitfield. Instead unsigned long will do fine: 1. This is just simpler. Both in terms of reading the code and setting attributes. Instead of initializing local attributes on the stack and passing pointer to it to dma_set_attr(), just set the bits. 2. It brings safeness and checking for const correctness because the attributes are passed by value. Semantic patches for this change (at least most of them): virtual patch virtual context @r@ identifier f, attrs; @@ f(..., - struct dma_attrs *attrs + unsigned long attrs , ...) { ... } @@ identifier r.f; @@ f(..., - NULL + 0 ) and // Options: --all-includes virtual patch virtual context @r@ identifier f, attrs; type t; @@ t f(..., struct dma_attrs *attrs); @@ identifier r.f; @@ f(..., - NULL + 0 ) Link: http://lkml.kernel.org/r/1468399300-5399-2-git-send-email-k.kozlowski@samsung.com Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Acked-by: Vineet Gupta <vgupta@synopsys.com> Acked-by: Robin Murphy <robin.murphy@arm.com> Acked-by: Hans-Christian Noren Egtvedt <egtvedt@samfundet.no> Acked-by: Mark Salter <msalter@redhat.com> [c6x] Acked-by: Jesper Nilsson <jesper.nilsson@axis.com> [cris] Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> [drm] Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com> Acked-by: Joerg Roedel <jroedel@suse.de> [iommu] Acked-by: Fabien Dessenne <fabien.dessenne@st.com> [bdisp] Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com> [vb2-core] Acked-by: David Vrabel <david.vrabel@citrix.com> [xen] Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> [xen swiotlb] Acked-by: Joerg Roedel <jroedel@suse.de> [iommu] Acked-by: Richard Kuo <rkuo@codeaurora.org> [hexagon] Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> [m68k] Acked-by: Gerald Schaefer <gerald.schaefer@de.ibm.com> [s390] Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org> Acked-by: Hans-Christian Noren Egtvedt <egtvedt@samfundet.no> [avr32] Acked-by: Vineet Gupta <vgupta@synopsys.com> [arc] Acked-by: Robin Murphy <robin.murphy@arm.com> [arm64 and dma-iommu] Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> |
||
---|---|---|
.. | ||
.gitignore | ||
acpi-ext.c | ||
acpi.c | ||
asm-offsets.c | ||
audit.c | ||
brl_emu.c | ||
crash_dump.c | ||
crash.c | ||
cyclone.c | ||
dma-mapping.c | ||
efi_stub.S | ||
efi.c | ||
elfcore.c | ||
entry.h | ||
entry.S | ||
err_inject.c | ||
esi_stub.S | ||
esi.c | ||
fsys.S | ||
fsyscall_gtod_data.h | ||
ftrace.c | ||
gate-data.S | ||
gate.lds.S | ||
gate.S | ||
head.S | ||
ia64_ksyms.c | ||
init_task.c | ||
iosapic.c | ||
irq_ia64.c | ||
irq_lsapic.c | ||
irq.c | ||
ivt.S | ||
jprobes.S | ||
kprobes.c | ||
machine_kexec.c | ||
machvec.c | ||
Makefile | ||
Makefile.gate | ||
mca_asm.S | ||
mca_drv_asm.S | ||
mca_drv.c | ||
mca_drv.h | ||
mca.c | ||
minstate.h | ||
module.c | ||
msi_ia64.c | ||
nr-irqs.c | ||
numa.c | ||
pal.S | ||
palinfo.c | ||
patch.c | ||
pci-dma.c | ||
pci-swiotlb.c | ||
perfmon_default_smpl.c | ||
perfmon_generic.h | ||
perfmon_itanium.h | ||
perfmon_mckinley.h | ||
perfmon_montecito.h | ||
perfmon.c | ||
process.c | ||
ptrace.c | ||
relocate_kernel.S | ||
sal.c | ||
salinfo.c | ||
setup.c | ||
sigframe.h | ||
signal.c | ||
smp.c | ||
smpboot.c | ||
stacktrace.c | ||
sys_ia64.c | ||
time.c | ||
topology.c | ||
traps.c | ||
unaligned.c | ||
uncached.c | ||
unwind_decoder.c | ||
unwind_i.h | ||
unwind.c | ||
vmlinux.lds.S |