Andrea Righi 27ac792ca0 PAGE_ALIGN(): correctly handle 64-bit values on 32-bit architectures
On 32-bit architectures PAGE_ALIGN() truncates 64-bit values to the 32-bit
boundary. For example:

	u64 val = PAGE_ALIGN(size);

always returns a value < 4GB even if size is greater than 4GB.

The problem resides in PAGE_MASK definition (from include/asm-x86/page.h for
example):

#define PAGE_SHIFT      12
#define PAGE_SIZE       (_AC(1,UL) << PAGE_SHIFT)
#define PAGE_MASK       (~(PAGE_SIZE-1))
...
#define PAGE_ALIGN(addr)       (((addr)+PAGE_SIZE-1)&PAGE_MASK)

The "~" is performed on a 32-bit value, so everything in "and" with
PAGE_MASK greater than 4GB will be truncated to the 32-bit boundary.
Using the ALIGN() macro seems to be the right way, because it uses
typeof(addr) for the mask.

Also move the PAGE_ALIGN() definitions out of include/asm-*/page.h in
include/linux/mm.h.

See also lkml discussion: http://lkml.org/lkml/2008/6/11/237

[akpm@linux-foundation.org: fix drivers/media/video/uvc/uvc_queue.c]
[akpm@linux-foundation.org: fix v850]
[akpm@linux-foundation.org: fix powerpc]
[akpm@linux-foundation.org: fix arm]
[akpm@linux-foundation.org: fix mips]
[akpm@linux-foundation.org: fix drivers/media/video/pvrusb2/pvrusb2-dvb.c]
[akpm@linux-foundation.org: fix drivers/mtd/maps/uclinux.c]
[akpm@linux-foundation.org: fix powerpc]
Signed-off-by: Andrea Righi <righi.andrea@gmail.com>
Cc: <linux-arch@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-07-24 10:47:21 -07:00
..
2008-07-17 11:27:05 -07:00
2008-04-08 13:51:35 -07:00
2008-01-30 13:34:07 +01:00
2005-09-07 16:57:21 -07:00
2006-12-12 12:00:55 -08:00
2006-01-08 20:14:02 -08:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2007-10-19 11:53:41 -07:00
2008-02-03 16:32:51 +02:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2007-02-05 18:46:40 -08:00
2008-05-01 08:04:01 -07:00
2008-03-12 16:27:35 -07:00
2005-04-16 15:20:36 -07:00
2007-07-17 10:23:11 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2007-07-25 12:56:39 -07:00
2005-04-16 15:20:36 -07:00
2008-04-18 00:46:35 +02:00
2008-05-01 08:04:01 -07:00
2006-01-10 08:01:34 -08:00
2005-04-16 15:20:36 -07:00
2008-05-27 15:09:30 -07:00
2008-05-18 14:34:16 +03:00
2007-05-08 11:15:20 -07:00
2006-03-24 13:12:46 -08:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2008-02-04 15:42:06 -08:00
2008-04-22 08:56:38 -07:00
2008-04-11 15:21:35 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2008-04-08 13:51:35 -07:00
2008-04-09 13:05:54 -07:00
2008-02-11 13:23:46 -08:00
2005-04-16 15:20:36 -07:00
2008-05-27 13:24:39 -07:00
2007-07-12 16:04:39 -07:00
2005-04-16 15:20:36 -07:00
2005-05-18 16:14:30 -07:00
2008-04-28 08:58:23 -07:00
2007-05-11 08:29:34 -07:00
2007-01-11 18:18:22 -08:00
2005-04-16 15:20:36 -07:00
2008-05-27 13:24:39 -07:00
2005-04-16 15:20:36 -07:00
2008-05-27 13:24:39 -07:00
2005-04-16 15:20:36 -07:00
2008-04-17 10:42:34 -04:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2007-02-12 09:48:39 -08:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-05-01 08:59:08 -07:00
2008-07-17 10:53:37 -07:00
2007-10-19 11:53:41 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2008-05-01 14:29:44 -07:00
2006-02-15 13:37:04 -08:00
2005-04-16 15:20:36 -07:00
2008-02-07 08:42:30 -08:00
2005-04-16 15:20:36 -07:00