Namhyung Kim 4a86d41404 perf tools: Allow build-id with trailing zeros
Currently perf saves a build-id with size but old versions assumes the
size of 20.  In case the build-id is less than 20 (like for MD5), it'd
fill the rest with 0s.

I saw a problem when old version of perf record saved a binary in the
build-id cache and new version of perf reads the data.  The symbols
should be read from the build-id cache (as the path no longer has the
same binary) but it failed due to mismatch in the build-id.

  symsrc__init: build id mismatch for /home/namhyung/.debug/.build-id/53/e4c2f42a4c61a2d632d92a72afa08f00000000/elf.

The build-id event in the data has 20 byte build-ids, but it saw a
different size (16) when it reads the build-id of the elf file in the
build-id cache.

  $ readelf -n ~/.debug/.build-id/53/e4c2f42a4c61a2d632d92a72afa08f00000000/elf

  Displaying notes found in: .note.gnu.build-id
    Owner                Data size 	Description
    GNU                  0x00000010	NT_GNU_BUILD_ID (unique build ID bitstring)
      Build ID: 53e4c2f42a4c61a2d632d92a72afa08f

Let's fix this by allowing trailing zeros if the size is different.

Fixes: 39be8d0115b321ed ("perf tools: Pass build_id object to dso__build_id_equal()")
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Jiri Olsa <jolsa@redhat.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/20210910224630.1084877-1-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2021-09-11 16:04:47 -03:00
..
2020-01-14 12:02:19 -03:00
2019-02-19 16:11:56 -03:00
2019-02-19 16:11:56 -03:00
2020-10-14 13:34:26 -03:00
2021-09-03 08:15:10 -03:00
2021-04-29 10:30:58 -03:00
2021-08-11 09:35:44 -03:00
2021-08-11 09:35:44 -03:00
2020-06-22 16:28:09 -03:00
2021-02-03 13:10:44 -03:00
2021-07-15 17:30:22 -03:00
2021-08-31 16:21:17 -03:00
2021-09-03 08:33:26 -03:00
2021-07-14 10:05:35 -03:00
2021-09-03 08:33:26 -03:00
2021-09-03 08:33:26 -03:00
2019-01-25 15:12:09 +01:00
2020-10-14 13:34:26 -03:00
2021-02-17 15:15:06 -03:00
2021-02-17 15:15:06 -03:00
2020-04-18 09:05:01 -03:00
2020-04-18 09:05:01 -03:00