39a594dc0b
Delete the 'removing' flag and don't kick init_completion to make a quick cancel of dsp_work(). Just let it timeout on the wait for the completion. Simplify the code to standard cancelling or flushing of the work. This avoids introducing corner cases from a layer of custom signalling. It also avoids potential race conditions when system-suspend handling is added. Unless the hardware is broken, the dsp_work() will already have started and passed the completion before the driver would want to cancel it. Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com> Link: https://lore.kernel.org/r/168122674746.26.16881587647873355224@mailman-core.alsa-project.org Signed-off-by: Mark Brown <broonie@kernel.org>
83 lines
2.4 KiB
C
83 lines
2.4 KiB
C
/* SPDX-License-Identifier: GPL-2.0-only */
|
|
/*
|
|
* Driver for Cirrus Logic CS35L56 smart amp
|
|
*
|
|
* Copyright (C) 2023 Cirrus Logic, Inc. and
|
|
* Cirrus Logic International Semiconductor Ltd.
|
|
*/
|
|
|
|
#ifndef CS35L56_H
|
|
#define CS35L56_H
|
|
|
|
#include <linux/completion.h>
|
|
#include <linux/regulator/consumer.h>
|
|
#include <linux/pm_runtime.h>
|
|
#include <linux/workqueue.h>
|
|
#include <sound/cs35l56.h>
|
|
#include "wm_adsp.h"
|
|
|
|
#define CS35L56_SDW_GEN_INT_STAT_1 0xc0
|
|
#define CS35L56_SDW_GEN_INT_MASK_1 0xc1
|
|
#define CS35L56_SDW_INT_MASK_CODEC_IRQ BIT(0)
|
|
|
|
#define CS35L56_SDW_INVALID_BUS_SCALE 0xf
|
|
|
|
#define CS35L56_RX_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE)
|
|
#define CS35L56_TX_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE \
|
|
| SNDRV_PCM_FMTBIT_S32_LE)
|
|
|
|
#define CS35L56_RATES (SNDRV_PCM_RATE_48000)
|
|
|
|
struct sdw_slave;
|
|
|
|
struct cs35l56_private {
|
|
struct wm_adsp dsp; /* must be first member */
|
|
struct work_struct dsp_work;
|
|
struct workqueue_struct *dsp_wq;
|
|
struct completion dsp_ready_completion;
|
|
struct mutex irq_lock;
|
|
struct snd_soc_component *component;
|
|
struct device *dev;
|
|
struct regmap *regmap;
|
|
struct regulator_bulk_data supplies[CS35L56_NUM_BULK_SUPPLIES];
|
|
int irq;
|
|
struct sdw_slave *sdw_peripheral;
|
|
u8 rev;
|
|
struct work_struct sdw_irq_work;
|
|
bool secured;
|
|
bool sdw_irq_no_unmask;
|
|
bool soft_resetting;
|
|
bool init_done;
|
|
bool sdw_attached;
|
|
bool fw_patched;
|
|
bool can_hibernate;
|
|
struct completion init_completion;
|
|
struct gpio_desc *reset_gpio;
|
|
|
|
u32 rx_mask;
|
|
u32 tx_mask;
|
|
u8 asp_slot_width;
|
|
u8 asp_slot_count;
|
|
bool tdm_mode;
|
|
bool sysclk_set;
|
|
u8 old_sdw_clock_scale;
|
|
};
|
|
|
|
extern const struct dev_pm_ops cs35l56_pm_ops_i2c_spi;
|
|
|
|
int cs35l56_runtime_suspend(struct device *dev);
|
|
int cs35l56_runtime_resume_common(struct cs35l56_private *cs35l56);
|
|
int cs35l56_system_suspend(struct device *dev);
|
|
int cs35l56_system_suspend_late(struct device *dev);
|
|
int cs35l56_system_suspend_no_irq(struct device *dev);
|
|
int cs35l56_system_resume_no_irq(struct device *dev);
|
|
int cs35l56_system_resume_early(struct device *dev);
|
|
int cs35l56_system_resume(struct device *dev);
|
|
irqreturn_t cs35l56_irq(int irq, void *data);
|
|
int cs35l56_irq_request(struct cs35l56_private *cs35l56);
|
|
int cs35l56_common_probe(struct cs35l56_private *cs35l56);
|
|
int cs35l56_init(struct cs35l56_private *cs35l56);
|
|
int cs35l56_remove(struct cs35l56_private *cs35l56);
|
|
|
|
#endif /* ifndef CS35L56_H */
|