iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net/dccp
History
Eric Dumazet 04c494e68a Revert "tcp/dccp: get rid of inet_twsk_purge()" 
This reverts commits:

0dad4087a86a2cbe177404dc73f18ada26a2c390 ("tcp/dccp: get rid of inet_twsk_purge()")
d507204d3c5cc57d9a8bdf0a477615bb59ea1611 ("tcp/dccp: add tw->tw_bslot")

As Leonard pointed out, a newly allocated netns can happen
to reuse a freed 'struct net'.

While TCP TW timers were covered by my patches, other things were not:

1) Lookups in rx path (INET_MATCH() and INET6_MATCH()), as they look
  at 4-tuple plus the 'struct net' pointer.

2) /proc/net/tcp[6] and inet_diag, same reason.

3) hashinfo->bhash[], same reason.

Fixing all this seems risky, lets instead revert.

In the future, we might have a per netns tcp hash table, or
a per netns list of timewait sockets...

Fixes: 0dad4087a86a ("tcp/dccp: get rid of inet_twsk_purge()")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Leonard Crestez <cdleonard@gmail.com>
Tested-by: Leonard Crestez <cdleonard@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2022-05-13 12:24:12 +01:00
..
ccids
dccp: tfrc: fix doc warnings in tfrc_equation.c
2021-06-10 14:08:49 -07:00
ackvec.c
net: dccp: Fix most of the kerneldoc warnings
2020-10-30 12:08:54 -07:00
ackvec.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
ccid.c
net: dccp: Add __printf() markup to fix -Wsuggest-attribute=format
2020-10-30 11:31:46 -07:00
ccid.h
net: dccp: Replace zero-length array with flexible-array member
2020-02-28 12:08:37 -08:00
dccp.h
dccp: remove max48()
2022-01-27 13:53:27 +00:00
diag.c
inet_diag: Move the INET_DIAG_REQ_BYTECODE nlattr to cb->data
2020-02-27 18:50:19 -08:00
feat.c
dccp: Return the correct errno code
2021-02-06 11:15:28 -08:00
feat.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
input.c
net: dccp: Convert to use the preferred fallthrough macro
2020-08-22 12:38:34 -07:00
ipv4.c
Revert "tcp/dccp: get rid of inet_twsk_purge()"
2022-05-13 12:24:12 +01:00
ipv6.c
Revert "tcp/dccp: get rid of inet_twsk_purge()"
2022-05-13 12:24:12 +01:00
ipv6.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
Kconfig
dccp: Replace HTTP links with HTTPS ones
2020-07-13 11:54:07 -07:00
Makefile
net: dccp: Remove dccpprobe module
2018-01-02 14:27:30 -05:00
minisocks.c
tcp: allocate tcp_death_row outside of struct netns_ipv4
2022-01-26 19:00:31 -08:00
options.c
net: dccp: Convert to use the preferred fallthrough macro
2020-08-22 12:38:34 -07:00
output.c
net: dccp: Fix most of the kerneldoc warnings
2020-10-30 12:08:54 -07:00
proto.c
dccp: Inline dccp_listen_start().
2021-11-23 20:16:22 -08:00
qpolicy.c
net: dccp: Fix most of the kerneldoc warnings
2020-10-30 12:08:54 -07:00
sysctl.c
proc/sysctl: add shared variables for range check
2019-07-18 17:08:07 -07:00
timer.c
net: sock: introduce sk_error_report
2021-06-29 11:28:21 -07:00
trace.h
net: dccp: Use memset_startat() for TP zeroing
2021-11-19 11:22:49 +00:00