Sven Van Asbroeck 2472d64af2 firmware: improve LSM/IMA security behaviour
The firmware loader queries if LSM/IMA permits it to load firmware
via the sysfs fallback. Unfortunately, the code does the opposite:
it expressly permits sysfs fw loading if security_kernel_load_data(
LOADING_FIRMWARE) returns -EACCES. This happens because a
zero-on-success return value is cast to a bool that's true on success.

Fix the return value handling so we get the correct behaviour.

Fixes: 6e852651f28e ("firmware: add call to LSM hook before firmware sysfs fallback")
Cc: Stable <stable@vger.kernel.org>
Cc: Mimi Zohar <zohar@linux.vnet.ibm.com>
Cc: Kees Cook <keescook@chromium.org>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Sven Van Asbroeck <TheSven73@gmail.com>
Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-06-18 09:10:02 +02:00
..
2019-05-31 10:38:35 -07:00
2019-06-02 09:27:44 -07:00
2019-05-31 08:34:32 -07:00
2019-05-25 10:11:23 -07:00
2019-05-31 08:34:32 -07:00
2019-05-31 08:34:32 -07:00
2019-05-31 08:34:32 -07:00
2019-05-31 08:34:32 -07:00
2019-06-02 10:14:25 -07:00
2019-05-31 08:34:32 -07:00
2019-05-31 08:34:32 -07:00
2019-05-25 10:11:23 -07:00
2019-05-24 16:02:14 -07:00
2019-06-02 09:26:34 -07:00
2019-06-02 09:26:34 -07:00
2019-05-31 08:34:32 -07:00
2019-05-31 10:53:34 -07:00